Title: [90436] trunk
- Revision
- 90436
- Author
- [email protected]
- Date
- 2011-07-05 22:29:48 -0700 (Tue, 05 Jul 2011)
Log Message
2011-06-29 Kent Tamura <[email protected]>
Reviewed by Alexey Proskuryakov.
[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573
* fast/forms/input-appearance-range.html:
Give a focus on a slider to check focus appearance.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/forms/input-appearance-range-expected.png:
2011-06-29 Kent Tamura <[email protected]>
Reviewed by Alexey Proskuryakov.
[Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb):
Need to pass the RenderObject of the owner <input> because
updateFocusedState() checks the outline style of the specified
renderer, and we'd like to make a slider thumb reflect the owner
focus style.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90435 => 90436)
--- trunk/LayoutTests/ChangeLog 2011-07-06 04:36:10 UTC (rev 90435)
+++ trunk/LayoutTests/ChangeLog 2011-07-06 05:29:48 UTC (rev 90436)
@@ -1,3 +1,15 @@
+2011-06-29 Kent Tamura <[email protected]>
+
+ Reviewed by Alexey Proskuryakov.
+
+ [Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
+ https://bugs.webkit.org/show_bug.cgi?id=63573
+
+ * fast/forms/input-appearance-range.html:
+ Give a focus on a slider to check focus appearance.
+ * platform/chromium/test_expectations.txt:
+ * platform/mac/fast/forms/input-appearance-range-expected.png:
+
2011-07-05 Eric Seidel <[email protected]>
buildbot needs to understand whether NRWT exited early after having too many failures
Modified: trunk/LayoutTests/fast/forms/input-appearance-range.html (90435 => 90436)
--- trunk/LayoutTests/fast/forms/input-appearance-range.html 2011-07-06 04:36:10 UTC (rev 90435)
+++ trunk/LayoutTests/fast/forms/input-appearance-range.html 2011-07-06 05:29:48 UTC (rev 90436)
@@ -2,9 +2,10 @@
<body>
<!--
You'll see
- - three horizontal sliders with various thumb positions.
- - a vertical slider
- - a slant slider
+ - three horizontal sliders with various thumb positions
+ - a vertical slider, and
+ - a slant slider.
+ The second slider has focus.
-->
<div><input type=range style="height: 30px;"></div>
@@ -14,4 +15,8 @@
<div><input type=range style="-webkit-appearance:slider-vertical; height:140px; margin-left:64px"></div>
<div><input type=range value=75 style="-webkit-transform: rotate(30deg)"></div>
+
+<script>
+document.getElementsByTagName('input')[1].focus();
+</script>
</body>
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90435 => 90436)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-06 04:36:10 UTC (rev 90435)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-06 05:29:48 UTC (rev 90436)
@@ -3945,6 +3945,9 @@
BUGCR87009 : fast/filesystem/async-operations.html = PASS CRASH
+// Test has been updated. Need rebaseline.
+BUGWK63573 : fast/forms/input-appearance-range.html = IMAGE
+
// Strange scrollbar.
BUGWK63115 : fast/css/font-face-in-shadow-DOM.html = PASS IMAGE+TEXT
Modified: trunk/LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (90435 => 90436)
--- trunk/Source/WebCore/ChangeLog 2011-07-06 04:36:10 UTC (rev 90435)
+++ trunk/Source/WebCore/ChangeLog 2011-07-06 05:29:48 UTC (rev 90436)
@@ -1,3 +1,17 @@
+2011-06-29 Kent Tamura <[email protected]>
+
+ Reviewed by Alexey Proskuryakov.
+
+ [Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
+ https://bugs.webkit.org/show_bug.cgi?id=63573
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintSliderThumb):
+ Need to pass the RenderObject of the owner <input> because
+ updateFocusedState() checks the outline style of the specified
+ renderer, and we'd like to make a slider thumb reflect the owner
+ focus style.
+
2011-07-05 Hans Wennborg <[email protected]>
[V8][Chromium] Remove use of OwnHandle from V8LocalContext
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (90435 => 90436)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2011-07-06 04:36:10 UTC (rev 90435)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2011-07-06 05:29:48 UTC (rev 90436)
@@ -1318,7 +1318,7 @@
// Update the various states we respond to.
updateActiveState(sliderThumbCell, o);
updateEnabledState(sliderThumbCell, o);
- updateFocusedState(sliderThumbCell, o);
+ updateFocusedState(sliderThumbCell, (o->node() && o->node()->focusDelegate()->renderer()) ? o->node()->focusDelegate()->renderer() : o);
// Update the pressed state using the NSCell tracking methods, since that's how NSSliderCell keeps track of it.
bool oldPressed;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
