Title: [90545] trunk/Tools
- Revision
- 90545
- Author
- [email protected]
- Date
- 2011-07-07 00:16:48 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Adam Barth <[email protected]>
REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
https://bugs.webkit.org/show_bug.cgi?id=64067
Reviewed by Eric Seidel.
The author of r90520 forgot to change the chromium_gpu.py implemenation
of this method as well.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90544 => 90545)
--- trunk/Tools/ChangeLog 2011-07-07 07:07:59 UTC (rev 90544)
+++ trunk/Tools/ChangeLog 2011-07-07 07:16:48 UTC (rev 90545)
@@ -1,3 +1,15 @@
+2011-07-07 Adam Barth <[email protected]>
+
+ REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
+ https://bugs.webkit.org/show_bug.cgi?id=64067
+
+ Reviewed by Eric Seidel.
+
+ The author of r90520 forgot to change the chromium_gpu.py implemenation
+ of this method as well.
+
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+
2011-07-06 Eric Seidel <[email protected]>
Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (90544 => 90545)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-07-07 07:07:59 UTC (rev 90544)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-07-07 07:16:48 UTC (rev 90545)
@@ -82,7 +82,7 @@
# invalidate_rect.html tests a bug in the compositor.
# See https://bugs.webkit.org/show_bug.cgi?id=53117
paths += ['plugins/invalidate_rect.html']
- return test_files.find(port, paths)
+ return set([port.relative_test_filename(f) for f in test_files.find(port, paths)])
class ChromiumGpuLinuxPort(chromium_linux.ChromiumLinuxPort):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (90544 => 90545)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py 2011-07-07 07:07:59 UTC (rev 90544)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py 2011-07-07 07:16:48 UTC (rev 90545)
@@ -79,22 +79,21 @@
else:
self.assertEqual(port._webkit_baseline_path('chromium-gpu'), paths[1])
-
# Test that we're limiting to the correct directories.
# These two tests are picked mostly at random, but we make sure they
# exist separately from being filtered out by the port.
files = port.tests(None)
- path = port.abspath_for_test('compositing/checkerboard.html')
- self.assertTrue(port._filesystem.exists(path))
+ path = 'compositing/checkerboard.html'
+ self.assertTrue(port._filesystem.exists(port.abspath_for_test(path)))
self.assertTrue(path in files)
- path = port.abspath_for_test('fast/html/keygen.html')
- self.assertTrue(port._filesystem.exists(path))
+ path = 'fast/html/keygen.html'
+ self.assertTrue(port._filesystem.exists(port.abspath_for_test(path)))
self.assertFalse(path in files)
if port_name.startswith('chromium-gpu-mac'):
- path = port.abspath_for_test('fast/canvas/set-colors.html')
- self.assertTrue(port._filesystem.exists(path))
+ path = 'fast/canvas/set-colors.html'
+ self.assertTrue(port._filesystem.exists(port.abspath_for_test(path)))
self.assertFalse(path in files)
def test_chromium_gpu__vista(self):
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
