Title: [91053] trunk
Revision
91053
Author
[email protected]
Date
2011-07-14 23:33:24 -0700 (Thu, 14 Jul 2011)

Log Message

Remove LegacyDefaultOptionalArguments flag from WebGL
https://bugs.webkit.org/show_bug.cgi?id=64549

Patch by Mark Pilgrim <[email protected]> on 2011-07-14
Reviewed by Kenneth Russell.

Source/WebCore:

* html/canvas/WebGLRenderingContext.idl:

LayoutTests:

* fast/canvas/webgl/bad-arguments-test-expected.txt:
* fast/canvas/webgl/bad-arguments-test.html:
* fast/canvas/webgl/context-lost-expected.txt:
* fast/canvas/webgl/context-lost.html:
* fast/canvas/webgl/null-object-behaviour-expected.txt:
* fast/canvas/webgl/null-object-behaviour.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (91052 => 91053)


--- trunk/LayoutTests/ChangeLog	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/ChangeLog	2011-07-15 06:33:24 UTC (rev 91053)
@@ -1,3 +1,17 @@
+2011-07-14  Mark Pilgrim  <[email protected]>
+
+        Remove LegacyDefaultOptionalArguments flag from WebGL
+        https://bugs.webkit.org/show_bug.cgi?id=64549
+
+        Reviewed by Kenneth Russell.
+
+        * fast/canvas/webgl/bad-arguments-test-expected.txt:
+        * fast/canvas/webgl/bad-arguments-test.html:
+        * fast/canvas/webgl/context-lost-expected.txt:
+        * fast/canvas/webgl/context-lost.html:
+        * fast/canvas/webgl/null-object-behaviour-expected.txt:
+        * fast/canvas/webgl/null-object-behaviour.html:
+
 2011-07-14  Yuta Kitamura  <[email protected]>
 
         WebSocket: Introduce pywebsocket-0.6b2

Modified: trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test-expected.txt (91052 => 91053)


--- trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test-expected.txt	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test-expected.txt	2011-07-15 06:33:24 UTC (rev 91053)
@@ -7,7 +7,6 @@
 PASS getUniformLocation succeeded
 PASS context.compileShader(argument) threw exception TypeError: Type error.
 PASS context.linkProgram(argument) threw exception TypeError: Type error.
-PASS context.attachShader(argument) threw exception TypeError: Type error.
 PASS context.attachShader(program, argument) threw exception TypeError: Type error.
 PASS context.attachShader(argument, shader) threw exception TypeError: Type error.
 PASS context.detachShader(program, argument) threw exception TypeError: Type error.
@@ -34,7 +33,6 @@
 PASS context.getShaderSource(argument) threw exception TypeError: Type error.
 PASS context.compileShader(argument) threw exception TypeError: Type error.
 PASS context.linkProgram(argument) threw exception TypeError: Type error.
-PASS context.attachShader(argument) threw exception TypeError: Type error.
 PASS context.attachShader(program, argument) threw exception TypeError: Type error.
 PASS context.attachShader(argument, shader) threw exception TypeError: Type error.
 PASS context.detachShader(program, argument) threw exception TypeError: Type error.
@@ -61,7 +59,6 @@
 PASS context.getShaderSource(argument) threw exception TypeError: Type error.
 PASS context.compileShader(argument) is undefined.
 PASS context.linkProgram(argument) is undefined.
-PASS context.attachShader(argument) is undefined.
 PASS context.attachShader(program, argument) is undefined.
 PASS context.attachShader(argument, shader) is undefined.
 PASS context.detachShader(program, argument) is undefined.
@@ -88,7 +85,6 @@
 PASS context.getShaderSource(argument) is ''
 PASS context.compileShader(argument) is undefined.
 PASS context.linkProgram(argument) is undefined.
-PASS context.attachShader(argument) is undefined.
 PASS context.attachShader(program, argument) is undefined.
 PASS context.attachShader(argument, shader) is undefined.
 PASS context.detachShader(program, argument) is undefined.

Modified: trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test.html (91052 => 91053)


--- trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test.html	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/fast/canvas/webgl/bad-arguments-test.html	2011-07-15 06:33:24 UTC (rev 91053)
@@ -55,7 +55,6 @@
   argument = arguments[i].value;
   func("context.compileShader(argument)");
   func("context.linkProgram(argument)");
-  func("context.attachShader(argument)");
   func("context.attachShader(program, argument)");
   func("context.attachShader(argument, shader)");
   func("context.detachShader(program, argument)");

Modified: trunk/LayoutTests/fast/canvas/webgl/context-lost-expected.txt (91052 => 91053)


--- trunk/LayoutTests/fast/canvas/webgl/context-lost-expected.txt	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/fast/canvas/webgl/context-lost-expected.txt	2011-07-15 06:33:24 UTC (rev 91053)
@@ -34,8 +34,8 @@
 PASS gl.blendColor(1.0, 1.0, 1.0, 1.0) was expected value: NO_ERROR.
 PASS gl.blendEquation(gl.FUNC_ADD) was expected value: NO_ERROR.
 PASS gl.blendEquationSeparate(gl.FUNC_ADD, gl.FUNC_ADD) was expected value: NO_ERROR.
-PASS gl.blendFunc(gl.ONE) was expected value: NO_ERROR.
-PASS gl.blendFuncSeparate(gl.ONE, gl.ONE) was expected value: NO_ERROR.
+PASS gl.blendFunc(gl.ONE, gl.ONE) was expected value: NO_ERROR.
+PASS gl.blendFuncSeparate(gl.ONE, gl.ONE, gl.ONE, gl.ONE) was expected value: NO_ERROR.
 PASS gl.bufferData(gl.ARRAY_BUFFER, 0, gl.STATIC_DRAW) was expected value: NO_ERROR.
 PASS gl.bufferData(gl.ARRAY_BUFFER, arrayBufferView, gl.STATIC_DRAW) was expected value: NO_ERROR.
 PASS gl.bufferData(gl.ARRAY_BUFFER, arrayBuffer, gl.STATIC_DRAW) was expected value: NO_ERROR.

Modified: trunk/LayoutTests/fast/canvas/webgl/context-lost.html (91052 => 91053)


--- trunk/LayoutTests/fast/canvas/webgl/context-lost.html	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/fast/canvas/webgl/context-lost.html	2011-07-15 06:33:24 UTC (rev 91053)
@@ -132,8 +132,8 @@
         "gl.blendColor(1.0, 1.0, 1.0, 1.0)",
         "gl.blendEquation(gl.FUNC_ADD)",
         "gl.blendEquationSeparate(gl.FUNC_ADD, gl.FUNC_ADD)",
-        "gl.blendFunc(gl.ONE)",
-        "gl.blendFuncSeparate(gl.ONE, gl.ONE)",
+        "gl.blendFunc(gl.ONE, gl.ONE)",
+        "gl.blendFuncSeparate(gl.ONE, gl.ONE, gl.ONE, gl.ONE)",
         "gl.bufferData(gl.ARRAY_BUFFER, 0, gl.STATIC_DRAW)",
         "gl.bufferData(gl.ARRAY_BUFFER, arrayBufferView, gl.STATIC_DRAW)",
         "gl.bufferData(gl.ARRAY_BUFFER, arrayBuffer, gl.STATIC_DRAW)",

Modified: trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour-expected.txt (91052 => 91053)


--- trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour-expected.txt	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour-expected.txt	2011-07-15 06:33:24 UTC (rev 91053)
@@ -4,14 +4,14 @@
 
 PASS Program Compiled
 PASS Shader Compiled
-PASS context.compileShader() was expected value: INVALID_VALUE.
-PASS context.linkProgram() was expected value: INVALID_VALUE.
-PASS context.attachShader() was expected value: INVALID_VALUE.
+PASS context.compileShader(undefined) was expected value: INVALID_VALUE.
+PASS context.linkProgram(undefined) was expected value: INVALID_VALUE.
+PASS context.attachShader(undefined, undefined) was expected value: INVALID_VALUE.
 PASS context.attachShader(program, undefined) was expected value: INVALID_VALUE.
 PASS context.attachShader(undefined, shader) was expected value: INVALID_VALUE.
 PASS context.detachShader(program, undefined) was expected value: INVALID_VALUE.
 PASS context.detachShader(undefined, shader) was expected value: INVALID_VALUE.
-PASS context.shaderSource() was expected value: INVALID_VALUE.
+PASS context.shaderSource(undefined, undefined) was expected value: INVALID_VALUE.
 PASS context.shaderSource(undefined, 'foo') was expected value: INVALID_VALUE.
 PASS context.bindAttribLocation(undefined, 0, 'foo') was expected value: INVALID_VALUE.
 PASS context.bindBuffer(context.ARRAY_BUFFER, 0) threw exception TypeError: Type error.

Modified: trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour.html (91052 => 91053)


--- trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour.html	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/LayoutTests/fast/canvas/webgl/null-object-behaviour.html	2011-07-15 06:33:24 UTC (rev 91053)
@@ -20,14 +20,14 @@
 
 assertMsg(program != null, "Program Compiled");
 assertMsg(shader != null, "Shader Compiled");
-shouldGenerateGLError(context, context.INVALID_VALUE, "context.compileShader()");
-shouldGenerateGLError(context, context.INVALID_VALUE, "context.linkProgram()");
-shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader()");
+shouldGenerateGLError(context, context.INVALID_VALUE, "context.compileShader(undefined)");
+shouldGenerateGLError(context, context.INVALID_VALUE, "context.linkProgram(undefined)");
+shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader(undefined, undefined)");
 shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader(program, undefined)");
 shouldGenerateGLError(context, context.INVALID_VALUE, "context.attachShader(undefined, shader)");
 shouldGenerateGLError(context, context.INVALID_VALUE, "context.detachShader(program, undefined)");
 shouldGenerateGLError(context, context.INVALID_VALUE, "context.detachShader(undefined, shader)");
-shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource()");
+shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource(undefined, undefined)");
 shouldGenerateGLError(context, context.INVALID_VALUE, "context.shaderSource(undefined, 'foo')");
 shouldGenerateGLError(context, context.INVALID_VALUE, "context.bindAttribLocation(undefined, 0, 'foo')");
 shouldThrow("context.bindBuffer(context.ARRAY_BUFFER, 0)");

Modified: trunk/Source/WebCore/ChangeLog (91052 => 91053)


--- trunk/Source/WebCore/ChangeLog	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/Source/WebCore/ChangeLog	2011-07-15 06:33:24 UTC (rev 91053)
@@ -1,3 +1,12 @@
+2011-07-14  Mark Pilgrim  <[email protected]>
+
+        Remove LegacyDefaultOptionalArguments flag from WebGL
+        https://bugs.webkit.org/show_bug.cgi?id=64549
+
+        Reviewed by Kenneth Russell.
+
+        * html/canvas/WebGLRenderingContext.idl:
+
 2011-07-14  Yuta Kitamura  <[email protected]>
 
         WebSocket: Introduce pywebsocket-0.6b2

Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl (91052 => 91053)


--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl	2011-07-15 06:26:26 UTC (rev 91052)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl	2011-07-15 06:33:24 UTC (rev 91053)
@@ -27,7 +27,6 @@
 
     interface [
         Conditional=WEBGL,
-        LegacyDefaultOptionalArguments,
         InterfaceUUID=98fb48ae-7216-489c-862b-8e1217fc4443,
         ImplementationUUID=ab4f0781-152f-450e-9546-5b3987491a54,
         CustomMarkFunction,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to