Title: [91413] trunk/Tools
- Revision
- 91413
- Author
- [email protected]
- Date
- 2011-07-20 16:03:08 -0700 (Wed, 20 Jul 2011)
Log Message
Teach build.webkit.org how to identify leaks in NRWT output
https://bugs.webkit.org/show_bug.cgi?id=64891
Reviewed by Adam Barth.
This was the last remaining piece blocking turning on
NRWT for the leaks bot, so I did that in this change too.
If for some reason we see trouble on the bots, I'll
revert that part of this change.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/run-webkit-tests:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (91412 => 91413)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-20 22:16:53 UTC (rev 91412)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-20 23:03:08 UTC (rev 91413)
@@ -245,6 +245,9 @@
if line.find('Exiting early') >= 0:
incorrectLayoutLines.append(line)
continue
+ if line find('leaks found') >= 0:
+ incorrectLayoutLines.append(line)
+ continue
for name in expressions:
match = expressions[name].search(line)
if match:
Modified: trunk/Tools/ChangeLog (91412 => 91413)
--- trunk/Tools/ChangeLog 2011-07-20 22:16:53 UTC (rev 91412)
+++ trunk/Tools/ChangeLog 2011-07-20 23:03:08 UTC (rev 91413)
@@ -1,3 +1,18 @@
+2011-07-20 Eric Seidel <[email protected]>
+
+ Teach build.webkit.org how to identify leaks in NRWT output
+ https://bugs.webkit.org/show_bug.cgi?id=64891
+
+ Reviewed by Adam Barth.
+
+ This was the last remaining piece blocking turning on
+ NRWT for the leaks bot, so I did that in this change too.
+ If for some reason we see trouble on the bots, I'll
+ revert that part of this change.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ * Scripts/run-webkit-tests:
+
2011-07-20 Ojan Vafai <[email protected]>
make the treemap display more human friendly
Modified: trunk/Tools/Scripts/run-webkit-tests (91412 => 91413)
--- trunk/Tools/Scripts/run-webkit-tests 2011-07-20 22:16:53 UTC (rev 91412)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-07-20 23:03:08 UTC (rev 91413)
@@ -65,13 +65,6 @@
return grep(/(-2|--webkit-test-runner)/, @ARGV);
}
-sub usingLeaks()
-{
- # NRWT doesn't support --leaks yet.
- # https://bugs.webkit.org/show_bug.cgi?id=63832
- return grep(/--leaks/, @ARGV);
-}
-
sub useNewRunWebKitTests()
{
# Change this check to control which platforms use new-run-webkit-tests by default.
@@ -89,7 +82,7 @@
return (!usingWebKit2() and !isDarwin() and !isARM() and (getQtVersion() ne "4.8"));
}
- return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2() and !usingLeaks());
+ return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2());
}
my $harnessName = "old-run-webkit-tests";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
