Title: [91556] trunk
- Revision
- 91556
- Author
- tk...@chromium.org
- Date
- 2011-07-21 22:35:38 -0700 (Thu, 21 Jul 2011)
Log Message
A trivial fix for r91550.
https://bugs.webkit.org/show_bug.cgi?id=65001
Source/WebCore:
Need to update placeholder visibility when the owner elemnent style is changed.
* html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
Call updatePlaceholderVisibility().
LayoutTests:
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (91555 => 91556)
--- trunk/LayoutTests/ChangeLog 2011-07-22 05:34:08 UTC (rev 91555)
+++ trunk/LayoutTests/ChangeLog 2011-07-22 05:35:38 UTC (rev 91556)
@@ -1,3 +1,10 @@
+2011-07-21 Kent Tamura <tk...@chromium.org>
+
+ A trivial fix for r91550.
+ https://bugs.webkit.org/show_bug.cgi?id=65001
+
+ * platform/chromium/test_expectations.txt:
+
2011-07-21 Gavin Barraclough <barraclo...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64875
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91555 => 91556)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 05:34:08 UTC (rev 91555)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 05:35:38 UTC (rev 91556)
@@ -3846,4 +3846,3 @@
BUGRNIWA : fast/css/absolute-child-with-percent-height-inside-relative-parent.html = MISSING
BUGWK65009 MAC : scrollbars/scrollbar-drag-thumb-with-large-content.html = TEXT
-BUGWK65010 : fast/forms/placeholder-in-invisible-elements.html = IMAGE
Modified: trunk/Source/WebCore/ChangeLog (91555 => 91556)
--- trunk/Source/WebCore/ChangeLog 2011-07-22 05:34:08 UTC (rev 91555)
+++ trunk/Source/WebCore/ChangeLog 2011-07-22 05:35:38 UTC (rev 91556)
@@ -1,3 +1,15 @@
+2011-07-21 Kent Tamura <tk...@chromium.org>
+
+ A trivial fix for r91550.
+ https://bugs.webkit.org/show_bug.cgi?id=65001
+
+ Need to update placeholder visibility when the owner elemnent style is changed.
+
+ * html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public.
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+ Call updatePlaceholderVisibility().
+
2011-07-21 Pratik Solanki <psola...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=65002
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.h (91555 => 91556)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2011-07-22 05:34:08 UTC (rev 91555)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2011-07-22 05:35:38 UTC (rev 91556)
@@ -48,6 +48,7 @@
String strippedPlaceholder() const;
bool placeholderShouldBeVisible() const;
virtual HTMLElement* placeholderElement() const = 0;
+ void updatePlaceholderVisibility(bool);
int indexForVisiblePosition(const VisiblePosition&) const;
int selectionStart() const;
@@ -76,7 +77,6 @@
protected:
HTMLTextFormControlElement(const QualifiedName&, Document*, HTMLFormElement*);
- void updatePlaceholderVisibility(bool);
virtual void updatePlaceholderText() = 0;
virtual void parseMappedAttribute(Attribute*);
Modified: trunk/Source/WebCore/rendering/RenderTextControl.cpp (91555 => 91556)
--- trunk/Source/WebCore/rendering/RenderTextControl.cpp 2011-07-22 05:34:08 UTC (rev 91555)
+++ trunk/Source/WebCore/rendering/RenderTextControl.cpp 2011-07-22 05:35:38 UTC (rev 91556)
@@ -102,6 +102,7 @@
innerTextRenderer->setStyle(createInnerTextStyle(style()));
innerText->setNeedsStyleRecalc();
}
+ textFormControlElement()->updatePlaceholderVisibility(false);
}
static inline bool updateUserModifyProperty(Node* node, RenderStyle* style)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
