Title: [92157] trunk/Source/WebCore
Revision
92157
Author
commit-qu...@webkit.org
Date
2011-08-01 17:49:54 -0700 (Mon, 01 Aug 2011)

Log Message

Use threadsafeCopy() API when using Database Directory path variable
https://bugs.webkit.org/show_bug.cgi?id=65436

Patch by srikumar bonda <srikuma...@gmail.com> on 2011-08-01
Reviewed by David Levin.

Use threadsafeCopy() API while using m_databaseDirectoryPath string variable
when the databaseGuard lock hasn't been taken in DatabaseTracker class.
This is just a safety fix.

No changes to functionality so no new tests.

* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::deleteOrigin):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (92156 => 92157)


--- trunk/Source/WebCore/ChangeLog	2011-08-02 00:44:21 UTC (rev 92156)
+++ trunk/Source/WebCore/ChangeLog	2011-08-02 00:49:54 UTC (rev 92157)
@@ -1,3 +1,20 @@
+2011-08-01  srikumar bonda  <srikuma...@gmail.com>
+
+        Use threadsafeCopy() API when using Database Directory path variable 
+        https://bugs.webkit.org/show_bug.cgi?id=65436
+
+        Reviewed by David Levin.
+
+        Use threadsafeCopy() API while using m_databaseDirectoryPath string variable
+        when the databaseGuard lock hasn't been taken in DatabaseTracker class. 
+        This is just a safety fix.
+
+        No changes to functionality so no new tests.
+
+        * storage/DatabaseTracker.cpp:
+        (WebCore::DatabaseTracker::trackerDatabasePath):
+        (WebCore::DatabaseTracker::deleteOrigin):
+
 2011-08-01  Michael Nordman  <micha...@google.com>
 
         [Chromium] WebSQLDatabase version handling is broken in multi-process browsers.

Modified: trunk/Source/WebCore/storage/DatabaseTracker.cpp (92156 => 92157)


--- trunk/Source/WebCore/storage/DatabaseTracker.cpp	2011-08-02 00:44:21 UTC (rev 92156)
+++ trunk/Source/WebCore/storage/DatabaseTracker.cpp	2011-08-02 00:49:54 UTC (rev 92157)
@@ -102,7 +102,7 @@
 
 String DatabaseTracker::trackerDatabasePath() const
 {
-    return SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath, "Databases.db");
+    return SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath.threadsafeCopy(), "Databases.db");
 }
 
 void DatabaseTracker::openTrackerDatabase(bool createIfDoesNotExist)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to