Title: [92218] trunk/Tools
- Revision
- 92218
- Author
- aba...@webkit.org
- Date
- 2011-08-02 12:57:38 -0700 (Tue, 02 Aug 2011)
Log Message
TestFailures unit tests leak a global variable
https://bugs.webkit.org/show_bug.cgi?id=65500
Reviewed by Adam Roben.
qunit detects the leak if you check the "noglobals" box on run-unittests.html.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js (92217 => 92218)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js 2011-08-02 19:57:06 UTC (rev 92217)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js 2011-08-02 19:57:38 UTC (rev 92218)
@@ -45,7 +45,7 @@
// FIXME: It's lame to be modifying singletons like this. We should get rid
// of our singleton usage entirely!
- var realPersistentCache = window.PersistentCache;
+ ok(!("PersistentCache" in window));
window.PersistentCache = {
contains: function() { return false; },
set: function() { },
@@ -56,8 +56,7 @@
window.getResource = realGetResource;
equal(window.getResource, realGetResource);
- window.PersistentCache = realPersistentCache;
- equal(window.PersistentCache, realPersistentCache);
+ delete window.PersistentCache;
}
test("getNumberOfFailingTests shouldn't include leaks", 4, function() {
Modified: trunk/Tools/ChangeLog (92217 => 92218)
--- trunk/Tools/ChangeLog 2011-08-02 19:57:06 UTC (rev 92217)
+++ trunk/Tools/ChangeLog 2011-08-02 19:57:38 UTC (rev 92218)
@@ -1,3 +1,14 @@
+2011-08-02 Adam Barth <aba...@webkit.org>
+
+ TestFailures unit tests leak a global variable
+ https://bugs.webkit.org/show_bug.cgi?id=65500
+
+ Reviewed by Adam Roben.
+
+ qunit detects the leak if you check the "noglobals" box on run-unittests.html.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
+
2011-08-02 Alexandru Chiculita <ach...@adobe.com>
CSS Regions build bot should archive and upload output files
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
