Diff
Modified: trunk/Source/WebCore/ChangeLog (92235 => 92236)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 21:35:15 UTC (rev 92236)
@@ -1,3 +1,26 @@
+2011-08-02 Mark Pilgrim <pilg...@chromium.org>
+
+ Remove LegacyDefaultOptionalArguments flag from CSS IDL files
+ https://bugs.webkit.org/show_bug.cgi?id=65341
+
+ Reviewed by Adam Barth.
+
+ No new tests. All existing tests pass.
+
+ * css/CSSMediaRule.idl:
+ * css/CSSPrimitiveValue.idl:
+ * css/CSSRuleList.idl:
+ * css/CSSStyleDeclaration.idl:
+ * css/CSSStyleSheet.idl:
+ * css/CSSValueList.idl:
+ * css/MediaList.idl:
+ * css/MediaQueryList.idl:
+ * css/MediaQueryListListener.idl:
+ * css/StyleMedia.idl:
+ * css/StyleSheetList.idl:
+ * css/WebKitCSSKeyframesRule.idl:
+ * css/WebKitCSSMatrix.idl:
+
2011-08-02 Robert Kroeger <rjkro...@chromium.org>
[chromium] Layering violations in gesture recognizer
Modified: trunk/Source/WebCore/css/CSSMediaRule.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSMediaRule.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSMediaRule.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -21,16 +21,14 @@
module css {
// Introduced in DOM Level 2:
- interface [
- LegacyDefaultOptionalArguments,
- ] CSSMediaRule : CSSRule {
+ interface CSSMediaRule : CSSRule {
readonly attribute MediaList media;
readonly attribute CSSRuleList cssRules;
- [OldStyleObjC] unsigned long insertRule(in DOMString rule,
- in unsigned long index)
+ [OldStyleObjC] unsigned long insertRule(in [Optional=CallWithDefaultValue] DOMString rule,
+ in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
- void deleteRule(in unsigned long index)
+ void deleteRule(in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
};
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -19,9 +19,7 @@
module css {
- interface [
- LegacyDefaultOptionalArguments,
- ] CSSPrimitiveValue : CSSValue {
+ interface CSSPrimitiveValue : CSSValue {
// UnitTypes
const unsigned short CSS_UNKNOWN = 0;
@@ -53,13 +51,13 @@
readonly attribute unsigned short primitiveType;
- [OldStyleObjC] void setFloatValue(in unsigned short unitType,
- in float floatValue)
+ [OldStyleObjC] void setFloatValue(in [Optional=CallWithDefaultValue] unsigned short unitType,
+ in [Optional=CallWithDefaultValue] float floatValue)
raises(DOMException);
- float getFloatValue(in unsigned short unitType)
+ float getFloatValue(in [Optional=CallWithDefaultValue] unsigned short unitType)
raises(DOMException);
- [OldStyleObjC] void setStringValue(in unsigned short stringType,
- in DOMString stringValue)
+ [OldStyleObjC] void setStringValue(in [Optional=CallWithDefaultValue] unsigned short stringType,
+ in [Optional=CallWithDefaultValue] DOMString stringValue)
raises(DOMException);
DOMString getStringValue()
raises(DOMException);
Modified: trunk/Source/WebCore/css/CSSRuleList.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSRuleList.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSRuleList.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -27,13 +27,12 @@
// Introduced in DOM Level 2:
interface [
- LegacyDefaultOptionalArguments,
CustomIsReachable,
HasIndexGetter,
V8DependentLifetime
] CSSRuleList {
readonly attribute unsigned long length;
- CSSRule item(in unsigned long index);
+ CSSRule item(in [Optional=CallWithDefaultValue] unsigned long index);
};
}
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -22,7 +22,6 @@
// Introduced in DOM Level 2:
interface [
- LegacyDefaultOptionalArguments,
CustomMarkFunction,
GenerateIsReachable=ImplRoot,
DelegatingPutFunction,
@@ -33,23 +32,23 @@
attribute [ConvertNullStringTo=Null, ConvertNullToNullString] DOMString cssText
setter raises(DOMException);
- [ConvertNullStringTo=Null] DOMString getPropertyValue(in DOMString propertyName);
- [JSCCustom] CSSValue getPropertyCSSValue(in DOMString propertyName);
- [ConvertNullStringTo=Null] DOMString removeProperty(in DOMString propertyName)
+ [ConvertNullStringTo=Null] DOMString getPropertyValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
+ [JSCCustom] CSSValue getPropertyCSSValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
+ [ConvertNullStringTo=Null] DOMString removeProperty(in [Optional=CallWithDefaultValue] DOMString propertyName)
raises(DOMException);
- [ConvertNullStringTo=Null] DOMString getPropertyPriority(in DOMString propertyName);
- [OldStyleObjC] void setProperty(in DOMString propertyName,
- in [ConvertNullToNullString] DOMString value,
- in DOMString priority)
+ [ConvertNullStringTo=Null] DOMString getPropertyPriority(in [Optional=CallWithDefaultValue] DOMString propertyName);
+ [OldStyleObjC] void setProperty(in [Optional=CallWithDefaultValue] DOMString propertyName,
+ in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString value,
+ in [Optional=CallWithDefaultValue] DOMString priority)
raises(DOMException);
readonly attribute unsigned long length;
- DOMString item(in unsigned long index);
+ DOMString item(in [Optional=CallWithDefaultValue] unsigned long index);
readonly attribute CSSRule parentRule;
// Extensions
- [ConvertNullStringTo=Null] DOMString getPropertyShorthand(in DOMString propertyName);
- boolean isPropertyImplicit(in DOMString propertyName);
+ [ConvertNullStringTo=Null] DOMString getPropertyShorthand(in [Optional=CallWithDefaultValue] DOMString propertyName);
+ boolean isPropertyImplicit(in [Optional=CallWithDefaultValue] DOMString propertyName);
};
}
Modified: trunk/Source/WebCore/css/CSSStyleSheet.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSStyleSheet.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSStyleSheet.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -21,26 +21,24 @@
module css {
// Introduced in DOM Level 2:
- interface [
- LegacyDefaultOptionalArguments,
- ] CSSStyleSheet : StyleSheet {
+ interface CSSStyleSheet : StyleSheet {
readonly attribute CSSRule ownerRule;
readonly attribute CSSRuleList cssRules;
- [OldStyleObjC] unsigned long insertRule(in DOMString rule,
- in unsigned long index)
+ [OldStyleObjC] unsigned long insertRule(in [Optional=CallWithDefaultValue] DOMString rule,
+ in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
- void deleteRule(in unsigned long index)
+ void deleteRule(in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
// IE Extensions
readonly attribute CSSRuleList rules;
- long addRule(in DOMString selector,
- in DOMString style,
+ long addRule(in [Optional=CallWithDefaultValue] DOMString selector,
+ in [Optional=CallWithDefaultValue] DOMString style,
in [Optional] unsigned long index)
raises(DOMException);
- void removeRule(in unsigned long index)
+ void removeRule(in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
};
Modified: trunk/Source/WebCore/css/CSSValueList.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSValueList.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSValueList.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -27,11 +27,10 @@
// Introduced in DOM Level 2:
interface [
- LegacyDefaultOptionalArguments,
HasIndexGetter
] CSSValueList : CSSValue {
readonly attribute unsigned long length;
- CSSValue item(in unsigned long index);
+ CSSValue item(in [Optional=CallWithDefaultValue] unsigned long index);
};
}
Modified: trunk/Source/WebCore/css/MediaList.idl (92235 => 92236)
--- trunk/Source/WebCore/css/MediaList.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/MediaList.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -27,7 +27,6 @@
// Introduced in DOM Level 2:
interface [
- LegacyDefaultOptionalArguments,
GenerateIsReachable,
HasIndexGetter
] MediaList {
@@ -36,10 +35,10 @@
setter raises(DOMException);
readonly attribute unsigned long length;
- [ConvertNullStringTo=Null] DOMString item(in unsigned long index);
- void deleteMedium(in DOMString oldMedium)
+ [ConvertNullStringTo=Null] DOMString item(in [Optional=CallWithDefaultValue] unsigned long index);
+ void deleteMedium(in [Optional=CallWithDefaultValue] DOMString oldMedium)
raises(DOMException);
- void appendMedium(in DOMString newMedium)
+ void appendMedium(in [Optional=CallWithDefaultValue] DOMString newMedium)
raises(DOMException);
};
Modified: trunk/Source/WebCore/css/MediaQueryList.idl (92235 => 92236)
--- trunk/Source/WebCore/css/MediaQueryList.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/MediaQueryList.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -18,12 +18,10 @@
*/
module view {
- interface [
- LegacyDefaultOptionalArguments,
- ] MediaQueryList {
+ interface MediaQueryList {
readonly attribute DOMString media;
readonly attribute boolean matches;
- void addListener(in MediaQueryListListener listener);
- void removeListener(in MediaQueryListListener listener);
+ void addListener(in [Optional=CallWithDefaultValue] MediaQueryListListener listener);
+ void removeListener(in [Optional=CallWithDefaultValue] MediaQueryListListener listener);
};
}
Modified: trunk/Source/WebCore/css/MediaQueryListListener.idl (92235 => 92236)
--- trunk/Source/WebCore/css/MediaQueryListListener.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/MediaQueryListListener.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -19,12 +19,11 @@
module view {
interface [
- LegacyDefaultOptionalArguments,
NoStaticTables,
ObjCProtocol,
PureInterface,
OmitConstructor
] MediaQueryListListener {
- void queryChanged(in MediaQueryList list);
+ void queryChanged(in [Optional=CallWithDefaultValue] MediaQueryList list);
};
}
Modified: trunk/Source/WebCore/css/StyleMedia.idl (92235 => 92236)
--- trunk/Source/WebCore/css/StyleMedia.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/StyleMedia.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -26,10 +26,9 @@
module view {
interface [
- LegacyDefaultOptionalArguments,
GenerateIsReachable=ImplFrame
] StyleMedia {
readonly attribute DOMString type;
- boolean matchMedium(in DOMString mediaquery);
+ boolean matchMedium(in [Optional=CallWithDefaultValue] DOMString mediaquery);
};
}
Modified: trunk/Source/WebCore/css/StyleSheetList.idl (92235 => 92236)
--- trunk/Source/WebCore/css/StyleSheetList.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/StyleSheetList.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -22,14 +22,13 @@
// Introduced in DOM Level 2:
interface [
- LegacyDefaultOptionalArguments,
GenerateIsReachable=ImplDocument,
HasIndexGetter,
HasNameGetter,
V8DependentLifetime
] StyleSheetList {
readonly attribute unsigned long length;
- StyleSheet item(in unsigned long index);
+ StyleSheet item(in [Optional=CallWithDefaultValue] unsigned long index);
};
}
Modified: trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl (92235 => 92236)
--- trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -30,16 +30,15 @@
// Introduced in DOM Level ?:
interface [
- LegacyDefaultOptionalArguments,
HasIndexGetter
] WebKitCSSKeyframesRule : CSSRule {
attribute [ConvertNullStringTo=Null, ConvertNullToNullString] DOMString name;
readonly attribute CSSRuleList cssRules;
- void insertRule(in DOMString rule);
- void deleteRule(in DOMString key);
- WebKitCSSKeyframeRule findRule(in DOMString key);
+ void insertRule(in [Optional=CallWithDefaultValue] DOMString rule);
+ void deleteRule(in [Optional=CallWithDefaultValue] DOMString key);
+ WebKitCSSKeyframeRule findRule(in [Optional=CallWithDefaultValue] DOMString key);
};
}
Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (92235 => 92236)
--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -27,7 +27,6 @@
// Introduced in DOM Level ?:
interface [
- LegacyDefaultOptionalArguments,
CanBeConstructed,
CustomConstructFunction,
ConstructorParameters=1,
@@ -59,40 +58,49 @@
attribute double m43;
attribute double m44;
- void setMatrixValue(in DOMString string) raises (DOMException);
+ void setMatrixValue(in [Optional=CallWithDefaultValue] DOMString string) raises (DOMException);
// Multiply this matrix by secondMatrix, on the right (result = this * secondMatrix)
- [Immutable] WebKitCSSMatrix multiply(in WebKitCSSMatrix secondMatrix);
+ [Immutable] WebKitCSSMatrix multiply(in [Optional=CallWithDefaultValue] WebKitCSSMatrix secondMatrix);
// Return the inverse of this matrix. Throw an exception if the matrix is not invertible
[Immutable] WebKitCSSMatrix inverse() raises (DOMException);
// Return this matrix translated by the passed values.
// Passing a NaN will use a value of 0. This allows the 3D form to used for 2D operations
- [Immutable] WebKitCSSMatrix translate(in double x, in double y, in double z);
+ [Immutable] WebKitCSSMatrix translate(in [Optional=CallWithDefaultValue] double x,
+ in [Optional=CallWithDefaultValue] double y,
+ in [Optional=CallWithDefaultValue] double z);
// Returns this matrix scaled by the passed values.
// Passing scaleX or scaleZ as NaN uses a value of 1, but passing scaleY of NaN
// makes it the same as scaleX. This allows the 3D form to used for 2D operations
- [Immutable] WebKitCSSMatrix scale(in double scaleX, in double scaleY, in double scaleZ);
+ [Immutable] WebKitCSSMatrix scale(in [Optional=CallWithDefaultValue] double scaleX,
+ in [Optional=CallWithDefaultValue] double scaleY,
+ in [Optional=CallWithDefaultValue] double scaleZ);
// Returns this matrix rotated by the passed values.
// If rotY and rotZ are NaN, rotate about Z (rotX=0, rotateY=0, rotateZ=rotX).
// Otherwise use a rotation value of 0 for any passed NaN.
- [Immutable] WebKitCSSMatrix rotate(in double rotX, in double rotY, in double rotZ);
+ [Immutable] WebKitCSSMatrix rotate(in [Optional=CallWithDefaultValue] double rotX,
+ in [Optional=CallWithDefaultValue] double rotY,
+ in [Optional=CallWithDefaultValue] double rotZ);
// Returns this matrix rotated about the passed axis by the passed angle.
// Passing a NaN will use a value of 0. If the axis is (0,0,0) use a value
// of (0,0,1).
- [Immutable] WebKitCSSMatrix rotateAxisAngle(in double x, in double y, in double z, in double angle);
+ [Immutable] WebKitCSSMatrix rotateAxisAngle(in [Optional=CallWithDefaultValue] double x,
+ in [Optional=CallWithDefaultValue] double y,
+ in [Optional=CallWithDefaultValue] double z,
+ in [Optional=CallWithDefaultValue] double angle);
// Returns this matrix skewed along the X axis by the passed values.
// Passing a NaN will use a value of 0.
- [Immutable] WebKitCSSMatrix skewX(in double angle);
+ [Immutable] WebKitCSSMatrix skewX(in [Optional=CallWithDefaultValue] double angle);
// Returns this matrix skewed along the Y axis by the passed values.
// Passing a NaN will use a value of 0.
- [Immutable] WebKitCSSMatrix skewY(in double angle);
+ [Immutable] WebKitCSSMatrix skewY(in [Optional=CallWithDefaultValue] double angle);
[DontEnum] DOMString toString();
};
