Diff
Modified: trunk/Source/WebCore/ChangeLog (92283 => 92284)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,5 +1,38 @@
2011-08-03 Pavel Feldman <pfeld...@google.com>
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCore.exp.in:
+ * WebCore.order:
+ * inspector/DOMNodeHighlighter.cpp:
+ (WebCore::DOMNodeHighlighter::drawRectHighlight):
+ * inspector/DOMNodeHighlighter.h:
+ * inspector/Inspector.json:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::drawHighlight):
+ * inspector/InspectorController.h:
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::highlightRect):
+ (WebCore::InspectorDOMAgent::hideHighlight):
+ (WebCore::InspectorDOMAgent::drawHighlight):
+ * inspector/InspectorDOMAgent.h:
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.FrameTreeElement.prototype.onselect):
+ (WebInspector.FrameTreeElement.prototype.set hovered):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel):
+ (WebInspector.TimelinePanel.prototype._mouseOut):
+ (WebInspector.TimelinePanel.prototype._mouseMove):
+ (WebInspector.TimelinePanel.prototype._highlightRect):
+ (WebInspector.TimelinePanel.prototype._hideRectHighlight):
+ * inspector/front-end/inspector.js:
+ (WebInspector.highlightDOMNode):
+
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
Web Inspector: make text in popover selectable + make popover re-appear faster.
https://bugs.webkit.org/show_bug.cgi?id=65603
Modified: trunk/Source/WebCore/WebCore.exp.in (92283 => 92284)
--- trunk/Source/WebCore/WebCore.exp.in 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1616,7 +1616,7 @@
__ZN7WebCore28InspectorFrontendClientLocal31constrainedAttachedWindowHeightEjj
__ZN7WebCore28InspectorFrontendClientLocalC2EPNS_19InspectorControllerEPNS_4PageEN3WTF10PassOwnPtrINS0_8SettingsEEE
__ZN7WebCore28InspectorFrontendClientLocalD2Ev
-__ZNK7WebCore19InspectorController17drawNodeHighlightERNS_15GraphicsContextE
+__ZNK7WebCore19InspectorController13drawHighlightERNS_15GraphicsContextE
__ZNK7WebCore19InspectorController31isRecordingUserInitiatedProfileEv
#endif
Modified: trunk/Source/WebCore/WebCore.order (92283 => 92284)
--- trunk/Source/WebCore/WebCore.order 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/WebCore.order 2011-08-03 16:11:21 UTC (rev 92284)
@@ -27724,8 +27724,8 @@
__ZN7WebCore26InspectorBackendDispatcher17DOM_highlightNodeElPNS_15InspectorObjectE
__ZN7WebCore17InspectorDOMAgent13highlightNodeEPN3WTF6StringEiS3_
__ZN7WebCore17InspectorDOMAgent9highlightEPN3WTF6StringEPNS_4NodeERKS2_
-__ZNK7WebCore19InspectorController17drawNodeHighlightERNS_15GraphicsContextE
-__ZNK7WebCore17InspectorDOMAgent17drawNodeHighlightERNS_15GraphicsContextE
+__ZNK7WebCore19InspectorController17drawHighlightERNS_15GraphicsContextE
+__ZNK7WebCore17InspectorDOMAgent17drawHighlightERNS_15GraphicsContextE
__ZN7WebCore18DOMNodeHighlighter17DrawNodeHighlightERNS_15GraphicsContextEPNS_4NodeENS0_13HighlightModeE
__ZN7WebCore12_GLOBAL__N_124drawOutlinedQuadWithClipERNS_15GraphicsContextERKNS_9FloatQuadES5_RKNS_5ColorE
__ZN7WebCore12_GLOBAL__N_116drawOutlinedQuadERNS_15GraphicsContextERKNS_9FloatQuadERKNS_5ColorE
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (92283 => 92284)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -137,9 +137,9 @@
static const int rectInflatePx = 4;
static const int fontHeightPx = 12;
static const int borderWidthPx = 1;
- static const Color tooltipBackgroundColor(255, 255, 194, 255);
- static const Color tooltipBorderColor(Color::black);
- static const Color tooltipFontColor(Color::black);
+ DEFINE_STATIC_LOCAL(Color, tooltipBackgroundColor, (255, 255, 194, 255));
+ DEFINE_STATIC_LOCAL(Color, tooltipBorderColor, (Color::black));
+ DEFINE_STATIC_LOCAL(Color, tooltipFontColor, (Color::black));
FontCachePurgePreventer fontCachePurgePreventer;
Element* element = static_cast<Element*>(node);
@@ -300,6 +300,39 @@
drawElementTitle(context, node, boundingBox, titleAnchorBox, overlayRect, settings);
}
+void drawRectHighlight(GraphicsContext& context, Document* document, IntRect* rect)
+{
+ if (!document)
+ return;
+ FrameView* view = document->frame()->view();
+
+ FloatRect overlayRect = view->visibleContentRect();
+ context.translate(-overlayRect.x(), -overlayRect.y());
+
+ static const int outlineThickness = 2;
+ DEFINE_STATIC_LOCAL(Color, outlineColor, (255, 0, 0, 228));
+ DEFINE_STATIC_LOCAL(Color, fillColor, (255, 0, 0, 20));
+
+ Path quadPath = quadToPath(FloatRect(*rect));
+
+ // Clip out the quad, then draw with a 2px stroke to get a pixel
+ // of outline (because inflating a quad is hard)
+ {
+ context.save();
+ context.clipOut(quadPath);
+
+ context.setStrokeThickness(outlineThickness);
+ context.setStrokeColor(outlineColor, ColorSpaceDeviceRGB);
+ context.strokePath(quadPath);
+
+ context.restore();
+ }
+
+ // Now do the fill
+ context.setFillColor(fillColor, ColorSpaceDeviceRGB);
+ context.fillPath(quadPath);
+}
+
} // namespace DOMNodeHighlighter
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.h (92283 => 92284)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.h 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.h 2011-08-03 16:11:21 UTC (rev 92284)
@@ -31,7 +31,9 @@
namespace WebCore {
+class Document;
class GraphicsContext;
+class IntRect;
class Node;
namespace DOMNodeHighlighter {
@@ -46,6 +48,8 @@
void drawNodeHighlight(GraphicsContext&, Node*, HighlightMode);
+void drawRectHighlight(GraphicsContext&, Document*, IntRect*);
+
} // namespace DOMNodeHighlighter
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/Inspector.json (92283 => 92284)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1008,6 +1008,16 @@
"description": "Enters the 'inspect' mode. In this mode, elements that user is hovering over are highlighted. Backend then generates 'inspect' command upon element selection."
},
{
+ "name": "highlightRect",
+ "parameters": [
+ { "name": "x", "type": "integer", "description": "X coordinate" },
+ { "name": "y", "type": "integer", "description": "Y coordinate" },
+ { "name": "width", "type": "integer", "description": "Rectangle width" },
+ { "name": "height", "type": "integer", "description": "Rectangle height" }
+ ],
+ "description": "Highlights given rectangle. Coordinates are absolute with respect to the main frame viewport."
+ },
+ {
"name": "highlightNode",
"parameters": [
{ "name": "nodeId", "type": "integer", "description": "Identifier of the node to highlight" },
@@ -1016,7 +1026,7 @@
"description": "Highlights DOM node with given id."
},
{
- "name": "hideNodeHighlight",
+ "name": "hideHighlight",
"description": "Hides DOM node highlight."
},
{
@@ -1027,10 +1037,6 @@
"description": "Highlights owner element of the frame with given id."
},
{
- "name": "hideFrameHighlight",
- "description": "Hides frame owner highlight."
- },
- {
"name": "pushNodeByPathToFrontend",
"parameters": [
{ "name": "path", "type": "string", "description": "Path to node in the proprietary format." }
Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (92283 => 92284)
--- trunk/Source/WebCore/inspector/InspectorController.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -374,9 +374,9 @@
m_inspectorAgent->evaluateForTestInFrontend(callId, script);
}
-void InspectorController::drawNodeHighlight(GraphicsContext& context) const
+void InspectorController::drawHighlight(GraphicsContext& context) const
{
- m_domAgent->drawNodeHighlight(context);
+ m_domAgent->drawHighlight(context);
}
void InspectorController::showConsole()
Modified: trunk/Source/WebCore/inspector/InspectorController.h (92283 => 92284)
--- trunk/Source/WebCore/inspector/InspectorController.h 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/InspectorController.h 2011-08-03 16:11:21 UTC (rev 92284)
@@ -97,7 +97,7 @@
void showConsole();
void inspect(Node*);
- void drawNodeHighlight(GraphicsContext&) const;
+ void drawHighlight(GraphicsContext&) const;
void hideHighlight();
Node* highlightedNode() const;
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (92283 => 92284)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -67,6 +67,7 @@
#include "InspectorPageAgent.h"
#include "InspectorState.h"
#include "InstrumentingAgents.h"
+#include "IntRect.h"
#include "MutationEvent.h"
#include "Node.h"
#include "NodeList.h"
@@ -1012,6 +1013,12 @@
m_client->highlight();
}
+void InspectorDOMAgent::highlightRect(ErrorString*, int x, int y, int width, int height)
+{
+ m_highlightedRect = adoptPtr(new IntRect(x, y, width, height));
+ m_client->highlight();
+}
+
void InspectorDOMAgent::highlightNode(ErrorString* error, int nodeId, String* mode)
{
if (Node* node = nodeForId(nodeId))
@@ -1028,6 +1035,7 @@
void InspectorDOMAgent::hideHighlight(ErrorString*)
{
m_highlightedNode = 0;
+ m_highlightedRect.clear();
m_client->hideHighlight();
}
@@ -1509,8 +1517,13 @@
return injectedScript.wrapNode(node, objectGroup);
}
-void InspectorDOMAgent::drawNodeHighlight(GraphicsContext& context) const
+void InspectorDOMAgent::drawHighlight(GraphicsContext& context) const
{
+ if (m_highlightedRect) {
+ DOMNodeHighlighter::drawRectHighlight(context, m_document.get(), m_highlightedRect.get());
+ return;
+ }
+
if (!m_highlightedNode)
return;
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.h (92283 => 92284)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.h 2011-08-03 16:11:21 UTC (rev 92284)
@@ -58,6 +58,7 @@
class InspectorDOMAgent;
class InspectorFrontend;
class InspectorPageAgent;
+class IntRect;
class HitTestResult;
class MatchJob;
class HTMLElement;
@@ -132,10 +133,9 @@
void pushNodeToFrontend(ErrorString*, const String& objectId, int* nodeId);
void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId);
void hideHighlight(ErrorString*);
+ void highlightRect(ErrorString*, int x, int y, int width, int height);
void highlightNode(ErrorString*, int nodeId, String* mode);
- void hideNodeHighlight(ErrorString* error) { hideHighlight(error); }
void highlightFrame(ErrorString*, const String& frameId);
- void hideFrameHighlight(ErrorString* error) { hideHighlight(error); }
void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* const anchorNodeId, int* newNodeId);
Node* highlightedNode() const { return m_highlightedNode.get(); }
@@ -168,7 +168,7 @@
void inspect(Node*);
void focusNode();
- void drawNodeHighlight(GraphicsContext&) const;
+ void drawHighlight(GraphicsContext&) const;
// We represent embedded doms as a part of the same hierarchy. Hence we treat children of frame owners differently.
// We also skip whitespace text nodes conditionally. Following methods encapsulate these specifics.
@@ -232,6 +232,7 @@
HashSet<RefPtr<Node> > m_searchResults;
OwnPtr<RevalidateStyleAttributeTask> m_revalidateStyleAttrTask;
RefPtr<Node> m_highlightedNode;
+ OwnPtr<IntRect> m_highlightedRect;
String m_highlightMode;
RefPtr<Node> m_nodeToFocus;
bool m_searchingForNode;
Modified: trunk/Source/WebCore/inspector/front-end/Popover.js (92283 => 92284)
--- trunk/Source/WebCore/inspector/front-end/Popover.js 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/front-end/Popover.js 2011-08-03 16:11:21 UTC (rev 92284)
@@ -186,7 +186,7 @@
if (this._hoverElement === event.target || (this._hoverElement && this._hoverElement.isAncestor(event.target)))
return;
- // User has 250ms (this._timeout / 4) to reach the popup.
+ // User has 500ms (this._timeout / 2) to reach the popup.
if (this._popup && !this._hidePopupTimer) {
var self = this;
function doHide()
@@ -194,7 +194,7 @@
self._hidePopup();
delete self._hidePopupTimer;
}
- this._hidePopupTimer = setTimeout(doHide, this._timeout / 4);
+ this._hidePopupTimer = setTimeout(doHide, this._timeout / 2);
}
this._handleMouseAction(event);
@@ -208,7 +208,7 @@
if (!this._hoverElement)
return;
- const toolTipDelay = isMouseDown ? 0 : (this._popup ? this._timeout * 0.3 : this._timeout);
+ const toolTipDelay = isMouseDown ? 0 : (this._popup ? this._timeout * 0.6 : this._timeout);
this._hoverTimer = setTimeout(this._mouseHover.bind(this, this._hoverElement), toolTipDelay);
},
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (92283 => 92284)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1073,7 +1073,7 @@
this._storagePanel.showCategoryView(this._displayName);
this.listItemElement.removeStyleClass("hovered");
- DOMAgent.hideFrameHighlight();
+ DOMAgent.hideHighlight();
},
get displayName()
@@ -1108,7 +1108,7 @@
DOMAgent.highlightFrame(this._frameId);
} else {
this.listItemElement.removeStyleClass("hovered");
- DOMAgent.hideFrameHighlight();
+ DOMAgent.hideHighlight();
}
},
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (92283 => 92284)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2011-08-03 16:11:21 UTC (rev 92284)
@@ -94,6 +94,8 @@
this._scrollTop = 0;
this._popoverHelper = new WebInspector.PopoverHelper(this._containerElement, this._getPopoverAnchor.bind(this), this._showPopover.bind(this), true);
+ this._containerElement.addEventListener("mousemove", this._mouseMove.bind(this), false);
+ this._containerElement.addEventListener("mouseout", this._mouseOut.bind(this), false);
// Disable short events filter by default.
this.toggleFilterButton.toggled = true;
@@ -712,6 +714,37 @@
return element.enclosingNodeOrSelfWithClass("timeline-graph-bar") || element.enclosingNodeOrSelfWithClass("timeline-tree-item");
},
+ _mouseOut: function(e)
+ {
+ this._hideRectHighlight();
+ },
+
+ _mouseMove: function(e)
+ {
+ var anchor = this._getPopoverAnchor(e.target);
+
+ if (anchor && anchor.row._record.type === "Paint")
+ this._highlightRect(anchor.row._record);
+ else
+ this._hideRectHighlight();
+ },
+
+ _highlightRect: function(record)
+ {
+ if (this._highlightedRect === record.data)
+ return;
+ this._highlightedRect = record.data;
+ DOMAgent.highlightRect(this._highlightedRect.x, this._highlightedRect.y, this._highlightedRect.width, this._highlightedRect.height);
+ },
+
+ _hideRectHighlight: function()
+ {
+ if (this._highlightedRect) {
+ delete this._highlightedRect;
+ DOMAgent.hideHighlight();
+ }
+ },
+
_showPopover: function(anchor)
{
var record = anchor.row._record;
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (92283 => 92284)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-08-03 16:11:21 UTC (rev 92284)
@@ -391,7 +391,7 @@
if (nodeId)
DOMAgent.highlightNode(nodeId, mode || "all");
else
- DOMAgent.hideNodeHighlight();
+ DOMAgent.hideHighlight();
},
highlightDOMNodeForTwoSeconds: function(nodeId)
Modified: trunk/Source/WebKit/chromium/ChangeLog (92283 => 92284)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,3 +1,13 @@
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * src/WebDevToolsAgentImpl.cpp:
+ (WebKit::WebDevToolsAgentImpl::paintPageOverlay):
+
2011-08-03 Jeremy Moskovich <jer...@chromium.org>
[Chromium] Fix OOP font loading to work on 10.6.6 and above.
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (92283 => 92284)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -279,7 +279,7 @@
{
InspectorController* ic = inspectorController();
if (ic)
- ic->drawNodeHighlight(gc);
+ ic->drawHighlight(gc);
}
void WebDevToolsAgentImpl::highlight()
Modified: trunk/Source/WebKit/gtk/ChangeLog (92283 => 92284)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,3 +1,13 @@
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * webkit/webkitwebview.cpp:
+ (paintWebView):
+
2011-08-03 Pavel Feldman <pfeld...@chromium.org>
Web Inspector: remove Node parameter from the InspectorClient::highlight
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (92283 => 92284)
--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -665,7 +665,7 @@
context.save();
context.clip(clipRect);
- frame->page()->inspectorController()->drawNodeHighlight(context);
+ frame->page()->inspectorController()->drawHighlight(context);
context.restore();
}
#ifdef GTK_API_VERSION_2
Modified: trunk/Source/WebKit/mac/ChangeLog (92283 => 92284)
--- trunk/Source/WebKit/mac/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,3 +1,13 @@
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebInspector/WebNodeHighlightView.mm:
+ (-[WebNodeHighlightView drawRect:]):
+
2011-08-03 Pavel Feldman <pfeld...@chromium.org>
Web Inspector: remove Node parameter from the InspectorClient::highlight
Modified: trunk/Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm (92283 => 92284)
--- trunk/Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm 2011-08-03 16:11:21 UTC (rev 92284)
@@ -73,7 +73,7 @@
ASSERT([[NSGraphicsContext currentContext] isFlipped]);
GraphicsContext context((PlatformGraphicsContext*)[[NSGraphicsContext currentContext] graphicsPort]);
- [_webNodeHighlight inspectorController]->drawNodeHighlight(context);
+ [_webNodeHighlight inspectorController]->drawHighlight(context);
[NSGraphicsContext restoreGraphicsState];
}
}
Modified: trunk/Source/WebKit/qt/Api/qwebframe.cpp (92283 => 92284)
--- trunk/Source/WebKit/qt/Api/qwebframe.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/qt/Api/qwebframe.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -397,7 +397,7 @@
#if ENABLE(INSPECTOR)
if (frame->page()->inspectorController()->highlightedNode()) {
context->save();
- frame->page()->inspectorController()->drawNodeHighlight(*context);
+ frame->page()->inspectorController()->drawHighlight(*context);
context->restore();
}
#endif
Modified: trunk/Source/WebKit/qt/ChangeLog (92283 => 92284)
--- trunk/Source/WebKit/qt/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,3 +1,13 @@
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * Api/qwebframe.cpp:
+ (QWebFramePrivate::renderRelativeCoords):
+
2011-08-03 Pavel Feldman <pfeld...@chromium.org>
Web Inspector: remove Node parameter from the InspectorClient::highlight
Modified: trunk/Source/WebKit/win/ChangeLog (92283 => 92284)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,3 +1,13 @@
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebNodeHighlight.cpp:
+ (WebNodeHighlight::update):
+
2011-08-03 Pavel Feldman <pfeld...@chromium.org>
Web Inspector: remove Node parameter from the InspectorClient::highlight
Modified: trunk/Source/WebKit/win/WebNodeHighlight.cpp (92283 => 92284)
--- trunk/Source/WebKit/win/WebNodeHighlight.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit/win/WebNodeHighlight.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -158,7 +158,7 @@
GraphicsContext context(hdc);
- m_inspectedWebView->page()->inspectorController()->drawNodeHighlight(context);
+ m_inspectedWebView->page()->inspectorController()->drawHighlight(context);
BLENDFUNCTION bf;
bf.BlendOp = AC_SRC_OVER;
Modified: trunk/Source/WebKit2/ChangeLog (92283 => 92284)
--- trunk/Source/WebKit2/ChangeLog 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,3 +1,13 @@
+2011-08-03 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+ https://bugs.webkit.org/show_bug.cgi?id=65510
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+ (WebKit::WebInspectorClient::drawRect):
+
2011-08-02 Caio Marcelo de Oliveira Filho <caio.olive...@openbossa.org>
[Qt] [WK2] Expose web view classes to QML
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (92283 => 92284)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 16:11:21 UTC (rev 92284)
@@ -101,7 +101,7 @@
void WebInspectorClient::drawRect(PageOverlay* overlay, WebCore::GraphicsContext& context, const WebCore::IntRect& dirtyRect)
{
- m_page->corePage()->inspectorController()->drawNodeHighlight(context);
+ m_page->corePage()->inspectorController()->drawHighlight(context);
}
bool WebInspectorClient::mouseEvent(PageOverlay*, const WebMouseEvent&)
