Title: [92327] trunk
Revision
92327
Author
commit-qu...@webkit.org
Date
2011-08-03 16:20:58 -0700 (Wed, 03 Aug 2011)

Log Message

Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
https://bugs.webkit.org/show_bug.cgi?id=65338

Patch by Mark Pilgrim <pilg...@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

* html/DOMFormData.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAudioElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDivElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLFieldSetElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLKeygenElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLOutputElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLVideoElement.idl:
* html/TimeRanges.idl:

LayoutTests:

* fast/files/create-blob-url-crash-expected.txt:
* fast/files/create-blob-url-crash.html:
* fast/files/revoke-blob-url-expected.txt:
* fast/files/revoke-blob-url.html:
* fast/forms/ValidityState-customError-expected.txt:
* fast/forms/ValidityState-customError.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (92326 => 92327)


--- trunk/LayoutTests/ChangeLog	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 23:20:58 UTC (rev 92327)
@@ -1,5 +1,19 @@
 2011-08-03  Mark Pilgrim  <pilg...@chromium.org>
 
+        Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
+        https://bugs.webkit.org/show_bug.cgi?id=65338
+
+        Reviewed by Adam Barth.
+
+        * fast/files/create-blob-url-crash-expected.txt:
+        * fast/files/create-blob-url-crash.html:
+        * fast/files/revoke-blob-url-expected.txt:
+        * fast/files/revoke-blob-url.html:
+        * fast/forms/ValidityState-customError-expected.txt:
+        * fast/forms/ValidityState-customError.html:
+
+2011-08-03  Mark Pilgrim  <pilg...@chromium.org>
+
         Remove LegacyDefaultOptionalArguments flag from navigator IDL files
         https://bugs.webkit.org/show_bug.cgi?id=65370
 

Modified: trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt (92326 => 92327)


--- trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt	2011-08-03 23:20:58 UTC (rev 92327)
@@ -1,4 +1,4 @@
-Test that createObjectURL with no argument should not cause crash.
-PASS
+Test that createObjectURL with no argument should throw an exception.
+PASS: Not enough arguments
 DONE
 

Modified: trunk/LayoutTests/fast/files/create-blob-url-crash.html (92326 => 92327)


--- trunk/LayoutTests/fast/files/create-blob-url-crash.html	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/files/create-blob-url-crash.html	2011-08-03 23:20:58 UTC (rev 92327)
@@ -9,9 +9,13 @@
 
 function test()
 {
-    log("Test that createObjectURL with no argument should not cause crash.");
-    var url = ""
-    log(url == undefined ? "PASS" : "FAIL");
+    log("Test that createObjectURL with no argument should throw an exception.");
+    try {
+        var url = ""
+        log("FAIL");
+    } catch(err) {
+        log("PASS: " + err.message);
+    }
 
     log("DONE");
 }

Modified: trunk/LayoutTests/fast/files/revoke-blob-url-expected.txt (92326 => 92327)


--- trunk/LayoutTests/fast/files/revoke-blob-url-expected.txt	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/files/revoke-blob-url-expected.txt	2011-08-03 23:20:58 UTC (rev 92327)
@@ -1,5 +1,5 @@
 Test calling revokeObjectURL with no argument.
-PASS
+PASS: Not enough arguments
 Test calling revokeObjectURL with empty URL.
 PASS
 Test calling revokeObjectURL with invalid URL.

Modified: trunk/LayoutTests/fast/files/revoke-blob-url.html (92326 => 92327)


--- trunk/LayoutTests/fast/files/revoke-blob-url.html	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/files/revoke-blob-url.html	2011-08-03 23:20:58 UTC (rev 92327)
@@ -10,8 +10,12 @@
 function test()
 {
     log("Test calling revokeObjectURL with no argument.");
-    var url = ""
-    log(url == undefined ? "PASS" : "FAIL");
+    try {
+        var url = ""
+        log("FAIL");
+    } catch(err) {
+        log("PASS: " + err.message);
+    }
 
     log("Test calling revokeObjectURL with empty URL.");
     webkitURL.revokeObjectURL("");

Modified: trunk/LayoutTests/fast/forms/ValidityState-customError-expected.txt (92326 => 92327)


--- trunk/LayoutTests/fast/forms/ValidityState-customError-expected.txt	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/forms/ValidityState-customError-expected.txt	2011-08-03 23:20:58 UTC (rev 92327)
@@ -35,6 +35,14 @@
 
 Many changes for customError:
 Set some value, and set with no arguments.
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
+PASS setCustomValidity() threw Not enough arguments
 PASS customErrorFor("fieldset-many-changes") is false
 PASS customErrorFor("button-many-changes") is false
 PASS customErrorFor("button-button-many-changes") is false

Modified: trunk/LayoutTests/fast/forms/ValidityState-customError.html (92326 => 92327)


--- trunk/LayoutTests/fast/forms/ValidityState-customError.html	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/forms/ValidityState-customError.html	2011-08-03 23:20:58 UTC (rev 92327)
@@ -97,7 +97,13 @@
 v = document.getElementsByName("many-changes");
 for (i = 0; i < v.length; i++) {
     v[i].setCustomValidity("Custom string");
-    v[i].setCustomValidity();
+    try {
+        v[i].setCustomValidity();
+        testFailed("setCustomValidity() did not throw");
+    } catch(err) {
+        testPassed("setCustomValidity() threw " + err.message);
+    }
+    v[i].setCustomValidity(undefined);
 }
 shouldBeFalse('customErrorFor("fieldset-many-changes")');
 shouldBeFalse('customErrorFor("button-many-changes")');

Modified: trunk/Source/WebCore/ChangeLog (92326 => 92327)


--- trunk/Source/WebCore/ChangeLog	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 23:20:58 UTC (rev 92327)
@@ -1,3 +1,37 @@
+2011-08-03  Mark Pilgrim  <pilg...@chromium.org>
+
+        Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
+        https://bugs.webkit.org/show_bug.cgi?id=65338
+
+        Reviewed by Adam Barth.
+
+        * html/DOMFormData.idl:
+        * html/DOMTokenList.idl:
+        * html/DOMURL.idl:
+        * html/HTMLAllCollection.idl:
+        * html/HTMLAnchorElement.idl:
+        * html/HTMLAudioElement.idl:
+        * html/HTMLButtonElement.idl:
+        * html/HTMLCanvasElement.idl:
+        * html/HTMLCollection.idl:
+        * html/HTMLDivElement.idl:
+        * html/HTMLDocument.idl:
+        * html/HTMLElement.idl:
+        * html/HTMLFieldSetElement.idl:
+        * html/HTMLInputElement.idl:
+        * html/HTMLKeygenElement.idl:
+        * html/HTMLMediaElement.idl:
+        * html/HTMLObjectElement.idl:
+        * html/HTMLOptionsCollection.idl:
+        * html/HTMLOutputElement.idl:
+        * html/HTMLSelectElement.idl:
+        * html/HTMLTableElement.idl:
+        * html/HTMLTableRowElement.idl:
+        * html/HTMLTableSectionElement.idl:
+        * html/HTMLTextAreaElement.idl:
+        * html/HTMLVideoElement.idl:
+        * html/TimeRanges.idl:
+
 2011-08-03  Jeffrey Pfau  <jp...@apple.com>
 
         Make atomic XML token

Modified: trunk/Source/WebCore/html/DOMFormData.idl (92326 => 92327)


--- trunk/Source/WebCore/html/DOMFormData.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/DOMFormData.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -31,7 +31,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         CanBeConstructed,
         CustomConstructFunction,
         V8CustomConstructor,
@@ -39,7 +38,8 @@
         GenerateToJS
     ] DOMFormData {
         // void append(DOMString name, Blob value);
-        [Custom] void append(in DOMString name, in DOMString value);
+        [Custom] void append(in [Optional=CallWithDefaultValue] DOMString name, 
+                             in [Optional=CallWithDefaultValue] DOMString value);
     };
 
 }

Modified: trunk/Source/WebCore/html/DOMTokenList.idl (92326 => 92327)


--- trunk/Source/WebCore/html/DOMTokenList.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/DOMTokenList.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -25,7 +25,6 @@
 module core {
 
     interface [
-        LegacyDefaultOptionalArguments,
         GenerateIsReachable=ImplElementRoot,
         GenerateConstructor,
         HasIndexGetter

Modified: trunk/Source/WebCore/html/DOMURL.idl (92326 => 92327)


--- trunk/Source/WebCore/html/DOMURL.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/DOMURL.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -25,7 +25,6 @@
 
 module html {
     interface [
-        LegacyDefaultOptionalArguments,
         Conditional=BLOB,
         OmitConstructor,
         GenerateNativeConverter,

Modified: trunk/Source/WebCore/html/HTMLAllCollection.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLAllCollection.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLAllCollection.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -26,14 +26,13 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         HasIndexGetter,
         HasNameGetter,
         CustomCall,
         MasqueradesAsUndefined
     ] HTMLAllCollection {
         readonly attribute unsigned long length;
-        [Custom] Node item(in unsigned long index);
+        [Custom] Node item(in [Optional=CallWithDefaultValue] unsigned long index);
         [Custom] Node namedItem(in DOMString name);
 
         // FIXME: This should return an HTMLAllCollection.

Modified: trunk/Source/WebCore/html/HTMLAnchorElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLAnchorElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -20,9 +20,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLAnchorElement : HTMLElement {
+    interface HTMLAnchorElement : HTMLElement {
         attribute [Reflect] DOMString accessKey;
         attribute [Reflect] DOMString charset;
         attribute [Reflect] DOMString coords;

Modified: trunk/Source/WebCore/html/HTMLAudioElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLAudioElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLAudioElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -25,7 +25,6 @@
 
 module html {
     interface [
-        LegacyDefaultOptionalArguments,
         Conditional=VIDEO
     ] HTMLAudioElement : HTMLMediaElement {
     

Modified: trunk/Source/WebCore/html/HTMLButtonElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLButtonElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLButtonElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -20,9 +20,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLButtonElement : HTMLElement {
+    interface HTMLButtonElement : HTMLElement {
         readonly attribute HTMLFormElement form;
 
         attribute [Reflect, URL] DOMString formAction;

Modified: trunk/Source/WebCore/html/HTMLCanvasElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLCanvasElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -27,20 +27,19 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         GenerateNativeConverter
     ] HTMLCanvasElement : HTMLElement {
 
         attribute long width;
         attribute long height;
 
-        [Custom] DOMString toDataURL(in [ConvertUndefinedOrNullToNullString] DOMString type)
+        [Custom] DOMString toDataURL(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString type)
             raises(DOMException);
 
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
 #if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
         // The custom binding is needed to handle context creation attributes.
-        [Custom] DOMObject getContext(in DOMString contextId);
+        [Custom] DOMObject getContext(in [Optional=CallWithDefaultValue] DOMString contextId);
 #endif
 #endif
 

Modified: trunk/Source/WebCore/html/HTMLCollection.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLCollection.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLCollection.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -21,7 +21,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         HasIndexGetter,
         HasNameGetter,
         CustomCall,
@@ -30,11 +29,11 @@
         Polymorphic
     ] HTMLCollection {
         readonly attribute unsigned long length;
-        [Custom] Node item(in unsigned long index);
-        [Custom] Node namedItem(in DOMString name);
+        [Custom] Node item(in [Optional=CallWithDefaultValue] unsigned long index);
+        [Custom] Node namedItem(in [Optional=CallWithDefaultValue] DOMString name);
 
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
-        NodeList tags(in DOMString name);
+        NodeList tags(in [Optional=CallWithDefaultValue] DOMString name);
 #endif
     };
 

Modified: trunk/Source/WebCore/html/HTMLDivElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLDivElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLDivElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -19,9 +19,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLDivElement : HTMLElement {
+    interface HTMLDivElement : HTMLElement {
         attribute [Reflect] DOMString align;
     };
 

Modified: trunk/Source/WebCore/html/HTMLDocument.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLDocument.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLDocument.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -21,13 +21,12 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         HasOverridingNameGetter
     ] HTMLDocument : Document {
         [Custom, NoCPPCustom] void open();
         void close();
-        [Custom] void write(in DOMString text);
-        [Custom] void writeln(in DOMString text);
+        [Custom] void write(in [Optional=CallWithDefaultValue] DOMString text);
+        [Custom] void writeln(in [Optional=CallWithDefaultValue] DOMString text);
 
         readonly attribute HTMLCollection embeds;
         readonly attribute HTMLCollection plugins;

Modified: trunk/Source/WebCore/html/HTMLElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -21,7 +21,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         GenerateNativeConverter,
         CustomPushEventHandlerScope
     ] HTMLElement : Element {
@@ -49,14 +48,14 @@
                  attribute [ConvertNullToNullString] DOMString outerText
                      setter raises(DOMException);
 
-        Element insertAdjacentElement(in DOMString where,
-                                      in Element element)
+        Element insertAdjacentElement(in [Optional=CallWithDefaultValue] DOMString where,
+                                      in [Optional=CallWithDefaultValue] Element element)
             raises(DOMException);
-        void insertAdjacentHTML(in DOMString where,
-                                in DOMString html)
+        void insertAdjacentHTML(in [Optional=CallWithDefaultValue] DOMString where,
+                                in [Optional=CallWithDefaultValue] DOMString html)
             raises(DOMException);
-        void insertAdjacentText(in DOMString where,
-                                in DOMString text)
+        void insertAdjacentText(in [Optional=CallWithDefaultValue] DOMString where,
+                                in [Optional=CallWithDefaultValue] DOMString text)
             raises(DOMException);
 
         readonly attribute HTMLCollection children;

Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLFieldSetElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -19,9 +19,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLFieldSetElement : HTMLElement {
+    interface HTMLFieldSetElement : HTMLElement {
         readonly attribute HTMLFormElement form;
         readonly attribute ValidityState   validity;
         readonly attribute boolean         willValidate;

Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLInputElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -20,9 +20,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLInputElement : HTMLElement {
+    interface HTMLInputElement : HTMLElement {
         attribute [ConvertNullToNullString] DOMString defaultValue;
         attribute [Reflect=checked] boolean defaultChecked;
         readonly attribute HTMLFormElement form;
@@ -93,7 +91,9 @@
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
         [Custom] void setSelectionRange(in long start, in long end);
 #else
-        [Custom] void setSelectionRange(in long start, in long end, in [Optional] DOMString direction);
+        [Custom] void setSelectionRange(in [Optional=CallWithDefaultValue] long start, 
+                                        in [Optional=CallWithDefaultValue] long end, 
+                                        in [Optional] DOMString direction);
 #endif
 
 #if defined(LANGUAGE_OBJECTIVE_C)

Modified: trunk/Source/WebCore/html/HTMLKeygenElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLKeygenElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -30,9 +30,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLKeygenElement : HTMLElement {
+    interface HTMLKeygenElement : HTMLElement {
         attribute [Reflect] boolean autofocus;
         attribute [Reflect] DOMString challenge;
         attribute [Reflect] boolean disabled;

Modified: trunk/Source/WebCore/html/HTMLMediaElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLMediaElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLMediaElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -26,7 +26,6 @@
 module html {
     interface [
         Conditional=VIDEO,
-        LegacyDefaultOptionalArguments,
     ] HTMLMediaElement : HTMLElement {
 
     // error state

Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLObjectElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -21,7 +21,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         DelegatingPutFunction,
         DelegatingGetOwnPropertySlot,
         CustomCall

Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLOptionsCollection.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -22,7 +22,6 @@
 
     // FIXME: The W3C spec says that HTMLOptionsCollection should not have a parent class.
     interface [
-        LegacyDefaultOptionalArguments,
         GenerateNativeConverter,
         HasCustomIndexSetter
     ] HTMLOptionsCollection : HTMLCollection {
@@ -30,9 +29,10 @@
                  attribute [Custom] unsigned long length
                         setter raises (DOMException);
 
-        [Custom] void add(in HTMLOptionElement option, in [Optional] unsigned long index)
+        [Custom] void add(in [Optional=CallWithDefaultValue] HTMLOptionElement option, 
+                          in [Optional] unsigned long index)
              raises (DOMException);
-        [Custom] void remove(in unsigned long index);
+        [Custom] void remove(in [Optional=CallWithDefaultValue] unsigned long index);
 
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
         Node item(in unsigned long index); 

Modified: trunk/Source/WebCore/html/HTMLOutputElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLOutputElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLOutputElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -23,9 +23,7 @@
  */
 
 module html {
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLOutputElement : HTMLElement {
+    interface HTMLOutputElement : HTMLElement {
         attribute [Custom] DOMSettableTokenList htmlFor;
         readonly attribute HTMLFormElement form;
         attribute [Reflect] DOMString name;

Modified: trunk/Source/WebCore/html/HTMLSelectElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLSelectElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLSelectElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -21,7 +21,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         HasIndexGetter,
         HasCustomIndexSetter
     ] HTMLSelectElement : HTMLElement {
@@ -53,7 +52,8 @@
         attribute [Reflect] boolean required;
         attribute long size;
         
-        [OldStyleObjC] void add(in HTMLElement element, in HTMLElement before) raises(DOMException);
+        [OldStyleObjC] void add(in [Optional=CallWithDefaultValue] HTMLElement element, 
+                                in [Optional=CallWithDefaultValue] HTMLElement before) raises(DOMException);
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
         // In _javascript_, we support both option index and option object parameters.
@@ -65,8 +65,8 @@
 
         // These methods are not in DOM Level 2 IDL, but are mentioned in the standard:
         // "The contained options can be directly accessed through the select element as a collection."
-        Node item(in [IsIndex] unsigned long index);
-        Node namedItem(in DOMString name);
+        Node item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);
+        Node namedItem(in [Optional=CallWithDefaultValue] DOMString name);
         readonly attribute NodeList labels;
     };
 

Modified: trunk/Source/WebCore/html/HTMLTableElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLTableElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLTableElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -20,9 +20,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLTableElement : HTMLElement {
+    interface HTMLTableElement : HTMLElement {
         attribute HTMLTableCaptionElement caption setter raises(DOMException);
         attribute HTMLTableSectionElement tHead setter raises(DOMException);
         attribute HTMLTableSectionElement tFoot setter raises(DOMException);
@@ -48,8 +46,8 @@
         HTMLElement createCaption();
         void deleteCaption();
 
-        HTMLElement insertRow(in long index) raises(DOMException);
-        void deleteRow(in long index) raises(DOMException);
+        HTMLElement insertRow(in [Optional=CallWithDefaultValue] long index) raises(DOMException);
+        void deleteRow(in [Optional=CallWithDefaultValue] long index) raises(DOMException);
     };
 
 }

Modified: trunk/Source/WebCore/html/HTMLTableRowElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLTableRowElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLTableRowElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -20,9 +20,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLTableRowElement : HTMLElement {
+    interface HTMLTableRowElement : HTMLElement {
         readonly attribute long rowIndex;
         readonly attribute long sectionRowIndex;
         readonly attribute HTMLCollection cells;
@@ -31,8 +29,8 @@
         attribute [Reflect=char] DOMString ch;
         attribute [Reflect=charoff] DOMString chOff;
         attribute [Reflect] DOMString vAlign;
-        HTMLElement insertCell(in long index) raises(DOMException);
-        void deleteCell(in long index) raises(DOMException);
+        HTMLElement insertCell(in [Optional=CallWithDefaultValue] long index) raises(DOMException);
+        void deleteCell(in [Optional=CallWithDefaultValue] long index) raises(DOMException);
     };
 
 }

Modified: trunk/Source/WebCore/html/HTMLTableSectionElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLTableSectionElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLTableSectionElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -21,7 +21,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         GenerateNativeConverter
     ] HTMLTableSectionElement : HTMLElement {
         attribute [Reflect] DOMString align;
@@ -29,8 +28,8 @@
         attribute [Reflect=charoff] DOMString chOff;
         attribute [Reflect] DOMString vAlign;
         readonly attribute HTMLCollection rows;
-        HTMLElement insertRow(in long index) raises(DOMException);
-        void deleteRow(in long index) raises(DOMException);
+        HTMLElement insertRow(in [Optional=CallWithDefaultValue] long index) raises(DOMException);
+        void deleteRow(in [Optional=CallWithDefaultValue] long index) raises(DOMException);
     };
 
 }

Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLTextAreaElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -20,9 +20,7 @@
 
 module html {
 
-    interface [
-        LegacyDefaultOptionalArguments,
-    ] HTMLTextAreaElement : HTMLElement {
+    interface HTMLTextAreaElement : HTMLElement {
         attribute [ConvertNullToNullString] DOMString defaultValue;
         readonly attribute HTMLFormElement form;
         readonly attribute ValidityState validity;
@@ -54,7 +52,9 @@
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
         void setSelectionRange(in long start, in long end);
 #else
-        void setSelectionRange(in long start, in long end, in [Optional] DOMString direction);
+        void setSelectionRange(in [Optional=CallWithDefaultValue] long start, 
+                               in [Optional=CallWithDefaultValue] long end, 
+                               in [Optional] DOMString direction);
 #endif
         readonly attribute NodeList labels;
     };

Modified: trunk/Source/WebCore/html/HTMLVideoElement.idl (92326 => 92327)


--- trunk/Source/WebCore/html/HTMLVideoElement.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/HTMLVideoElement.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -26,7 +26,6 @@
 module html {
     interface [
         Conditional=VIDEO,
-        LegacyDefaultOptionalArguments,
         GenerateNativeConverter
     ] HTMLVideoElement : HTMLMediaElement {
         attribute [Reflect] unsigned long width;

Modified: trunk/Source/WebCore/html/TimeRanges.idl (92326 => 92327)


--- trunk/Source/WebCore/html/TimeRanges.idl	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/Source/WebCore/html/TimeRanges.idl	2011-08-03 23:20:58 UTC (rev 92327)
@@ -26,7 +26,6 @@
 module html {
 
     interface [
-        LegacyDefaultOptionalArguments,
         Conditional=VIDEO
     ] TimeRanges {
         readonly attribute unsigned long length;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to