Title: [92906] trunk/Source
- Revision
- 92906
- Author
- [email protected]
- Date
- 2011-08-11 20:00:05 -0700 (Thu, 11 Aug 2011)
Log Message
Remove incorrect comment about m_wheelEventHandlerCount
https://bugs.webkit.org/show_bug.cgi?id=66117
Reviewed by Simon Fraser.
>From what I can tell, this number is changed only in
Frame::notifyChromeClientWheelEventHandlerCountChanged(),
and there it just reads the number modified in
Document::didAdd/RemoveWheelEventHandler(). So this is just the number
of event handlers (and not related to horizontal scrollbars), and the
variable name expresses that already.
Source/WebCore:
* dom/Document.h:
Source/WebKit2:
* UIProcess/WebPageProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (92905 => 92906)
--- trunk/Source/WebCore/ChangeLog 2011-08-12 02:54:18 UTC (rev 92905)
+++ trunk/Source/WebCore/ChangeLog 2011-08-12 03:00:05 UTC (rev 92906)
@@ -1,3 +1,19 @@
+2011-08-11 Nico Weber <[email protected]>
+
+ Remove incorrect comment about m_wheelEventHandlerCount
+ https://bugs.webkit.org/show_bug.cgi?id=66117
+
+ Reviewed by Simon Fraser.
+
+ From what I can tell, this number is changed only in
+ Frame::notifyChromeClientWheelEventHandlerCountChanged(),
+ and there it just reads the number modified in
+ Document::didAdd/RemoveWheelEventHandler(). So this is just the number
+ of event handlers (and not related to horizontal scrollbars), and the
+ variable name expresses that already.
+
+ * dom/Document.h:
+
2011-08-11 James Robinson <[email protected]>
[chromium] Defer managed texture creation and destruction until updateCompositorResources
Modified: trunk/Source/WebCore/dom/Document.h (92905 => 92906)
--- trunk/Source/WebCore/dom/Document.h 2011-08-12 02:54:18 UTC (rev 92905)
+++ trunk/Source/WebCore/dom/Document.h 2011-08-12 03:00:05 UTC (rev 92906)
@@ -1092,7 +1092,6 @@
ContentSecurityPolicy* contentSecurityPolicy() { return m_contentSecurityPolicy.get(); }
- // Used to keep track of horizontal scrollbars and onmousewheel event handlers only.
unsigned wheelEventHandlerCount() const { return m_wheelEventHandlerCount; }
void didAddWheelEventHandler();
void didRemoveWheelEventHandler();
Modified: trunk/Source/WebKit2/ChangeLog (92905 => 92906)
--- trunk/Source/WebKit2/ChangeLog 2011-08-12 02:54:18 UTC (rev 92905)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-12 03:00:05 UTC (rev 92906)
@@ -1,3 +1,19 @@
+2011-08-11 Nico Weber <[email protected]>
+
+ Remove incorrect comment about m_wheelEventHandlerCount
+ https://bugs.webkit.org/show_bug.cgi?id=66117
+
+ Reviewed by Simon Fraser.
+
+ From what I can tell, this number is changed only in
+ Frame::notifyChromeClientWheelEventHandlerCountChanged(),
+ and there it just reads the number modified in
+ Document::didAdd/RemoveWheelEventHandler(). So this is just the number
+ of event handlers (and not related to horizontal scrollbars), and the
+ variable name expresses that already.
+
+ * UIProcess/WebPageProxy.h:
+
2011-08-11 Kenneth Rohde Christiansen <[email protected]>
[Qt/WK2] Add initial support for viewport meta tag
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (92905 => 92906)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2011-08-12 02:54:18 UTC (rev 92905)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2011-08-12 03:00:05 UTC (rev 92906)
@@ -917,8 +917,6 @@
bool m_mainFrameHasHorizontalScrollbar;
bool m_mainFrameHasVerticalScrollbar;
- // This aggregated count of wheel handlers only includes horizontal scrollbars
- // and JS wheel event handlers.
int m_wheelEventHandlerCount;
bool m_mainFrameIsPinnedToLeftSide;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
