Title: [93194] trunk/Source/WebCore
Revision
93194
Author
je...@apple.com
Date
2011-08-16 21:49:15 -0700 (Tue, 16 Aug 2011)

Log Message

Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339
        
Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (93193 => 93194)


--- trunk/Source/WebCore/ChangeLog	2011-08-17 01:54:03 UTC (rev 93193)
+++ trunk/Source/WebCore/ChangeLog	2011-08-17 04:49:15 UTC (rev 93194)
@@ -1,3 +1,14 @@
+2011-08-16  Jeff Miller  <je...@apple.com>
+
+        Apple's Windows production build should fail to compile if AVFoundation is not enabled
+        https://bugs.webkit.org/show_bug.cgi?id=66339
+        
+        Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
+        Reviewed by Darin Adler.
+
+        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
 2011-08-16  David Levin  <le...@chromium.org>
 
         REGRESSION (r89086): All worker xhr requests trigger preflight requests.

Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93193 => 93194)


--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-17 01:54:03 UTC (rev 93193)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-17 04:49:15 UTC (rev 93194)
@@ -25,8 +25,10 @@
 
 #include "config.h"
 
-#if PLATFORM(WIN) && ENABLE(VIDEO) && USE(AVFOUNDATION)
+#if PLATFORM(WIN)&& ENABLE(VIDEO) 
 
+#if USE(AVFOUNDATION)
+
 #include "MediaPlayerPrivateAVFoundationCF.h"
 
 #include "ApplicationCacheResource.h"
@@ -1271,4 +1273,10 @@
 
 } // namespace WebCore
 
-#endif // PLATFORM(WIN) && ENABLE(VIDEO) && USE(AVFOUNDATION)
+#else
+// AVFoundation should always be enabled for Apple production builds.
+#if __PRODUCTION__ && !USE(AVFOUNDATION)
+#error AVFoundation is not enabled!
+#endif // __PRODUCTION__ && !USE(AVFOUNDATION)
+#endif // USE(AVFOUNDATION)
+#endif // PLATFORM(WIN) && ENABLE(VIDEO)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to