Title: [93202] trunk/Source/WebCore
- Revision
- 93202
- Author
- commit-qu...@webkit.org
- Date
- 2011-08-17 04:45:43 -0700 (Wed, 17 Aug 2011)
Log Message
Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=66311
Patch by Sailesh Agrawal <s...@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.
Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarMinimumTotalLengthNeededForThumb):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93201 => 93202)
--- trunk/Source/WebCore/ChangeLog 2011-08-17 11:42:59 UTC (rev 93201)
+++ trunk/Source/WebCore/ChangeLog 2011-08-17 11:45:43 UTC (rev 93202)
@@ -1,3 +1,15 @@
+2011-08-17 Sailesh Agrawal <s...@chromium.org>
+
+ Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
+ https://bugs.webkit.org/show_bug.cgi?id=66311
+
+ Reviewed by Dimitri Glazkov.
+
+ Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.
+
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+ (wkScrollbarMinimumTotalLengthNeededForThumb):
+
2011-08-17 Steve Block <stevebl...@google.com>
Unreviewed, rolling out r93186.
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm (93201 => 93202)
--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-08-17 11:42:59 UTC (rev 93201)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-08-17 11:45:43 UTC (rev 93202)
@@ -67,6 +67,10 @@
@property(assign) id delegate;
- (CGFloat)knobMinLength;
+- (CGFloat)trackOverlapEndInset;
+- (CGFloat)knobOverlapEndInset;
+- (CGFloat)trackEndInset;
+- (CGFloat)knobEndInset;
- (CGFloat)trackBoxWidth;
- (CGFloat)trackWidth;
- (void)setBoundsSize:(NSSize)size;
@@ -205,8 +209,10 @@
int wkScrollbarMinimumTotalLengthNeededForThumb(WKScrollbarPainterRef painter)
{
- // TODO(sail): This doesn't match the implementation in WebKitSystemInterface.
- return wkScrollbarMinimumThumbLength(painter);
+ return [painter knobMinLength] +
+ [painter trackOverlapEndInset] +
+ [painter knobOverlapEndInset] +
+ ([painter trackEndInset] + [painter knobEndInset]) * 2;
}
WKScrollbarPainterRef wkVerticalScrollbarPainterForController(WKScrollbarPainterControllerRef controller)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
