Diff
Modified: trunk/Source/WebCore/ChangeLog (93509 => 93510)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 15:36:28 UTC (rev 93510)
@@ -1,3 +1,35 @@
+2011-08-22 Ilya Tikhonovsky <loi...@chromium.org>
+
+ Web Inspector: bind registerDomainDispatcher to domain names.
+ https://bugs.webkit.org/show_bug.cgi?id=66670
+
+ jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
+ I'd like to introduce named versions per each domain.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/CodeGeneratorInspector.pm:
+ (GenerateInterface):
+ (generateBackendStubJS):
+ * inspector/front-end/ApplicationCacheItemsView.js:
+ * inspector/front-end/ConsoleView.js:
+ * inspector/front-end/DOMAgent.js:
+ (WebInspector.DOMAgent):
+ * inspector/front-end/DOMStorage.js:
+ * inspector/front-end/Database.js:
+ * inspector/front-end/DebuggerModel.js:
+ (WebInspector.DebuggerModel):
+ * inspector/front-end/NetworkManager.js:
+ (WebInspector.NetworkDispatcher):
+ * inspector/front-end/ProfilesPanel.js:
+ * inspector/front-end/ResourceTreeModel.js:
+ (WebInspector.ResourceTreeModel):
+ * inspector/front-end/TimelineManager.js:
+ (WebInspector.TimelineDispatcher):
+ * inspector/front-end/WorkerManager.js:
+ (WebInspector.WorkerManager):
+ * inspector/front-end/inspector.js:
+
2011-08-22 Benjamin Poulain <benja...@webkit.org>
Fix generate-inspector-idl for Python3 after r93396
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm (93509 => 93510)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm 2011-08-22 15:36:28 UTC (rev 93510)
@@ -245,6 +245,7 @@
my @frontendConstantDeclarations;
my @frontendConstantDefinitions;
my @frontendFooter;
+my @frontendDomains;
# Default constructor
sub new
@@ -304,6 +305,7 @@
);
generateFunctions($interface, \%agent);
if (@{$agent{methodDeclarations}}) {
+ push(@frontendDomains, $interface->name);
generateAgentDeclaration($interface, \%agent);
}
}
@@ -755,6 +757,7 @@
sub generateBackendStubJS
{
+ my $JSRegisterDomainDispatchers = join("\n", map(" this.register" . $_ . "Dispatcher = this._registerDomainDispatcher.bind(this, \"" . $_ ."\");", @frontendDomains));
my $JSStubs = join("\n", @backendJSStubs);
my $JSEvents = join("\n", @backendJSEvents);
my $inspectorBackendStubJS = << "EOF";
@@ -769,6 +772,7 @@
this._eventArgs = {};
$JSStubs
$JSEvents
+$JSRegisterDomainDispatchers
}
InspectorBackendStub.prototype = {
@@ -854,7 +858,7 @@
InspectorFrontendHost.sendMessageToBackend(message);
},
- registerDomainDispatcher: function(domain, dispatcher)
+ _registerDomainDispatcher: function(domain, dispatcher)
{
this._domainDispatchers[domain] = dispatcher;
},
Modified: trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -308,4 +308,4 @@
}
}
-InspectorBackend.registerDomainDispatcher("ApplicationCache", new WebInspector.ApplicationCacheDispatcher());
+InspectorBackend.registerApplicationCacheDispatcher(new WebInspector.ApplicationCacheDispatcher());
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -157,7 +157,7 @@
console.clearMessages();
},
}
- InspectorBackend.registerDomainDispatcher("Console", dispatcher);
+ InspectorBackend.registerConsoleDispatcher(dispatcher);
},
setConsoleMessageExpiredCount: function(count)
Modified: trunk/Source/WebCore/inspector/front-end/DOMAgent.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/DOMAgent.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/DOMAgent.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -336,7 +336,7 @@
this._idToDOMNode = null;
this._document = null;
this._attributeLoadNodeIds = {};
- InspectorBackend.registerDomainDispatcher("DOM", new WebInspector.DOMDispatcher(this));
+ InspectorBackend.registerDOMDispatcher(new WebInspector.DOMDispatcher(this));
}
WebInspector.DOMAgent.Events = {
Modified: trunk/Source/WebCore/inspector/front-end/DOMStorage.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/DOMStorage.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/DOMStorage.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -86,4 +86,4 @@
}
}
-InspectorBackend.registerDomainDispatcher("DOMStorage", new WebInspector.DOMStorageDispatcher());
+InspectorBackend.registerDOMStorageDispatcher(new WebInspector.DOMStorageDispatcher());
Modified: trunk/Source/WebCore/inspector/front-end/Database.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/Database.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/Database.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -143,4 +143,4 @@
}
}
-InspectorBackend.registerDomainDispatcher("Database", new WebInspector.DatabaseDispatcher());
+InspectorBackend.registerDatabaseDispatcher(new WebInspector.DatabaseDispatcher());
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerModel.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/DebuggerModel.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerModel.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -33,7 +33,7 @@
this._debuggerPausedDetails = {};
this._scripts = {};
- InspectorBackend.registerDomainDispatcher("Debugger", new WebInspector.DebuggerDispatcher(this));
+ InspectorBackend.registerDebuggerDispatcher(new WebInspector.DebuggerDispatcher(this));
}
WebInspector.DebuggerModel.Events = {
Modified: trunk/Source/WebCore/inspector/front-end/NetworkManager.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -81,7 +81,7 @@
this._manager = manager;
this._inflightResourcesById = {};
this._inflightResourcesByURL = {};
- InspectorBackend.registerDomainDispatcher("Network", this);
+ InspectorBackend.registerNetworkDispatcher(this);
}
WebInspector.NetworkDispatcher.prototype = {
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -129,7 +129,7 @@
if (Preferences.heapProfilerPresent)
this._registerProfileType(new WebInspector.DetailedHeapshotProfileType());
- InspectorBackend.registerDomainDispatcher("Profiler", new WebInspector.ProfilerDispatcher(this));
+ InspectorBackend.registerProfilerDispatcher(new WebInspector.ProfilerDispatcher(this));
if (Preferences.profilerAlwaysEnabled || WebInspector.settings.profilerEnabled.get())
ProfilerAgent.enable();
Modified: trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -39,7 +39,7 @@
WebInspector.console.addEventListener(WebInspector.ConsoleView.Events.ConsoleCleared, this._consoleCleared, this);
this.frontendReused();
- InspectorBackend.registerDomainDispatcher("Page", new WebInspector.PageDispatcher(this));
+ InspectorBackend.registerPageDispatcher(new WebInspector.PageDispatcher(this));
this._pendingConsoleMessages = {};
}
Modified: trunk/Source/WebCore/inspector/front-end/TimelineManager.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/TimelineManager.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/TimelineManager.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -66,7 +66,7 @@
WebInspector.TimelineDispatcher = function(manager)
{
this._manager = manager;
- InspectorBackend.registerDomainDispatcher("Timeline", this);
+ InspectorBackend.registerTimelineDispatcher(this);
}
WebInspector.TimelineDispatcher.prototype = {
Modified: trunk/Source/WebCore/inspector/front-end/WorkerManager.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -31,7 +31,7 @@
WebInspector.WorkerManager = function()
{
this._workerIdToWindow = {};
- InspectorBackend.registerDomainDispatcher("Worker", new WebInspector.DedicatedWorkerMessageForwarder(this));
+ InspectorBackend.registerWorkerDispatcher(new WebInspector.DedicatedWorkerMessageForwarder(this));
}
WebInspector.WorkerManager.isWorkerFrontend = function()
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (93509 => 93510)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-08-22 15:36:28 UTC (rev 93510)
@@ -503,7 +503,7 @@
this.domAgent = new WebInspector.DOMAgent();
new WebInspector._javascript_ContextManager(this.resourceTreeModel, this.console);
- InspectorBackend.registerDomainDispatcher("Inspector", this);
+ InspectorBackend.registerInspectorDispatcher(this);
this.resourceCategories = {
documents: new WebInspector.ResourceCategory("documents", WebInspector.UIString("Documents"), "rgb(47,102,236)"),
