Title: [93591] trunk/Source/WebCore
Revision
93591
Author
[email protected]
Date
2011-08-23 05:21:01 -0700 (Tue, 23 Aug 2011)

Log Message

Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
https://bugs.webkit.org/show_bug.cgi?id=66753

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildAggregates):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (93590 => 93591)


--- trunk/Source/WebCore/ChangeLog	2011-08-23 10:34:28 UTC (rev 93590)
+++ trunk/Source/WebCore/ChangeLog	2011-08-23 12:21:01 UTC (rev 93591)
@@ -1,3 +1,13 @@
+2011-08-23  Mikhail Naganov  <[email protected]>
+
+        Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
+        https://bugs.webkit.org/show_bug.cgi?id=66753
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshot.prototype._buildAggregates):
+
 2011-08-23  Adam Barth  <[email protected]>
 
         Remove WebCore/editing/android and other Android-specific directories

Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (93590 => 93591)


--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2011-08-23 10:34:28 UTC (rev 93590)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2011-08-23 12:21:01 UTC (rev 93591)
@@ -832,11 +832,11 @@
         this._aggregates = {};
         for (var iter = this._allNodes; iter.hasNext(); iter.next()) {
             var node = iter.node;
-            var className = node.className;
-            var nameMatters = node.type === "object" || node.type === "native";
             if (node.type !== "native" && node.selfSize === 0)
                 continue;
-            if (!(className in this._aggregates))
+            var nameMatters = node.type === "object" || node.type === "native";
+            var className = node.className;
+            if (!this._aggregates.hasOwnProperty(className))
                 this._aggregates[className] = { count: 0, self: 0, maxRet: 0, type: node.type, name: nameMatters ? node.name : null, idxs: [] };
             var clss = this._aggregates[className];
             ++clss.count;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to