Title: [93710] trunk/Source/_javascript_Core
Revision
93710
Author
fpi...@apple.com
Date
2011-08-24 10:44:35 -0700 (Wed, 24 Aug 2011)

Log Message

ErrorInstance::create sometimes has two heap object constructions
in flight at once
https://bugs.webkit.org/show_bug.cgi?id=66845

Reviewed by Darin Adler.

The fix is simple since there is already a second create() method
that takes a UString.

* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::create):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (93709 => 93710)


--- trunk/Source/_javascript_Core/ChangeLog	2011-08-24 17:42:20 UTC (rev 93709)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-24 17:44:35 UTC (rev 93710)
@@ -1,5 +1,19 @@
 2011-08-24  Filip Pizlo  <fpi...@apple.com>
 
+        ErrorInstance::create sometimes has two heap object constructions
+        in flight at once
+        https://bugs.webkit.org/show_bug.cgi?id=66845
+
+        Reviewed by Darin Adler.
+        
+        The fix is simple since there is already a second create() method
+        that takes a UString.
+
+        * runtime/ErrorInstance.cpp:
+        (JSC::ErrorInstance::create):
+
+2011-08-24  Filip Pizlo  <fpi...@apple.com>
+
         There is no facility for profiling how the write barrier is used
         https://bugs.webkit.org/show_bug.cgi?id=66747
 

Modified: trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp (93709 => 93710)


--- trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp	2011-08-24 17:42:20 UTC (rev 93709)
+++ trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp	2011-08-24 17:44:35 UTC (rev 93710)
@@ -49,7 +49,7 @@
 {
     if (message.isUndefined())
         return new (allocateCell<ErrorInstance>(*exec->heap())) ErrorInstance(exec->globalData(), structure);
-    return new (allocateCell<ErrorInstance>(*exec->heap())) ErrorInstance(exec->globalData(), structure, message.toString(exec));
+    return create(exec->globalData(), structure, message.toString(exec));
 }
 
 } // namespace JSC
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to