Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (93737 => 93738)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-08-24 21:27:25 UTC (rev 93737)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-08-24 21:33:38 UTC (rev 93738)
@@ -109,11 +109,15 @@
});
var testNameList = failures.testNameList();
- var failuresByTest = results.unexpectedFailuresByTest(model.state.resultsByBuilder)
- var controller = new controllers.ResultsDetails(resultsView, base.filterDictionary(failuresByTest, function(key) {
- return testNameList.indexOf(testNameList) != -1;
- }));
+ var failuresByTest = base.filterDictionary(
+ results.unexpectedFailuresByTest(model.state.resultsByBuilder),
+ function(key) {
+ return testNameList.indexOf(key) != -1;
+ });
+ var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
+ controller.showTest(testNameList[0]);
+
// FIXME: This doesn't belong here. Also, we need some way to call controller.dismiss().
document.body.appendChild(resultsView);
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js (93737 => 93738)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js 2011-08-24 21:27:25 UTC (rev 93737)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js 2011-08-24 21:33:38 UTC (rev 93738)
@@ -65,7 +65,7 @@
ui.actions.Next = base.extends(Action, {
init: function() {
- this.textContent = '▶';
+ this.innerHTML = '▶';
this._eventName = 'next';
this.className = 'next';
}
@@ -73,7 +73,7 @@
ui.actions.Previous = base.extends(Action, {
init: function() {
- this.textContent = '◀';
+ this.innerHTML = '◀';
this._eventName = 'previous';
this.className = 'previous';
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js (93737 => 93738)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js 2011-08-24 21:27:25 UTC (rev 93737)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js 2011-08-24 21:33:38 UTC (rev 93738)
@@ -69,8 +69,8 @@
]);
equal(list.innerHTML,
'<li><button>Rebaseline</button></li>' +
- '<li><button class="previous">&#9664;</button></li>' +
- '<li><button class="next">&#9654;</button></li>');
+ '<li><button class="previous">◀</button></li>' +
+ '<li><button class="next">▶</button></li>');
});
}());
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css (93737 => 93738)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css 2011-08-24 21:27:25 UTC (rev 93737)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css 2011-08-24 21:33:38 UTC (rev 93738)
@@ -23,6 +23,78 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
+table {
+ table-layout: fixed;
+ width: 100%;
+ border-collapse: collapse;
+}
+
+td, th {
+ overflow: hidden;
+ vertical-align: top;
+}
+
+button {
+ border-radius: 2px;
+ background-image: -webkit-linear-gradient(top,#f5f5f5,#f1f1f1);
+ border: 1px solid rgba(0, 0, 0, 0.1);
+ border-radius: 2px;
+ color: #666;
+ cursor: pointer;
+ font-size: 11px;
+ font-weight: bold;
+ height: 29px;
+ line-height: 27px;
+ margin: 11px 6px;
+ min-width: 54px;
+ padding: 0 8px;
+ text-align: center
+}
+
+button.next {
+ margin-left: 0px;
+}
+
+button.previous {
+ margin-right: 0px;
+}
+
+button[disabled] {
+ visibility: hidden;
+}
+
+button:hover {
+ background-image: -webkit-linear-gradient(top,#f8f8f8,#f1f1f1);
+ -webkit-box-shadow: 0 1px 1px rgba(0,0,0,0.1);
+ background-color: #f8f8f8;
+ background-image: linear-gradient(top,#f8f8f8,#f1f1f1);
+ border: 1px solid #c6c6c6;
+ box-shadow: 0 1px 1px rgba(0,0,0,0.1);
+ color: #333
+}
+
+button:focus {
+ border: 1px solid #4d90fe;
+ outline: none
+}
+
+button.default {
+ border: 1px solid #3079ED;
+ color: white;
+ background-image: -webkit-linear-gradient(top,#4d90fe,#4787ed);
+}
+
+button.default:hover {
+ border: 1px solid #2f5bb7;
+ color: white;
+ background-color: #357ae8;
+ background-image: -webkit-gradient(linear,left top,left bottom,from(#4d90fe),to(#357ae8));
+}
+
+.clear {
+ clear: both;
+}
+
ol.notifications {
list-style: none;
padding: 0;
@@ -65,4 +137,59 @@
ol.notifications>li ul.causes>li li {
padding: 10px 0 0 0;
display: inline;
-}
\ No newline at end of file
+}
+
+/*** results-view ***/
+
+.results-view {
+ background-color: #f5f5f5;
+}
+
+.results-view .toolbar {
+ border-top: 1px solid #c6c6c6;
+ border-bottom: 1px solid #c6c6c6;
+}
+
+.results-view .toolbar .selector {
+ font-size: 11px;
+ font-weight: bold;
+ height: 29px;
+ line-height: 27px;
+ margin: 11px 6px;
+ padding: 0 8px;
+}
+
+.results-view .test-selector {
+ width: 400px;
+ margin-right: 6px;
+}
+
+.results-view .toolbar .actions {
+ float: right;
+}
+
+.results-view .toolbar ul.actions {
+ margin: 0;
+ padding: 0;
+ list-style: none;
+ display: inline-block;
+}
+
+.results-view .toolbar ul.actions li {
+ display: inline-block;
+}
+
+.results-view td {
+ background-color: white;
+}
+
+.text-result {
+ border: none;
+ width: 100%;
+ height: 400px; /* FIXME: How do we get a reasonable height here? */
+}
+
+.image-result {
+ width: 100%;
+ height: auto;
+}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html (93737 => 93738)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html 2011-08-24 21:27:25 UTC (rev 93737)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html 2011-08-24 21:33:38 UTC (rev 93738)
@@ -33,6 +33,7 @@
</head>
<body>
<script src=""
+<script src=""
<script src=""
<script src=""
<script src=""
Modified: trunk/Tools/ChangeLog (93737 => 93738)
--- trunk/Tools/ChangeLog 2011-08-24 21:27:25 UTC (rev 93737)
+++ trunk/Tools/ChangeLog 2011-08-24 21:33:38 UTC (rev 93738)
@@ -1,3 +1,19 @@
+2011-08-24 Adam Barth <aba...@webkit.org>
+
+ Finish writing up details-view in garden-o-matic
+ https://bugs.webkit.org/show_bug.cgi?id=66891
+
+ Reviewed by Dimitri Glazkov.
+
+ This patch mostly just copies a bunch of CSS from main.css to
+ summary.css. Presumably we'll delete main.css soon.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
+
2011-08-24 James Robinson <jam...@chromium.org>
Some compositing LayoutTests flakily crashing on Mac 10.6
