Title: [93751] trunk/Tools
- Revision
- 93751
- Author
- commit-qu...@webkit.org
- Date
- 2011-08-24 18:02:02 -0700 (Wed, 24 Aug 2011)
Log Message
[chromium] Stacktrace not in test output when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=66806
Patch by James Robinson <jam...@chromium.org> on 2011-08-24
Reviewed by Dirk Pranke.
Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
trace.
* Scripts/webkitpy/layout_tests/port/chromium.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (93750 => 93751)
--- trunk/Tools/ChangeLog 2011-08-25 00:59:51 UTC (rev 93750)
+++ trunk/Tools/ChangeLog 2011-08-25 01:02:02 UTC (rev 93751)
@@ -1,3 +1,15 @@
+2011-08-24 James Robinson <jam...@chromium.org>
+
+ [chromium] Stacktrace not in test output when a test crashes
+ https://bugs.webkit.org/show_bug.cgi?id=66806
+
+ Reviewed by Dirk Pranke.
+
+ Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
+ trace.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+
2011-08-24 Adam Barth <aba...@webkit.org>
Remove empty directory.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (93750 => 93751)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-08-25 00:59:51 UTC (rev 93750)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-08-25 01:02:02 UTC (rev 93751)
@@ -576,8 +576,15 @@
if not text:
text = None
+ error = ''.join(error)
+ # Currently the stacktrace is in the text output, not error, so append the two together so
+ # that we can see stack in the output. See http://webkit.org/b/66806
+ # FIXME: We really should properly handle the stderr output separately.
+ if crash:
+ error = error + str(text)
+
return DriverOutput(text, output_image, actual_checksum, audio=audio_bytes,
- crash=crash, test_time=run_time, timeout=timeout, error=''.join(error))
+ crash=crash, test_time=run_time, timeout=timeout, error=error)
def stop(self):
if not self._proc:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
