Title: [93754] trunk/Source/WebKit2
- Revision
- 93754
- Author
- msab...@apple.com
- Date
- 2011-08-24 18:23:43 -0700 (Wed, 24 Aug 2011)
Log Message
Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
https://bugs.webkit.org/show_bug.cgi?id=66912
Updated the comment in ArgumentEncoder::grow to reflect that system malloc
currently checks to see if a MADV_FREE_REUSABLE will fail before calling it.
Reviewed by Mark Rowe.
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::grow):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93753 => 93754)
--- trunk/Source/WebKit2/ChangeLog 2011-08-25 01:05:59 UTC (rev 93753)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-25 01:23:43 UTC (rev 93754)
@@ -1,3 +1,16 @@
+2011-08-24 Michael Saboff <msab...@apple.com>
+
+ Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
+ https://bugs.webkit.org/show_bug.cgi?id=66912
+
+ Updated the comment in ArgumentEncoder::grow to reflect that system malloc
+ currently checks to see if a MADV_FREE_REUSABLE will fail before calling it.
+
+ Reviewed by Mark Rowe.
+
+ * Platform/CoreIPC/ArgumentEncoder.cpp:
+ (CoreIPC::ArgumentEncoder::grow):
+
2011-08-24 Anders Carlsson <ander...@apple.com>
Rename -[WKTextInputWindowController keyboardInputSourceChanged] to unmarkText to indicate what the method does
Modified: trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp (93753 => 93754)
--- trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp 2011-08-25 01:05:59 UTC (rev 93753)
+++ trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp 2011-08-25 01:23:43 UTC (rev 93754)
@@ -71,8 +71,11 @@
if (alignedSize + size > m_bufferCapacity) {
size_t newCapacity = std::max(alignedSize + size, std::max(static_cast<size_t>(32), m_bufferCapacity + m_bufferCapacity / 4 + 1));
// Use system malloc / realloc instead of fastMalloc due to
- // fastMalloc using MADV_FREE_REUSABLE doesn't work with
+ // fastMalloc using MADV_FREE_REUSABLE which doesn't work with
// mach messages with OOL message and MACH_MSG_VIRTUAL_COPY.
+ // System malloc also calls madvise(MADV_FREE_REUSABLE) but after first
+ // checking via madvise(CAN_REUSE) that it will succeed. Should this
+ // behavior change we'll need to revisit this.
if (!m_buffer)
m_buffer = static_cast<uint8_t*>(malloc(newCapacity));
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
