Title: [94019] trunk/Source/WebCore
- Revision
- 94019
- Author
- carycl...@google.com
- Date
- 2011-08-29 14:57:09 -0700 (Mon, 29 Aug 2011)
Log Message
Only enable font smoothing as requested (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=67143
This adjusts LayoutTest pixel output to more closely
match other platforms.
Reviewed by Kenneth Russell.
No new tests. This platform is not yet enabled.
* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
LCD text was always enabled to test the code path. With this change,
it is only enabled when instructed by the font state.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94018 => 94019)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 21:47:48 UTC (rev 94018)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 21:57:09 UTC (rev 94019)
@@ -1,3 +1,20 @@
+2011-08-29 Cary Clark <carycl...@google.com>
+
+ Only enable font smoothing as requested (Skia on Mac)
+ https://bugs.webkit.org/show_bug.cgi?id=67143
+
+ This adjusts LayoutTest pixel output to more closely
+ match other platforms.
+
+ Reviewed by Kenneth Russell.
+
+ No new tests. This platform is not yet enabled.
+
+ * platform/graphics/skia/FontSkia.cpp:
+ (WebCore::setupPaint):
+ LCD text was always enabled to test the code path. With this change,
+ it is only enabled when instructed by the font state.
+
2011-08-29 Julien Chaffraix <jchaffr...@webkit.org>
Assertion failure in RenderLayer::computeRepaintRects when scrolling
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (94018 => 94019)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-29 21:47:48 UTC (rev 94018)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-29 21:57:09 UTC (rev 94019)
@@ -87,7 +87,7 @@
paint->setFakeBoldText(platformData.m_syntheticBold);
paint->setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0);
paint->setAutohinted(false); // freetype specific
- paint->setLCDRenderText(true); // font->fontDescription().fontSmoothing() == SubpixelAntialiased);
+ paint->setLCDRenderText(font->fontDescription().fontSmoothing() == SubpixelAntialiased);
}
// TODO: This needs to be split into helper functions to better scope the
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
