Title: [94296] trunk/Source/WebCore
- Revision
- 94296
- Author
- [email protected]
- Date
- 2011-09-01 07:22:56 -0700 (Thu, 01 Sep 2011)
Log Message
Web Inspector: Decode query/form parameters names as well as values.
https://bugs.webkit.org/show_bug.cgi?id=67393
Reviewed by Yury Semikhatsky.
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._decodeURIComponent):
(WebInspector.ResourceHeadersView.prototype._refreshParms):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94295 => 94296)
--- trunk/Source/WebCore/ChangeLog 2011-09-01 14:22:03 UTC (rev 94295)
+++ trunk/Source/WebCore/ChangeLog 2011-09-01 14:22:56 UTC (rev 94296)
@@ -1,3 +1,14 @@
+2011-09-01 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Decode query/form parameters names as well as values.
+ https://bugs.webkit.org/show_bug.cgi?id=67393
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/ResourceHeadersView.js:
+ (WebInspector.ResourceHeadersView.prototype._decodeURIComponent):
+ (WebInspector.ResourceHeadersView.prototype._refreshParms):
+
2011-08-31 Pavel Podivilov <[email protected]>
Web Inspector: remove PresentationBreakpoint class.
Modified: trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js (94295 => 94296)
--- trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js 2011-09-01 14:22:03 UTC (rev 94295)
+++ trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js 2011-09-01 14:22:56 UTC (rev 94296)
@@ -174,6 +174,26 @@
this._requestPayloadTreeElement.appendChild(parmTreeElement);
},
+ _decodeURIComponent: function(value)
+ {
+ var errorDecoding = false;
+
+ if (value.indexOf("%") >= 0) {
+ try {
+ value = decodeURIComponent(value);
+ } catch(e) {
+ errorDecoding = true;
+ }
+ }
+ value = value.replace(/\+/g, " ");
+
+ var valueEscaped = value.escapeHTML();
+ if (errorDecoding)
+ valueEscaped += " <span class=\"error-message\">" + WebInspector.UIString("(unable to decode value)").escapeHTML() + "</span>";
+
+ return valueEscaped;
+ },
+
_refreshParms: function(title, parms, parmsTreeElement)
{
parmsTreeElement.removeChildren();
@@ -196,24 +216,10 @@
var name = parms[i].name;
var value = parms[i].value;
- var errorDecoding = false;
- if (this._decodeRequestParameters) {
- if (value.indexOf("%") >= 0) {
- try {
- value = decodeURIComponent(value);
- } catch(e) {
- errorDecoding = true;
- }
- }
-
- value = value.replace(/\+/g, " ");
- }
+ var valueEscaped = this._decodeRequestParameters ? this._decodeURIComponent(value) : value.escapeHTML();
+ var nameEscaped = this._decodeRequestParameters ? this._decodeURIComponent(name) : name.escapeHTML();
- valueEscaped = value.escapeHTML();
- if (errorDecoding)
- valueEscaped += " <span class=\"error-message\">" + WebInspector.UIString("(unable to decode value)").escapeHTML() + "</span>";
-
- var title = "<div class=\"header-name\">" + name.escapeHTML() + ":</div>";
+ var title = "<div class=\"header-name\">" + nameEscaped + ":</div>";
title += "<div class=\"header-value source-code\">" + valueEscaped + "</div>";
var parmTreeElement = new TreeElement(null, null, false);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
