Diff
Modified: trunk/Source/WebCore/ChangeLog (95386 => 95387)
--- trunk/Source/WebCore/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebCore/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,22 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * history/BackForwardListImpl.cpp:
+ (WebCore::BackForwardListImpl::addItem):
+ (WebCore::BackForwardListImpl::goBack):
+ (WebCore::BackForwardListImpl::goForward):
+ (WebCore::BackForwardListImpl::goToItem):
+ (WebCore::BackForwardListImpl::setCapacity):
+ * loader/EmptyClients.h:
+ * loader/FrameLoaderClient.h:
+
2011-09-17 David Hyatt <hy...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=68307
Modified: trunk/Source/WebCore/history/BackForwardListImpl.cpp (95386 => 95387)
--- trunk/Source/WebCore/history/BackForwardListImpl.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebCore/history/BackForwardListImpl.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -82,15 +82,11 @@
m_entryHash.remove(item);
pageCache()->remove(item.get());
m_current--;
- if (m_page)
- m_page->mainFrame()->loader()->client()->dispatchDidRemoveBackForwardItem(item.get());
}
m_entryHash.add(prpItem.get());
m_entries.insert(m_current + 1, prpItem);
m_current++;
- if (m_page)
- m_page->mainFrame()->loader()->client()->dispatchDidAddBackForwardItem(currentItem());
}
void BackForwardListImpl::goBack()
@@ -98,8 +94,6 @@
ASSERT(m_current > 0);
if (m_current > 0) {
m_current--;
- if (m_page)
- m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
}
}
@@ -108,8 +102,6 @@
ASSERT(m_current < m_entries.size() - 1);
if (m_current < m_entries.size() - 1) {
m_current++;
- if (m_page)
- m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
}
}
@@ -124,8 +116,6 @@
break;
if (index < m_entries.size()) {
m_current = index;
- if (m_page)
- m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
}
}
@@ -194,8 +184,6 @@
m_current = NoCurrentItemIndex;
else if (m_current > m_entries.size() - 1) {
m_current = m_entries.size() - 1;
- if (m_page)
- m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
}
m_capacity = size;
}
Modified: trunk/Source/WebCore/loader/EmptyClients.h (95386 => 95387)
--- trunk/Source/WebCore/loader/EmptyClients.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -367,9 +367,6 @@
virtual void updateGlobalHistoryRedirectLinks() { }
virtual bool shouldGoToHistoryItem(HistoryItem*) const { return false; }
virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const { return false; }
- virtual void dispatchDidAddBackForwardItem(HistoryItem*) const { }
- virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const { }
- virtual void dispatchDidChangeBackForwardIndex() const { }
virtual void updateGlobalHistoryItemForPage() { }
virtual void saveViewStateToItem(HistoryItem*) { }
virtual bool canCachePage() const { return false; }
Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (95386 => 95387)
--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -31,7 +31,6 @@
#include "FrameLoaderTypes.h"
#include "IconURL.h"
-#include "ScrollTypes.h"
#include <wtf/Forward.h>
#include <wtf/Vector.h>
@@ -199,9 +198,6 @@
virtual bool shouldGoToHistoryItem(HistoryItem*) const = 0;
virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const = 0;
- virtual void dispatchDidAddBackForwardItem(HistoryItem*) const = 0;
- virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const = 0;
- virtual void dispatchDidChangeBackForwardIndex() const = 0;
virtual void updateGlobalHistoryItemForPage() { }
// This frame has displayed inactive content (such as an image) from an
Modified: trunk/Source/WebKit/chromium/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * src/FrameLoaderClientImpl.cpp:
+ * src/FrameLoaderClientImpl.h:
+
2011-09-17 Aaron Boodman <a...@chromium.org>
Rework script context creation/release notifications
Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp (95386 => 95387)
--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1183,18 +1183,6 @@
return !url.protocolIs(backForwardNavigationScheme);
}
-void FrameLoaderClientImpl::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void FrameLoaderClientImpl::didDisplayInsecureContent()
{
if (m_webFrame->client())
Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h (95386 => 95387)
--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -136,9 +136,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void didDisplayInsecureContent();
virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL& insecureURL);
virtual WebCore::ResourceError blockedError(const WebCore::ResourceRequest&);
Modified: trunk/Source/WebKit/efl/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/efl/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/FrameLoaderClientEfl.cpp:
+ * WebCoreSupport/FrameLoaderClientEfl.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp (95386 => 95387)
--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -169,11 +169,6 @@
notImplemented();
}
-void FrameLoaderClientEfl::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
- notImplemented();
-}
-
void FrameLoaderClientEfl::dispatchDidPushStateWithinPage()
{
notImplemented();
@@ -184,16 +179,6 @@
notImplemented();
}
-void FrameLoaderClientEfl::dispatchDidChangeBackForwardIndex() const
-{
- notImplemented();
-}
-
-void FrameLoaderClientEfl::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
- notImplemented();
-}
-
void FrameLoaderClientEfl::dispatchDidReceiveAuthenticationChallenge(DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&)
{
notImplemented();
Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h (95386 => 95387)
--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -81,9 +81,6 @@
virtual void dispatchDidPushStateWithinPage();
virtual void dispatchDidPopStateWithinPage();
virtual void dispatchDidReplaceStateWithinPage();
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*);
virtual void dispatchDidCancelAuthenticationChallenge(DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&);
Modified: trunk/Source/WebKit/gtk/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/FrameLoaderClientGtk.cpp:
+ * WebCoreSupport/FrameLoaderClientGtk.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp (95386 => 95387)
--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -713,18 +713,6 @@
return true;
}
-void FrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void FrameLoaderClient::didDisplayInsecureContent()
{
notImplemented();
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h (95386 => 95387)
--- trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -142,9 +142,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void didDisplayInsecureContent();
virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL&);
Modified: trunk/Source/WebKit/haiku/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/haiku/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/haiku/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/FrameLoaderClientHaiku.cpp:
+ * WebCoreSupport/FrameLoaderClientHaiku.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp (95386 => 95387)
--- trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -488,18 +488,6 @@
return true;
}
-void FrameLoaderClientHaiku::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem(WebCore::HistoryItem*)
{
notImplemented();
Modified: trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h (95386 => 95387)
--- trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -160,9 +160,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
virtual bool canCachePage() const;
Modified: trunk/Source/WebKit/mac/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/mac/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,17 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/WebFrameLoaderClient.h:
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+ * WebKit.order:
+
2011-09-16 Simon Fraser <simon.fra...@apple.com>
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (95386 => 95387)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -152,9 +152,6 @@
virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void updateGlobalHistoryItemForPage();
virtual void didDisplayInsecureContent();
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (95386 => 95387)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2011-09-17 23:31:52 UTC (rev 95387)
@@ -973,18 +973,6 @@
return true;
}
-void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
{
HistoryItem* historyItem = 0;
Modified: trunk/Source/WebKit/mac/WebKit.order (95386 => 95387)
--- trunk/Source/WebKit/mac/WebKit.order 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/mac/WebKit.order 2011-09-17 23:31:52 UTC (rev 95387)
@@ -738,7 +738,6 @@
-[WebDataSource(WebFileInternal) _setRepresentation:]
-[WebHTMLRepresentation setDataSource:]
__Z26WKNotifyHistoryItemChangedPN7WebCore11HistoryItemE
-__ZNK20WebFrameLoaderClient29dispatchDidAddBackForwardItemEPN7WebCore11HistoryItemE
__ZN20WebFrameLoaderClient19updateGlobalHistoryEv
-[WebView(WebPendingPublic) historyDelegate]
__ZN20WebFrameLoaderClient32updateGlobalHistoryRedirectLinksEv
@@ -1220,7 +1219,6 @@
-[WebFrame(WebPrivate) _pauseAnimation:onNode:atTime:]
_WKExecutableWasLinkedOnOrBeforeSnowLeopard
+[WebCoreStatistics garbageCollectJavaScriptObjects]
-__ZNK20WebFrameLoaderClient32dispatchDidRemoveBackForwardItemEPN7WebCore11HistoryItemE
__ZNK7WebCore12ChromeClient29dispatchViewportDataDidChangeERKNS_17ViewportArgumentsE
-[WebView(WebPrivate) setFrameSize:]
-[WebFrame(WebKitDebug) renderTreeAsExternalRepresentationForPrinting:]
@@ -1756,7 +1754,6 @@
-[WebView(WebPendingPublic) zoomPageIn:]
__ZNK20WebFrameLoaderClient21shouldGoToHistoryItemEPN7WebCore11HistoryItemE
-[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]
-__ZNK20WebFrameLoaderClient33dispatchDidChangeBackForwardIndexEv
-[WebView(WebPendingPublic) zoomPageOut:]
-[WebView _zoomOut:isTextOnly:]
-[WebFrame(WebKitDebug) counterValueForElement:]
Modified: trunk/Source/WebKit/qt/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/qt/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/FrameLoaderClientQt.cpp:
+ * WebCoreSupport/FrameLoaderClientQt.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (95386 => 95387)
--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -854,18 +854,6 @@
return true;
}
-void FrameLoaderClientQt::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientQt::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientQt::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void FrameLoaderClientQt::didDisplayInsecureContent()
{
if (dumpFrameLoaderCallbacks)
Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h (95386 => 95387)
--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -160,9 +160,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void didDisplayInsecureContent();
virtual void didRunInsecureContent(SecurityOrigin*, const KURL&);
Modified: trunk/Source/WebKit/win/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/win/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/win/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/WebFrameLoaderClient.cpp:
+ * WebCoreSupport/WebFrameLoaderClient.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (95386 => 95387)
--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -613,18 +613,6 @@
return true;
}
-void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
{
HistoryItem* historyItem = 0;
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h (95386 => 95387)
--- trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -94,9 +94,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void updateGlobalHistoryItemForPage();
virtual void didDisplayInsecureContent();
Modified: trunk/Source/WebKit/wince/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/wince/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/wince/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebCoreSupport/FrameLoaderClientWinCE.cpp:
+ * WebCoreSupport/FrameLoaderClientWinCE.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp (95386 => 95387)
--- trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -264,18 +264,6 @@
return true;
}
-void FrameLoaderClientWinCE::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWinCE::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWinCE::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void FrameLoaderClientWinCE::didDisplayInsecureContent()
{
notImplemented();
Modified: trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h (95386 => 95387)
--- trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -137,9 +137,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void didDisplayInsecureContent();
virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL&);
Modified: trunk/Source/WebKit/wx/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit/wx/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/wx/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebKitSupport/FrameLoaderClientWx.cpp:
+ * WebKitSupport/FrameLoaderClientWx.h:
+
2011-09-15 Adam Barth <aba...@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Modified: trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp (95386 => 95387)
--- trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -592,18 +592,6 @@
return true;
}
-void FrameLoaderClientWx::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWx::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWx::dispatchDidChangeBackForwardIndex() const
-{
-}
-
void FrameLoaderClientWx::didDisplayInsecureContent()
{
notImplemented();
Modified: trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h (95386 => 95387)
--- trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -165,9 +165,6 @@
virtual void updateGlobalHistoryRedirectLinks();
virtual bool shouldGoToHistoryItem(HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
virtual bool canCachePage() const;
Modified: trunk/Source/WebKit2/ChangeLog (95386 => 95387)
--- trunk/Source/WebKit2/ChangeLog 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-17 23:31:52 UTC (rev 95387)
@@ -1,3 +1,16 @@
+2011-09-17 Mihai Parparita <mih...@chromium.org>
+
+ FrameLoaderClient BackForwardList-related methods are unsued
+ https://bugs.webkit.org/show_bug.cgi?id=68293
+
+ Reviewed by Darin Adler.
+
+ Remove FrameLoaderClient methods that were added by r51629, since only
+ the old (since-deleted) Android port needed them.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+
2011-09-16 Gopal Raghavan <gopal.1.ragha...@nokia.com>
[Qt] QTouchWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68183
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (95386 => 95387)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2011-09-17 23:31:52 UTC (rev 95387)
@@ -923,21 +923,6 @@
return true;
}
-void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
- notImplemented();
-}
-
-void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
- notImplemented();
-}
-
-void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
- notImplemented();
-}
-
void WebFrameLoaderClient::didDisplayInsecureContent()
{
WebPage* webPage = m_frame->page();
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h (95386 => 95387)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2011-09-17 23:12:16 UTC (rev 95386)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h 2011-09-17 23:31:52 UTC (rev 95387)
@@ -135,9 +135,6 @@
virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
- virtual void dispatchDidChangeBackForwardIndex() const;
virtual void didDisplayInsecureContent();
virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL&);
