Title: [95632] trunk/Source/WebCore
Revision
95632
Author
loi...@chromium.org
Date
2011-09-21 08:19:16 -0700 (Wed, 21 Sep 2011)

Log Message

Web Inspector: make WebInspector a bit more timeline friendly.
https://bugs.webkit.org/show_bug.cgi?id=68534

I found that the maximum captured stack frame depth tracked by timeline is not
very convenient because the average depth of call stack considerably more than five.
Another useful trick is console.timeStamp for all backend calls.

Reviewed by Yury Semikhatsky.

* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (95631 => 95632)


--- trunk/Source/WebCore/ChangeLog	2011-09-21 15:10:43 UTC (rev 95631)
+++ trunk/Source/WebCore/ChangeLog	2011-09-21 15:19:16 UTC (rev 95632)
@@ -1,3 +1,18 @@
+2011-09-21  Ilya Tikhonovsky  <loi...@chromium.org>
+
+        Web Inspector: make WebInspector a bit more timeline friendly.
+        https://bugs.webkit.org/show_bug.cgi?id=68534
+
+        I found that the maximum captured stack frame depth tracked by timeline is not
+        very convenient because the average depth of call stack considerably more than five.
+        Another useful trick is console.timeStamp for all backend calls.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/CodeGeneratorInspector.pm:
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
+
 2011-09-21  Jesus Sanchez-Palencia  <jesus.palen...@openbossa.org>
 
         [Qt][WK2] Implement Download support in WebProcess

Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm (95631 => 95632)


--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm	2011-09-21 15:10:43 UTC (rev 95631)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm	2011-09-21 15:19:16 UTC (rev 95632)
@@ -860,6 +860,7 @@
 
     sendMessageObjectToBackend: function(messageObject)
     {
+        console.timeStamp(messageObject.method);
         var message = JSON.stringify(messageObject);
         InspectorFrontendHost.sendMessageToBackend(message);
     },

Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (95631 => 95632)


--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2011-09-21 15:10:43 UTC (rev 95631)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2011-09-21 15:19:16 UTC (rev 95632)
@@ -347,7 +347,7 @@
             WebInspector.timelineManager.stop();
         else {
             this._clearPanel();
-            WebInspector.timelineManager.start();
+            WebInspector.timelineManager.start(30);
             WebInspector.userMetrics.TimelineStarted.record();
         }
         this.toggleTimelineButton.toggled = !this.toggleTimelineButton.toggled;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to