Title: [95649] trunk
- Revision
- 95649
- Author
- vse...@chromium.org
- Date
- 2011-09-21 11:01:32 -0700 (Wed, 21 Sep 2011)
Log Message
Web Inspector: clear resource agent resource cache upon resource agent's disable.
https://bugs.webkit.org/show_bug.cgi?id=67995
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/network/network-disabling-check-no-memory-leak.html
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):
LayoutTests:
* http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt: Added.
* http/tests/inspector/network/network-disabling-check-no-memory-leak.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (95648 => 95649)
--- trunk/LayoutTests/ChangeLog 2011-09-21 17:58:22 UTC (rev 95648)
+++ trunk/LayoutTests/ChangeLog 2011-09-21 18:01:32 UTC (rev 95649)
@@ -1,3 +1,13 @@
+2011-09-21 Vsevolod Vlasov <vse...@chromium.org>
+
+ Web Inspector: clear resource agent resource cache upon resource agent's disable.
+ https://bugs.webkit.org/show_bug.cgi?id=67995
+
+ Reviewed by Pavel Feldman.
+
+ * http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt: Added.
+ * http/tests/inspector/network/network-disabling-check-no-memory-leak.html: Added.
+
2011-09-21 David Hyatt <hy...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=68543
Added: trunk/LayoutTests/http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt (0 => 95649)
--- trunk/LayoutTests/http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt 2011-09-21 18:01:32 UTC (rev 95649)
@@ -0,0 +1,5 @@
+CONSOLE MESSAGE: line 13: Done.
+Tests that after disabling network domain, content saved on backend is removed. Bug 67995
+
+resource.content after disabling network domain: null
+
Added: trunk/LayoutTests/http/tests/inspector/network/network-disabling-check-no-memory-leak.html (0 => 95649)
--- trunk/LayoutTests/http/tests/inspector/network/network-disabling-check-no-memory-leak.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-disabling-check-no-memory-leak.html 2011-09-21 18:01:32 UTC (rev 95649)
@@ -0,0 +1,59 @@
+<html>
+<head>
+<script src=""
+<script src=""
+<script>
+function loadData()
+{
+ doXHR("GET", "resources/resource.php", true, resourceLoaded);
+}
+
+function resourceLoaded()
+{
+ console.log("Done.");
+}
+
+function test()
+{
+ // Since this test could be run together with other inspector backend cache
+ // tests, we need to reset size limits to default ones.
+ InspectorTest.resetInspectorResourcesData(step1);
+
+ function step1()
+ {
+ InspectorTest.addConsoleSniffer(step2);
+ InspectorTest.evaluateInPage("loadData()");
+ }
+
+ function step2()
+ {
+ NetworkAgent.disable(step3);
+ }
+
+ function step3()
+ {
+ var resource1 = WebInspector.panels.network.resources[WebInspector.panels.network.resources.length - 1];
+ resource1.requestContent(step4);
+ }
+
+ function step4()
+ {
+ var resource1 = WebInspector.panels.network.resources[WebInspector.panels.network.resources.length - 1];
+ InspectorTest.addResult("resource.content after disabling network domain: " + resource1.content);
+ NetworkAgent.enable(step5);
+ }
+
+ function step5()
+ {
+ InspectorTest.completeTest();
+ }
+}
+</script>
+</head>
+<body _onload_="runTest()">
+ <p>
+ Tests that after disabling network domain, content saved on backend is removed.
+<a href="" 67995</a>
+</p>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (95648 => 95649)
--- trunk/Source/WebCore/ChangeLog 2011-09-21 17:58:22 UTC (rev 95648)
+++ trunk/Source/WebCore/ChangeLog 2011-09-21 18:01:32 UTC (rev 95649)
@@ -1,3 +1,15 @@
+2011-09-21 Vsevolod Vlasov <vse...@chromium.org>
+
+ Web Inspector: clear resource agent resource cache upon resource agent's disable.
+ https://bugs.webkit.org/show_bug.cgi?id=67995
+
+ Reviewed by Pavel Feldman.
+
+ Test: http/tests/inspector/network/network-disabling-check-no-memory-leak.html
+
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::disable):
+
2011-09-21 David Hyatt <hy...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=68543
Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp (95648 => 95649)
--- trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp 2011-09-21 17:58:22 UTC (rev 95648)
+++ trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp 2011-09-21 18:01:32 UTC (rev 95649)
@@ -463,6 +463,7 @@
{
m_state->setBoolean(ResourceAgentState::resourceAgentEnabled, false);
m_instrumentingAgents->setInspectorResourceAgent(0);
+ m_resourcesData->clear();
}
void InspectorResourceAgent::setUserAgentOverride(ErrorString*, const String& userAgent)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
