Title: [95686] trunk/Source/WebCore
Revision
95686
Author
ander...@apple.com
Date
2011-09-21 16:58:20 -0700 (Wed, 21 Sep 2011)

Log Message

Add back protection against the NSView going away while handling mouseDown
https://bugs.webkit.org/show_bug.cgi?id=68585

Reviewed by Darin Adler.

Add calls to RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates(),
as a followup fix to https://bugs.webkit.org/show_bug.cgi?id=68570.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (95685 => 95686)


--- trunk/Source/WebCore/ChangeLog	2011-09-21 23:50:54 UTC (rev 95685)
+++ trunk/Source/WebCore/ChangeLog	2011-09-21 23:58:20 UTC (rev 95686)
@@ -1,3 +1,16 @@
+2011-09-21  Anders Carlsson  <ander...@apple.com>
+
+        Add back protection against the NSView going away while handling mouseDown
+        https://bugs.webkit.org/show_bug.cgi?id=68585
+
+        Reviewed by Darin Adler.
+
+        Add calls to RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates(),
+        as a followup fix to https://bugs.webkit.org/show_bug.cgi?id=68570.
+
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::passMouseDownEventToWidget):
+
 2011-09-21  Julien Chaffraix  <jchaffr...@webkit.org>
 
         Crash in RenderBox::paintMaskImages when GraphicsContext's painting is disabled

Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (95685 => 95686)


--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm	2011-09-21 23:50:54 UTC (rev 95685)
+++ trunk/Source/WebCore/page/mac/EventHandlerMac.mm	2011-09-21 23:58:20 UTC (rev 95686)
@@ -228,7 +228,9 @@
     ASSERT(!m_sendingEventToSubview);
     m_sendingEventToSubview = true;
 
+    RenderWidget::suspendWidgetHierarchyUpdates();
     [view mouseDown:currentNSEvent()];
+    RenderWidget::resumeWidgetHierarchyUpdates();
     
     if (!wasDeferringLoading)
         page->setDefersLoading(false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to