Title: [96101] trunk/Source/WebKit2
Revision
96101
Author
alexis.men...@openbossa.org
Date
2011-09-27 05:58:02 -0700 (Tue, 27 Sep 2011)

Log Message

[Qt][WK2] API fixes for QML, the signal parameters needs to be named.
https://bugs.webkit.org/show_bug.cgi?id=68889

Reviewed by Andreas Kling.

Signal parameters needs to be explicitly named in QML to be accessible.
This patch fix this problem.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (96100 => 96101)


--- trunk/Source/WebKit2/ChangeLog	2011-09-27 12:39:16 UTC (rev 96100)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 12:58:02 UTC (rev 96101)
@@ -1,5 +1,18 @@
 2011-09-27  Alexis Menard  <alexis.men...@openbossa.org>
 
+        [Qt][WK2] API fixes for QML, the signal parameters needs to be named.
+        https://bugs.webkit.org/show_bug.cgi?id=68889
+
+        Reviewed by Andreas Kling.
+
+        Signal parameters needs to be explicitly named in QML to be accessible.
+        This patch fix this problem.
+
+        * UIProcess/API/qt/qdesktopwebview.h:
+        * UIProcess/API/qt/qtouchwebpage.h:
+
+2011-09-27  Alexis Menard  <alexis.men...@openbossa.org>
+
         [Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
         https://bugs.webkit.org/show_bug.cgi?id=68848
 

Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h (96100 => 96101)


--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-09-27 12:39:16 UTC (rev 96100)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-09-27 12:58:02 UTC (rev 96101)
@@ -81,13 +81,13 @@
      void load(const QUrl&);
 
 Q_SIGNALS:
-    void titleChanged(const QString&);
-    void statusBarMessageChanged(const QString&);
+    void titleChanged(const QString& title);
+    void statusBarMessageChanged(const QString& message);
     void loadStarted();
     void loadSucceeded();
     void loadFailed(QDesktopWebView::ErrorType errorType, int errorCode, const QUrl& url);
     void loadProgressChanged(int progress);
-    void urlChanged(const QUrl&);
+    void urlChanged(const QUrl& url);
 
 protected:
     virtual void keyPressEvent(QKeyEvent*);

Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h (96100 => 96101)


--- trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h	2011-09-27 12:39:16 UTC (rev 96100)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h	2011-09-27 12:58:02 UTC (rev 96101)
@@ -65,8 +65,8 @@
     virtual bool event(QEvent*);
 
 Q_SIGNALS:
-    void urlChanged(const QUrl&);
-    void titleChanged(const QString&);
+    void urlChanged(const QUrl& url);
+    void titleChanged(const QString& title);
     void loadStarted();
     void loadSucceeded();
     void loadFailed(QTouchWebPage::ErrorType errorType, int errorCode, const QUrl& url);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to