Title: [96129] trunk/Tools
- Revision
- 96129
- Author
- aba...@webkit.org
- Date
- 2011-09-27 10:53:32 -0700 (Tue, 27 Sep 2011)
Log Message
garden-o-matic results view should sort test and builder names
https://bugs.webkit.org/show_bug.cgi?id=68488
Reviewed by Andy Estes.
Previously, the test and builder names were displayed in an arbitrary
order that changed from time to time. That confused one user study
participant. This patch sorts the lists so that they occur in a
predictable order.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (96128 => 96129)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-09-27 17:38:52 UTC (rev 96128)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-09-27 17:53:32 UTC (rev 96129)
@@ -169,7 +169,7 @@
this._delegate = delegate;
this._length = 0;
- Object.keys(resultsByTest).forEach(function (testName) {
+ Object.keys(resultsByTest).sort().forEach(function(testName) {
var link = document.createElement('a');
$(link).attr('href', '#').text(testName);
@@ -245,7 +245,7 @@
var tabStrip = this.appendChild(document.createElement('ul'));
- Object.keys(resultsByBuilder).forEach(function(builderName) {
+ Object.keys(resultsByBuilder).sort().forEach(function(builderName) {
var builderDirectory = results.directoryForBuilder(builderName);
var link = document.createElement('a');
Modified: trunk/Tools/ChangeLog (96128 => 96129)
--- trunk/Tools/ChangeLog 2011-09-27 17:38:52 UTC (rev 96128)
+++ trunk/Tools/ChangeLog 2011-09-27 17:53:32 UTC (rev 96129)
@@ -1,3 +1,17 @@
+2011-09-27 Adam Barth <aba...@webkit.org>
+
+ garden-o-matic results view should sort test and builder names
+ https://bugs.webkit.org/show_bug.cgi?id=68488
+
+ Reviewed by Andy Estes.
+
+ Previously, the test and builder names were displayed in an arbitrary
+ order that changed from time to time. That confused one user study
+ participant. This patch sorts the lists so that they occur in a
+ predictable order.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+
2011-09-27 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r96108, r96111, r96113, and r96116.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
