Title: [96185] trunk/Source/WebCore
Revision
96185
Author
commit-qu...@webkit.org
Date
2011-09-27 21:03:24 -0700 (Tue, 27 Sep 2011)

Log Message

[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
https://bugs.webkit.org/show_bug.cgi?id=68967

Patch by James Robinson <jam...@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.

When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).

Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (96184 => 96185)


--- trunk/Source/WebCore/ChangeLog	2011-09-28 03:39:36 UTC (rev 96184)
+++ trunk/Source/WebCore/ChangeLog	2011-09-28 04:03:24 UTC (rev 96185)
@@ -1,3 +1,18 @@
+2011-09-27  James Robinson  <jam...@chromium.org>
+
+        [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
+        https://bugs.webkit.org/show_bug.cgi?id=68967
+
+        Reviewed by Kenneth Russell.
+
+        When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
+        opposed to only a redraw).
+
+        Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.
+
+        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
+        (WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
+
 2011-09-27  Kentaro Hara  <hara...@chromium.com>
 
         Implement a PageTransitionEvent constructor for V8

Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp (96184 => 96185)


--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2011-09-28 03:39:36 UTC (rev 96184)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2011-09-28 04:03:24 UTC (rev 96185)
@@ -397,7 +397,7 @@
     // FIXME: use CCScheduler to decide when to manage the conversion of this
     // commit request into an actual createBeginFrameAndCommitTaskOnCCThread call.
     m_redrawRequestedOnCCThread |= redrawRequested;
-    if (!m_beginFrameAndCommitPendingOnCCThread) {
+    if (commitRequested && !m_beginFrameAndCommitPendingOnCCThread) {
         CCMainThread::postTask(createBeginFrameAndCommitTaskOnCCThread());
         return;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to