Title: [96212] trunk
- Revision
- 96212
- Author
- [email protected]
- Date
- 2011-09-28 02:54:22 -0700 (Wed, 28 Sep 2011)
Log Message
Implement a PopStateEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68896
Patch by Kentaro Hara <[email protected]> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/pop-state-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
* dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (96211 => 96212)
--- trunk/LayoutTests/ChangeLog 2011-09-28 09:45:13 UTC (rev 96211)
+++ trunk/LayoutTests/ChangeLog 2011-09-28 09:54:22 UTC (rev 96212)
@@ -1,3 +1,14 @@
+2011-09-28 Kentaro Hara <[email protected]>
+
+ Implement a PopStateEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=68896
+
+ Reviewed by Adam Barth.
+
+ Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
2011-09-28 Ilya Tikhonovsky <[email protected]>
Unreviewed fix for test.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96211 => 96212)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-28 09:45:13 UTC (rev 96211)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-28 09:54:22 UTC (rev 96212)
@@ -81,9 +81,6 @@
// CSS3 Selectors3 test suite
BUGCR89468 : css3/selectors3 = PASS FAIL
-// This will soon be fixed after implementing a PopStateEvent constructor for V8.
-BUGWK67977 : fast/events/constructors/pop-state-event-constructor.html = FAIL
-
// Tests for WebVTT parser for <track>. Feature is not yet functional.
BUGWK43668 SKIP : media/track/ = TIMEOUT
Modified: trunk/Source/WebCore/ChangeLog (96211 => 96212)
--- trunk/Source/WebCore/ChangeLog 2011-09-28 09:45:13 UTC (rev 96211)
+++ trunk/Source/WebCore/ChangeLog 2011-09-28 09:54:22 UTC (rev 96212)
@@ -1,3 +1,15 @@
+2011-09-28 Kentaro Hara <[email protected]>
+
+ Implement a PopStateEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=68896
+
+ Reviewed by Adam Barth.
+
+ Test: fast/events/constructors/pop-state-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
+ * dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
+
2011-09-28 No'am Rosenthal <[email protected]>
[Texmap] Allow TextureMapperGL to work without a GraphicsContext
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (96211 => 96212)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-28 09:45:13 UTC (rev 96211)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-28 09:54:22 UTC (rev 96212)
@@ -39,6 +39,7 @@
#include "HashChangeEvent.h"
#include "Node.h"
#include "PageTransitionEvent.h"
+#include "PopStateEvent.h"
#include "ProgressEvent.h"
#include "WebKitAnimationEvent.h"
@@ -53,6 +54,7 @@
#include "V8HashChangeEvent.h"
#include "V8Node.h"
#include "V8PageTransitionEvent.h"
+#include "V8PopStateEvent.h"
#include "V8ProgressEvent.h"
#include "V8Proxy.h"
#include "V8WebKitAnimationEvent.h"
@@ -117,6 +119,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CLOSE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/PopStateEvent.idl (96211 => 96212)
--- trunk/Source/WebCore/dom/PopStateEvent.idl 2011-09-28 09:45:13 UTC (rev 96211)
+++ trunk/Source/WebCore/dom/PopStateEvent.idl 2011-09-28 09:54:22 UTC (rev 96212)
@@ -29,7 +29,8 @@
#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
interface [
CanBeConstructed,
- CustomConstructFunction
+ CustomConstructFunction,
+ V8CustomConstructor
] PopStateEvent : Event {
void initPopStateEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
in [Optional=CallWithDefaultValue] boolean canBubbleArg,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
