Title: [97684] trunk/Tools
- Revision
- 97684
- Author
- commit-qu...@webkit.org
- Date
- 2011-10-17 17:46:28 -0700 (Mon, 17 Oct 2011)
Log Message
[EFL] DRT: Make non-recognized keys work in events as well.
https://bugs.webkit.org/show_bug.cgi?id=69860
Patch by Raphael Kubo da Costa <k...@profusion.mobi> on 2011-10-17
Reviewed by Antonio Gomes.
fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
here: it has a select box with a few non-latin options, and one of them
is selected via the keyboard.
In this specific case, we need to make EventHandler::keyEvent send a
keyPressEvent to SelectElement, so that
SelectElement::defaultEventHandler calls typeAheadFind(). This happens
only when PlatformKeyEvent::text() is not empty, which was not the case
so far.
* DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (97683 => 97684)
--- trunk/Tools/ChangeLog 2011-10-18 00:45:09 UTC (rev 97683)
+++ trunk/Tools/ChangeLog 2011-10-18 00:46:28 UTC (rev 97684)
@@ -1,3 +1,23 @@
+2011-10-17 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ [EFL] DRT: Make non-recognized keys work in events as well.
+ https://bugs.webkit.org/show_bug.cgi?id=69860
+
+ Reviewed by Antonio Gomes.
+
+ fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
+ here: it has a select box with a few non-latin options, and one of them
+ is selected via the keyboard.
+
+ In this specific case, we need to make EventHandler::keyEvent send a
+ keyPressEvent to SelectElement, so that
+ SelectElement::defaultEventHandler calls typeAheadFind(). This happens
+ only when PlatformKeyEvent::text() is not empty, which was not the case
+ so far.
+
+ * DumpRenderTree/efl/EventSender.cpp:
+ (keyDownCallback):
+
2011-10-17 Alok Priyadarshi <al...@chromium.org>
Add layout tests for WebPlugin compositor path
Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (97683 => 97684)
--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2011-10-18 00:45:09 UTC (rev 97683)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2011-10-18 00:46:28 UTC (rev 97684)
@@ -423,8 +423,8 @@
if (!keyName)
keyName = cCharacter.data();
- evas_event_feed_key_down(evas, keyName, keyName, 0, 0, 0, 0);
- evas_event_feed_key_up(evas, keyName, keyName, 0, 0, 1, 0);
+ evas_event_feed_key_down(evas, keyName, keyName, keyName, 0, 0, 0);
+ evas_event_feed_key_up(evas, keyName, keyName, keyName, 0, 1, 0);
setEvasModifiers(evas, EvasKeyModifierNone);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
