Title: [200608] trunk/Source/WebInspectorUI
- Revision
- 200608
- Author
- mattba...@apple.com
- Date
- 2016-05-09 19:45:14 -0700 (Mon, 09 May 2016)
Log Message
Web Inspector: Filtering by Errors/Warnings should not filter Breakpoints list
https://bugs.webkit.org/show_bug.cgi?id=157481
<rdar://problem/26177346>
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js:
New UI strings.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction):
Only filter tree elements belonging to the scripts tree outline.
(WebInspector.DebuggerSidebarPanel):
Drive-by cleanup of Issues filter button tooltips.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200607 => 200608)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 02:31:03 UTC (rev 200607)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 02:45:14 UTC (rev 200608)
@@ -1,3 +1,20 @@
+2016-05-09 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: Filtering by Errors/Warnings should not filter Breakpoints list
+ https://bugs.webkit.org/show_bug.cgi?id=157481
+ <rdar://problem/26177346>
+
+ Reviewed by Timothy Hatcher.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ New UI strings.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction):
+ Only filter tree elements belonging to the scripts tree outline.
+ (WebInspector.DebuggerSidebarPanel):
+ Drive-by cleanup of Issues filter button tooltips.
+
2016-05-09 Nikita Vasilyev <nvasil...@apple.com>
REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (200607 => 200608)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-05-10 02:31:03 UTC (rev 200607)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2016-05-10 02:45:14 UTC (rev 200608)
@@ -501,6 +501,7 @@
localizedStrings["Object Graph"] = "Object Graph";
localizedStrings["Offset"] = "Offset";
localizedStrings["Online"] = "Online";
+localizedStrings["Only show resources with issues"] = "Only show resources with issues";
localizedStrings["Opacity"] = "Opacity";
localizedStrings["Option-click to show all units"] = "Option-click to show all units";
localizedStrings["Option-click to show all values"] = "Option-click to show all values";
@@ -636,10 +637,9 @@
localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)";
localizedStrings["Show Replay Controls"] = "Show Replay Controls";
localizedStrings["Show Source"] = "Show Source";
+localizedStrings["Show all resources"] = "Show all resources";
localizedStrings["Show compositing borders"] = "Show compositing borders";
localizedStrings["Show console tab"] = "Show console tab";
-localizedStrings["Show only resources with issues."] = "Show only resources with issues.";
-localizedStrings["Show resources with and without issues."] = "Show resources with and without issues.";
localizedStrings["Show shadow DOM nodes"] = "Show shadow DOM nodes";
localizedStrings["Show the details sidebar (%s)"] = "Show the details sidebar (%s)";
localizedStrings["Show the navigation sidebar (%s)"] = "Show the navigation sidebar (%s)";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (200607 => 200608)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-10 02:31:03 UTC (rev 200607)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-10 02:45:14 UTC (rev 200608)
@@ -107,6 +107,10 @@
function showResourcesWithIssuesOnlyFilterFunction(treeElement)
{
+ // Issues are only shown in the scripts tree outline.
+ if (treeElement.treeOutline !== this._scriptsContentTreeOutline)
+ return true;
+
// Keep issues.
if (treeElement instanceof WebInspector.IssueTreeElement)
return true;
@@ -121,7 +125,7 @@
return false;
};
- this.filterBar.addFilterBarButton("debugger-show-resources-with-issues-only", showResourcesWithIssuesOnlyFilterFunction, true, WebInspector.UIString("Show only resources with issues."), WebInspector.UIString("Show resources with and without issues."), "Images/Errors.svg", 15, 15);
+ this.filterBar.addFilterBarButton("debugger-show-resources-with-issues-only", showResourcesWithIssuesOnlyFilterFunction.bind(this), true, WebInspector.UIString("Only show resources with issues"), WebInspector.UIString("Show all resources"), "Images/Errors.svg", 15, 15);
this._breakpointsContentTreeOutline = this.contentTreeOutline;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
