Title: [200644] trunk/Source/WebInspectorUI
- Revision
- 200644
- Author
- mattba...@apple.com
- Date
- 2016-05-10 14:30:09 -0700 (Tue, 10 May 2016)
Log Message
Web Inspector: TimelineOverview assertion failed: Missing overview graph for timeline type undefined
https://bugs.webkit.org/show_bug.cgi?id=157533
<rdar://problem/26204033>
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._recordWasFiltered):
The OverviewTimelineView's represented object is the entire recording,
and TimelineOverview.recordWasFiltered expects a timeline. Return early
since no graph in the overview needs updating.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200643 => 200644)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 21:26:00 UTC (rev 200643)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-10 21:30:09 UTC (rev 200644)
@@ -1,5 +1,19 @@
2016-05-10 Matt Baker <mattba...@apple.com>
+ Web Inspector: TimelineOverview assertion failed: Missing overview graph for timeline type undefined
+ https://bugs.webkit.org/show_bug.cgi?id=157533
+ <rdar://problem/26204033>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype._recordWasFiltered):
+ The OverviewTimelineView's represented object is the entire recording,
+ and TimelineOverview.recordWasFiltered expects a timeline. Return early
+ since no graph in the overview needs updating.
+
+2016-05-10 Matt Baker <mattba...@apple.com>
+
Web Inspector: Call Trees and Memory view blank
https://bugs.webkit.org/show_bug.cgi?id=157486
<rdar://problem/26178404>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (200643 => 200644)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-05-10 21:26:00 UTC (rev 200643)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-05-10 21:30:09 UTC (rev 200644)
@@ -719,9 +719,15 @@
if (event.target !== this.currentTimelineView)
return;
+ console.assert(this.currentTimelineView);
+
+ let timeline = this.currentTimelineView.representedObject;
+ if (!(timeline instanceof WebInspector.Timeline))
+ return;
+
let record = event.data.record;
let filtered = event.data.filtered;
- this._timelineOverview.recordWasFiltered(this.currentTimelineView.representedObject, record, filtered);
+ this._timelineOverview.recordWasFiltered(timeline, record, filtered);
}
_updateProgressView()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
