Title: [200786] trunk/Source/WebKit/mac
- Revision
- 200786
- Author
- [email protected]
- Date
- 2016-05-12 12:29:48 -0700 (Thu, 12 May 2016)
Log Message
WebKitAdditions needs to be notified before the WebView is dealloc'd
https://bugs.webkit.org/show_bug.cgi?id=157633
-and corresponding-
rdar://problem/26134539
Reviewed by Anders Carlsson.
* WebView/WebView.mm:
(-[WebView dealloc]):
* WebView/WebViewInternal.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (200785 => 200786)
--- trunk/Source/WebKit/mac/ChangeLog 2016-05-12 19:14:48 UTC (rev 200785)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-05-12 19:29:48 UTC (rev 200786)
@@ -1,3 +1,16 @@
+2016-05-12 Beth Dakin <[email protected]>
+
+ WebKitAdditions needs to be notified before the WebView is dealloc'd
+ https://bugs.webkit.org/show_bug.cgi?id=157633
+ -and corresponding-
+ rdar://problem/26134539
+
+ Reviewed by Anders Carlsson.
+
+ * WebView/WebView.mm:
+ (-[WebView dealloc]):
+ * WebView/WebViewInternal.h:
+
2016-05-12 Konstantin Tokarev <[email protected]>
Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (200785 => 200786)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-05-12 19:14:48 UTC (rev 200785)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-05-12 19:29:48 UTC (rev 200786)
@@ -5194,6 +5194,8 @@
[_private->_geolocationProvider stopTrackingWebView:self];
#endif
+ [self webViewAdditionsWillDestroyView];
+
// call close to ensure we tear-down completely
// this maintains our old behavior for existing applications
[self close];
@@ -6699,6 +6701,10 @@
return NO;
}
+- (void)webViewAdditionsWillDestroyView
+{
+}
+
@end
#endif // PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK)
Modified: trunk/Source/WebKit/mac/WebView/WebViewInternal.h (200785 => 200786)
--- trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2016-05-12 19:14:48 UTC (rev 200785)
+++ trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2016-05-12 19:29:48 UTC (rev 200786)
@@ -299,4 +299,5 @@
- (void)updateWebViewAdditions;
- (void)showCandidates:(NSArray *)candidates forString:(NSString *)string inRect:(NSRect)rectOfTypedString forSelectedRange:(NSRange)range view:(NSView *)view completionHandler:(void (^)(NSTextCheckingResult *acceptedCandidate))completionBlock;
- (BOOL)shouldRequestCandidates;
+- (void)webViewAdditionsWillDestroyView;
@end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
