Title: [200790] trunk/Source/WebInspectorUI
- Revision
- 200790
- Author
- [email protected]
- Date
- 2016-05-12 14:52:46 -0700 (Thu, 12 May 2016)
Log Message
Unreviewed, rolling out r200718.
https://bugs.webkit.org/show_bug.cgi?id=157637
Data grid column dividers are misaligned (Requested by NVI on
#webkit).
Reverted changeset:
"Web Inspector: Contents of Duration column are covered by
always on (legacy) scroll bars"
https://bugs.webkit.org/show_bug.cgi?id=157590
http://trac.webkit.org/changeset/200718
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200789 => 200790)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 21:13:13 UTC (rev 200789)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 21:52:46 UTC (rev 200790)
@@ -1,3 +1,18 @@
+2016-05-12 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r200718.
+ https://bugs.webkit.org/show_bug.cgi?id=157637
+
+ Data grid column dividers are misaligned (Requested by NVI on
+ #webkit).
+
+ Reverted changeset:
+
+ "Web Inspector: Contents of Duration column are covered by
+ always on (legacy) scroll bars"
+ https://bugs.webkit.org/show_bug.cgi?id=157590
+ http://trac.webkit.org/changeset/200718
+
2016-05-12 Matt Baker <[email protected]>
Web Inspector: 11% of time in TimelineRecording spent updating DataGrid that is not visible
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (200789 => 200790)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-05-12 21:13:13 UTC (rev 200789)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-05-12 21:52:46 UTC (rev 200790)
@@ -50,7 +50,7 @@
left: 0;
right: 0;
overflow-x: hidden;
- overflow-y: scroll;
+ overflow-y: overlay;
}
.data-grid.inline .data-container {
@@ -61,16 +61,7 @@
border: 0.5px solid var(--border-color);
}
-.data-grid > .header-wrapper {
- border-bottom: 0.5px solid var(--border-color);
- overflow-y: scroll;
-}
-
-.data-grid > .header-wrapper::-webkit-scrollbar {
- -webkit-appearance: none;
-}
-
-.data-grid.no-header > .header-wrapper > table.header {
+.data-grid.no-header > table.header {
display: none;
}
@@ -84,6 +75,8 @@
background-color: white;
+ border-bottom: 0.5px solid var(--border-color);
+
font-weight: normal;
height: 22px;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (200789 => 200790)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-12 21:13:13 UTC (rev 200789)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-12 21:52:46 UTC (rev 200790)
@@ -61,13 +61,8 @@
this.element.addEventListener("keydown", this._keyDown.bind(this), false);
this.element.copyHandler = this;
- this._headerWrapperElement = document.createElement("div");
- this._headerWrapperElement.classList.add("header-wrapper");
-
this._headerTableElement = document.createElement("table");
this._headerTableElement.className = "header";
- this._headerWrapperElement.appendChild(this._headerTableElement);
-
this._headerTableColumnGroupElement = this._headerTableElement.createChild("colgroup");
this._headerTableBodyElement = this._headerTableElement.createChild("tbody");
this._headerTableRowElement = this._headerTableBodyElement.createChild("tr");
@@ -108,7 +103,7 @@
this._fillerRowElement = this.dataTableBodyElement.createChild("tr", "filler");
- this.element.appendChild(this._headerWrapperElement);
+ this.element.appendChild(this._headerTableElement);
this.element.appendChild(this._scrollContainerElement);
if (preferredColumnOrder) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
