Title: [200793] trunk/Source/WebInspectorUI
- Revision
- 200793
- Author
- [email protected]
- Date
- 2016-05-12 15:09:03 -0700 (Thu, 12 May 2016)
Log Message
Web Inspector: Timeline Reset button only resets the one active Script TimelineView
https://bugs.webkit.org/show_bug.cgi?id=157638
Patch by Joseph Pecoraro <[email protected]> on 2016-05-12
Reviewed by Timothy Hatcher.
* UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype.reset):
Reset should reset all the views.
(WebInspector.ScriptClusterTimelineView.prototype.get navigationSidebarTreeOutline): Deleted.
* UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView.prototype.get navigationSidebarTreeOutline): Deleted.
* UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.get navigationSidebarTreeOutlineScopeBar): Deleted.
Remove dead code. Nobody calls these getters.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200792 => 200793)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 22:08:28 UTC (rev 200792)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 22:09:03 UTC (rev 200793)
@@ -1,5 +1,23 @@
2016-05-12 Joseph Pecoraro <[email protected]>
+ Web Inspector: Timeline Reset button only resets the one active Script TimelineView
+ https://bugs.webkit.org/show_bug.cgi?id=157638
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ScriptClusterTimelineView.js:
+ (WebInspector.ScriptClusterTimelineView.prototype.reset):
+ Reset should reset all the views.
+
+ (WebInspector.ScriptClusterTimelineView.prototype.get navigationSidebarTreeOutline): Deleted.
+ * UserInterface/Views/NetworkGridContentView.js:
+ (WebInspector.NetworkGridContentView.prototype.get navigationSidebarTreeOutline): Deleted.
+ * UserInterface/Views/TimelineView.js:
+ (WebInspector.TimelineView.prototype.get navigationSidebarTreeOutlineScopeBar): Deleted.
+ Remove dead code. Nobody calls these getters.
+
+2016-05-12 Joseph Pecoraro <[email protected]>
+
Web Inspector: Layout timeline popovers are inconsistently shown
https://bugs.webkit.org/show_bug.cgi?id=157640
<rdar://problem/26253394>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js (200792 => 200793)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js 2016-05-12 22:08:28 UTC (rev 200792)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js 2016-05-12 22:09:03 UTC (rev 200793)
@@ -100,11 +100,6 @@
// Public
- get navigationSidebarTreeOutline()
- {
- return this._contentTreeOutline;
- }
-
get selectionPathComponents()
{
if (!this._contentTreeOutline.selectedTreeElement || this._contentTreeOutline.selectedTreeElement.hidden)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js (200792 => 200793)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js 2016-05-12 22:08:28 UTC (rev 200792)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js 2016-05-12 22:09:03 UTC (rev 200793)
@@ -71,12 +71,18 @@
set endTime(x) { this._contentViewContainer.currentContentView.endTime = x; }
get currentTime() { return this._contentViewContainer.currentContentView.currentTime; }
set currentTime(x) { this._contentViewContainer.currentContentView.currentTime = x; }
- get navigationSidebarTreeOutline() { return this._contentViewContainer.currentContentView.navigationSidebarTreeOutline; }
- reset() { return this._contentViewContainer.currentContentView.reset(); }
updateFilter(filters) { return this._contentViewContainer.currentContentView.updateFilter(filters); }
filterDidChange() { return this._contentViewContainer.currentContentView.filterDidChange(); }
matchDataGridNodeAgainstCustomFilters(node) { return this._contentViewContainer.currentContentView.matchDataGridNodeAgainstCustomFilters(node); }
+ reset()
+ {
+ this._eventsContentView.reset();
+
+ if (this._profileContentView)
+ this._profileContentView.reset();
+ }
+
// Public
get eventsContentView()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js (200792 => 200793)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2016-05-12 22:08:28 UTC (rev 200792)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2016-05-12 22:09:03 UTC (rev 200793)
@@ -60,11 +60,6 @@
return this._scopeBar ? [this._scopeBar] : [];
}
- get navigationSidebarTreeOutlineScopeBar()
- {
- return this._scopeBar;
- }
-
get selectionPathComponents()
{
// Implemented by sub-classes if needed.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
