Title: [200911] trunk/Source/WebKit2
- Revision
- 200911
- Author
- wei...@apple.com
- Date
- 2016-05-13 19:29:04 -0700 (Fri, 13 May 2016)
Log Message
REGRESSION (r200463): Autofill Credit Card expected but got Autofill Contact
<rdar://problem/26251538>
https://bugs.webkit.org/show_bug.cgi?id=157701
Reviewed by Dan Bernstein.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _certificateChain]):
We need to do a retain-autorelease here now because the CertificateInfo's that contain the
cached certificate chain, are being destroyed, and therefore destroying the chain, before this
function returns. This used to work when the chain wasn't just a cache, because there was still
a strong reference to it being held by the ResourceResponse's CertificateInfo copy, but now
there is none.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (200910 => 200911)
--- trunk/Source/WebKit2/ChangeLog 2016-05-14 02:27:50 UTC (rev 200910)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-14 02:29:04 UTC (rev 200911)
@@ -1,3 +1,19 @@
+2016-05-13 Sam Weinig <s...@webkit.org>
+
+ REGRESSION (r200463): Autofill Credit Card expected but got Autofill Contact
+ <rdar://problem/26251538>
+ https://bugs.webkit.org/show_bug.cgi?id=157701
+
+ Reviewed by Dan Bernstein.
+
+ * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
+ (-[WKWebProcessPlugInFrame _certificateChain]):
+ We need to do a retain-autorelease here now because the CertificateInfo's that contain the
+ cached certificate chain, are being destroyed, and therefore destroying the chain, before this
+ function returns. This used to work when the chain wasn't just a cache, because there was still
+ a strong reference to it being held by the ResourceResponse's CertificateInfo copy, but now
+ there is none.
+
2016-05-13 Dean Jackson <d...@apple.com>
[iOS] <select> elements popover should render right-aligned when in RTL mode
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm (200910 => 200911)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2016-05-14 02:27:50 UTC (rev 200910)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2016-05-14 02:29:04 UTC (rev 200911)
@@ -146,7 +146,7 @@
- (NSArray *)_certificateChain
{
- return (NSArray *)_frame->certificateInfo().certificateChain();
+ return [[(NSArray *)_frame->certificateInfo().certificateChain() retain] autorelease];
}
- (SecTrustRef)_serverTrust
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
