Title: [97958] trunk/Source/WebCore
- Revision
- 97958
- Author
- commit-qu...@webkit.org
- Date
- 2011-10-20 03:38:30 -0700 (Thu, 20 Oct 2011)
Log Message
[EFL] Do not manually set the frameRect in different places in ScrollbarEfl.
https://bugs.webkit.org/show_bug.cgi?id=70427
Patch by Raphael Kubo da Costa <k...@profusion.mobi> on 2011-10-20
Reviewed by Kenneth Rohde Christiansen.
This commit is related to the effort towards having a different
scrollbar (with a size > 0) for DumpRenderTree.
Scrollbar::Scrollbar() already calls setFrameRect() with the size
obtained from ScrollbarTheme::scrollbarThickness(), which is currently
always 0 for us, so the call to setFrameRect() in ScrollbarEfl's
constructor is not needed and would break things if scrollbarThickness
is changed to return another value.
The frameRect is also not changed in ScrollbarEfl::setParent() anymore,
as it also does not take scrollbarThickness() into account and thus
breaks using other themes such as ScrollbarThemeMock in DumpRenderTree.
Right now, it is always going to be 0 anyway.
It is still work in progress, though -- it'd be good to somehow move the
theming code to ScrollbarThemeEfl, as right now scrollbar EDCs with a
non-zero min size will not cause the scrollbars to have non-zero size.
No new tests, this is machinery needed to run the current tests.
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::ScrollbarEfl):
(ScrollbarEfl::setParent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97957 => 97958)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 10:25:06 UTC (rev 97957)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 10:38:30 UTC (rev 97958)
@@ -1,3 +1,34 @@
+2011-10-20 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ [EFL] Do not manually set the frameRect in different places in ScrollbarEfl.
+ https://bugs.webkit.org/show_bug.cgi?id=70427
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ This commit is related to the effort towards having a different
+ scrollbar (with a size > 0) for DumpRenderTree.
+
+ Scrollbar::Scrollbar() already calls setFrameRect() with the size
+ obtained from ScrollbarTheme::scrollbarThickness(), which is currently
+ always 0 for us, so the call to setFrameRect() in ScrollbarEfl's
+ constructor is not needed and would break things if scrollbarThickness
+ is changed to return another value.
+
+ The frameRect is also not changed in ScrollbarEfl::setParent() anymore,
+ as it also does not take scrollbarThickness() into account and thus
+ breaks using other themes such as ScrollbarThemeMock in DumpRenderTree.
+ Right now, it is always going to be 0 anyway.
+
+ It is still work in progress, though -- it'd be good to somehow move the
+ theming code to ScrollbarThemeEfl, as right now scrollbar EDCs with a
+ non-zero min size will not cause the scrollbars to have non-zero size.
+
+ No new tests, this is machinery needed to run the current tests.
+
+ * platform/efl/ScrollbarEfl.cpp:
+ (ScrollbarEfl::ScrollbarEfl):
+ (ScrollbarEfl::setParent):
+
2011-10-20 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r97954.
Modified: trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp (97957 => 97958)
--- trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp 2011-10-20 10:25:06 UTC (rev 97957)
+++ trunk/Source/WebCore/platform/efl/ScrollbarEfl.cpp 2011-10-20 10:38:30 UTC (rev 97958)
@@ -53,7 +53,6 @@
, m_lastTotalSize(0)
, m_lastVisibleSize(0)
{
- Widget::setFrameRect(IntRect(0, 0, 0, 0));
}
ScrollbarEfl::~ScrollbarEfl()
@@ -90,7 +89,6 @@
void ScrollbarEfl::setParent(ScrollView* view)
{
Evas_Object* object = evasObject();
- Evas_Coord w, h;
Widget::setParent(view);
@@ -132,12 +130,6 @@
setPlatformWidget(object);
evas_object_smart_member_add(object, view->evasObject());
evas_object_show(object);
-
- edje_object_size_min_get(object, &w, &h);
-
- IntRect rect = frameRect();
- rect.setSize(IntSize(w, h));
- setFrameRect(rect);
}
void ScrollbarEfl::updateThumbPosition()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
