Title: [201477] trunk/Source/WebInspectorUI
- Revision
- 201477
- Author
- commit-qu...@webkit.org
- Date
- 2016-05-27 17:44:13 -0700 (Fri, 27 May 2016)
Log Message
Web Inspector: Not all transitively dominated nodes display their retained size
https://bugs.webkit.org/show_bug.cgi?id=158174
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-05-27
Reviewed by Timothy Hatcher.
* UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype._isDominatedByNonBaseParent):
Use the parent reference changing in the loop instead of always using the same parent.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201476 => 201477)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-28 00:07:35 UTC (rev 201476)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-28 00:44:13 UTC (rev 201477)
@@ -1,3 +1,14 @@
+2016-05-27 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Not all transitively dominated nodes display their retained size
+ https://bugs.webkit.org/show_bug.cgi?id=158174
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
+ (WebInspector.HeapSnapshotInstanceDataGridNode.prototype._isDominatedByNonBaseParent):
+ Use the parent reference changing in the loop instead of always using the same parent.
+
2016-05-27 Devin Rousso <dcrousso+web...@gmail.com>
Web Inspector: Add indicators to show nesting levels inside DOM Tree
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js (201476 => 201477)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-05-28 00:07:35 UTC (rev 201476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-05-28 00:44:13 UTC (rev 201477)
@@ -197,7 +197,7 @@
for (let p = this.parent; p; p = p.parent) {
if (p === this._base)
return false;
- if (this._node.dominatorNodeIdentifier === this.parent.node.id)
+ if (this._node.dominatorNodeIdentifier === p.node.id)
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
