Title: [201503] trunk/Source/WebInspectorUI
- Revision
- 201503
- Author
- bb...@apple.com
- Date
- 2016-05-30 20:25:40 -0700 (Mon, 30 May 2016)
Log Message
Web Inspector: Timelines: "-0.000ms" in Self Time
https://bugs.webkit.org/show_bug.cgi?id=158162
<rdar://problem/26523350>
Reviewed by Darin Adler.
Values such as -0.0000 and +0.00001 seem to indicate there is
some floating point error accumulating in profile node data.
Since the sampling profiler isn't accurate to that precision,
let's clean up the data so near-zero numbers are simply zero.
* UserInterface/Models/ProfileNode.js:
Round selfTime down to zero if it's less than the
smallest value we would show in the user interface.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201502 => 201503)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-30 20:26:25 UTC (rev 201502)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-31 03:25:40 UTC (rev 201503)
@@ -1,5 +1,22 @@
2016-05-30 Brian Burg <bb...@apple.com>
+ Web Inspector: Timelines: "-0.000ms" in Self Time
+ https://bugs.webkit.org/show_bug.cgi?id=158162
+ <rdar://problem/26523350>
+
+ Reviewed by Darin Adler.
+
+ Values such as -0.0000 and +0.00001 seem to indicate there is
+ some floating point error accumulating in profile node data.
+ Since the sampling profiler isn't accurate to that precision,
+ let's clean up the data so near-zero numbers are simply zero.
+
+ * UserInterface/Models/ProfileNode.js:
+ Round selfTime down to zero if it's less than the
+ smallest value we would show in the user interface.
+
+2016-05-30 Brian Burg <bb...@apple.com>
+
Web Inspector: Uncaught exception page should pre-populate the bug's URL with the inspected page URL
https://bugs.webkit.org/show_bug.cgi?id=158055
<rdar://problem/26516693>
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js (201502 => 201503)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js 2016-05-30 20:26:25 UTC (rev 201502)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js 2016-05-31 03:25:40 UTC (rev 201503)
@@ -158,6 +158,10 @@
for (var childNode of this._childNodes)
childNodesTotalTime += childNode.totalTime;
this._selfTime = this._totalTime - childNodesTotalTime;
+ // selfTime can negative or very close to zero due to floating point error.
+ // Since we show at most four decimal places, treat anything less as zero.
+ if (this._selfTime < 0.0001)
+ this._selfTime = 0.0;
}
return {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
