Title: [201626] trunk/Tools
Revision
201626
Author
[email protected]
Date
2016-06-02 16:33:42 -0700 (Thu, 02 Jun 2016)

Log Message

Really display failing JSC stress tests in buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=158324

Patch by Srinivasan Vijayaraghavan <[email protected]> on 2016-06-02
Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
membership in array.
(BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
generated after the first time.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js (201625 => 201626)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js	2016-06-02 23:14:33 UTC (rev 201625)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js	2016-06-02 23:33:42 UTC (rev 201626)
@@ -109,7 +109,7 @@
                     var message = this.revisionContentForIteration(mostRecentFinishedIteration, mostRecentFinishedIteration.productive ? mostRecentSuccessfulIteration : null);
                     if (!mostRecentFinishedIteration.productive) {
                         var status = StatusLineView.Status.Danger;
-                    } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && mostRecentFinishedIteration.failedTestSteps[0].name in ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"]) {
+                    } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(mostRecentFinishedIteration.failedTestSteps[0].name) >= 0) {
                         var failedStep = mostRecentFinishedIteration.failedTestSteps[0];
                         var URL = "" failedStep.name);
                         var statusView = new StatusLineView(message, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount, URL);

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (201625 => 201626)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2016-06-02 23:14:33 UTC (rev 201625)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2016-06-02 23:33:42 UTC (rev 201626)
@@ -251,7 +251,7 @@
             var results = new BuildbotTestResults(step);
             if (step.name === "layout-test")
                 this.layoutTestResults = results;
-            else if (step.name in ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"])
+            else if (["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(step.name) >= 0)
                 this._javascript_CoreTestResults = results;
             if (results.allPassed)
                 return;

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (201625 => 201626)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js	2016-06-02 23:14:33 UTC (rev 201625)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js	2016-06-02 23:33:42 UTC (rev 201626)
@@ -118,7 +118,7 @@
         var content = document.createElement("div");
         content.className = "test-results-popover";
 
-        this._addIterationHeadingToPopover(iteration, content, "_javascript_core test failures", iteration._javascript_CoreTestStdioUrlForIteration(iteration, testName));
+        this._addIterationHeadingToPopover(iteration, content, "_javascript_core test failures", iteration.queue.buildbot._javascript_CoreTestStdioUrlForIteration(iteration, testName));
         this._addDividerToPopover(content);
 
         if (!iteration._javascript_CoreTestResults.regressions) {
@@ -148,7 +148,7 @@
     _presentPopoverForJavaScriptCoreTestRegressions: function(testName, element, popover, iteration)
     {
         if (iteration._javascript_CoreTestResults.regressions)
-            var content = this._popoverContentForJavaScriptCoreTestRegressions(iteration);
+            var content = this._popoverContentForJavaScriptCoreTestRegressions(iteration, testName);
         else {
             var content = this._createLoadingIndicator(iteration, "_javascript_core test failures");
             iteration.loadJavaScriptCoreTestResults(testName, function() {

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (201625 => 201626)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js	2016-06-02 23:14:33 UTC (rev 201625)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js	2016-06-02 23:33:42 UTC (rev 201626)
@@ -105,7 +105,7 @@
                     if (failedStep.name === "layout-test") {
                         var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.tooManyFailures ? failedStep.failureCount + "\uff0b" : failedStep.failureCount, iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
                         new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
-                    } else if (failedStep.name in ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"]) {
+                    } else if (["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(failedStep.name) >= 0) {
                         var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount, iteration.queue.buildbot._javascript_CoreTestStdioUrlForIteration(iteration, failedStep.name));
                         new PopoverTracker(status.statusBubbleElement, this._presentPopoverForJavaScriptCoreTestRegressions.bind(this, failedStep.name), iteration);
                     } else {

Modified: trunk/Tools/ChangeLog (201625 => 201626)


--- trunk/Tools/ChangeLog	2016-06-02 23:14:33 UTC (rev 201625)
+++ trunk/Tools/ChangeLog	2016-06-02 23:33:42 UTC (rev 201626)
@@ -1,3 +1,22 @@
+2016-06-02  Srinivasan Vijayaraghavan  <[email protected]>
+
+        Really display failing JSC stress tests in buildbot dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=158324
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
+        (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+        (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
+        membership in array.
+        (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
+        generated after the first time.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+        (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
+
 2016-06-02  Michael Saboff  <[email protected]>
 
         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to