Diff
Modified: trunk/Source/WebCore/ChangeLog (201703 => 201704)
--- trunk/Source/WebCore/ChangeLog 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/ChangeLog 2016-06-06 03:19:21 UTC (rev 201704)
@@ -1,3 +1,19 @@
+2016-06-05 Zalan Bujtas <za...@apple.com>
+
+ Addressing post-review comments on r201635.
+
+ Reviewed by Chris Dumez.
+
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::computeRectForRepaint):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::RepaintContext::RepaintContext):
+ (WebCore::RenderObject::computeRectForRepaint):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderView.h:
+ * rendering/svg/RenderSVGForeignObject.h:
+ * rendering/svg/RenderSVGText.h:
+
2016-06-05 Yusuke Suzuki <utatane....@gmail.com>
Change ProxyObject.[[Get]] not to use custom accessor
Modified: trunk/Source/WebCore/rendering/RenderInline.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderInline.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderInline.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -145,7 +145,7 @@
LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const final;
- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const final;
+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const final;
void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override;
const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override;
Modified: trunk/Source/WebCore/rendering/RenderObject.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderObject.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -747,15 +747,15 @@
// Given a rect in the object's coordinate space, compute a rect suitable for repainting
// that rect in the coordinate space of repaintContainer.
struct RepaintContext {
- RepaintContext(bool hasPositionFixedDescendant, bool dirtyRectIsFlipped)
+ RepaintContext(bool hasPositionFixedDescendant = false, bool dirtyRectIsFlipped = false)
: m_hasPositionFixedDescendant(hasPositionFixedDescendant)
, m_dirtyRectIsFlipped(dirtyRectIsFlipped)
{
}
- bool m_hasPositionFixedDescendant { false };
- bool m_dirtyRectIsFlipped { false };
+ bool m_hasPositionFixedDescendant;
+ bool m_dirtyRectIsFlipped;
};
- virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const;
+ virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const;
virtual FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const;
virtual unsigned int length() const { return 1; }
Modified: trunk/Source/WebCore/rendering/RenderTableCell.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderTableCell.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderTableCell.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -153,7 +153,7 @@
bool boxShadowShouldBeAppliedToBackground(const LayoutPoint& paintOffset, BackgroundBleedAvoidance, InlineFlowBox*) const override;
LayoutSize offsetFromContainer(RenderElement&, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override;
- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
LayoutUnit borderHalfLeft(bool outer) const;
LayoutUnit borderHalfRight(bool outer) const;
Modified: trunk/Source/WebCore/rendering/RenderView.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderView.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderView.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -76,7 +76,7 @@
FrameView& frameView() const { return m_frameView; }
LayoutRect visualOverflowRect() const override;
- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
void repaintRootContents();
void repaintViewRectangle(const LayoutRect&) const;
void repaintViewAndCompositedLayers();
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -41,7 +41,7 @@
LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const override;
- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
bool requiresLayer() const override { return false; }
void layout() override;
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGText.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/svg/RenderSVGText.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGText.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -78,7 +78,7 @@
void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const override;
void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override;
