- Revision
- 201835
- Author
- cdu...@apple.com
- Date
- 2016-06-08 15:14:55 -0700 (Wed, 08 Jun 2016)
Log Message
First parameter to MessagePort / DedicatedWorkerGlobalScope.postMessage() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=158540
Reviewed by Geoffrey Garen.
Source/WebCore:
First parameter to MessagePort / DedicatedWorkerGlobalScope.postMessage() should be mandatory:
- https://html.spec.whatwg.org/multipage/comms.html#messageport
- https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-dedicatedworkerglobalscope-interface
Previously, WebKit send a bogus MessageEvent whose data attribute is undefined. This would
cause a testharness error when running the following W3C test:
- http://w3c-test.org/workers/interfaces.worker
Firefox and Chrome already correctly throw in this case. Our Window.postMessage() API is also
already throwing in this case.
Test: fast/workers/postMessage-missing-parameter.html
* bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage):
LayoutTests:
Add test coverage.
* fast/files/workers/inline-worker-via-blob-url.html:
* fast/workers/postMessage-missing-parameter-expected.txt: Added.
* fast/workers/postMessage-missing-parameter.html: Added.
* fast/workers/worker-messageport-expected.txt:
* fast/workers/worker-messageport.html:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (201834 => 201835)
--- trunk/LayoutTests/ChangeLog 2016-06-08 21:49:32 UTC (rev 201834)
+++ trunk/LayoutTests/ChangeLog 2016-06-08 22:14:55 UTC (rev 201835)
@@ -1,3 +1,18 @@
+2016-06-08 Chris Dumez <cdu...@apple.com>
+
+ First parameter to MessagePort / DedicatedWorkerGlobalScope.postMessage() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=158540
+
+ Reviewed by Geoffrey Garen.
+
+ Add test coverage.
+
+ * fast/files/workers/inline-worker-via-blob-url.html:
+ * fast/workers/postMessage-missing-parameter-expected.txt: Added.
+ * fast/workers/postMessage-missing-parameter.html: Added.
+ * fast/workers/worker-messageport-expected.txt:
+ * fast/workers/worker-messageport.html:
+
2016-06-08 Nan Wang <n_w...@apple.com>
For keyboard users, activating a fragment URL should transfer focus and caret to the destination
Modified: trunk/LayoutTests/fast/files/workers/inline-worker-via-blob-url.html (201834 => 201835)
--- trunk/LayoutTests/fast/files/workers/inline-worker-via-blob-url.html 2016-06-08 21:49:32 UTC (rev 201834)
+++ trunk/LayoutTests/fast/files/workers/inline-worker-via-blob-url.html 2016-06-08 22:14:55 UTC (rev 201835)
@@ -23,7 +23,7 @@
if (testRunner.notifyDone)
testRunner.notifyDone();
};
- worker.postMessage();
+ worker.postMessage("message");
}
if (window.testRunner) {
Added: trunk/LayoutTests/fast/workers/postMessage-missing-parameter-expected.txt (0 => 201835)
--- trunk/LayoutTests/fast/workers/postMessage-missing-parameter-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/workers/postMessage-missing-parameter-expected.txt 2016-06-08 22:14:55 UTC (rev 201835)
@@ -0,0 +1,10 @@
+Tests that calling DedicatedWorkerGlobalScope.postMessage() without parameter throws an exception
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+postMessage(): TypeError: Not enough arguments
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/workers/postMessage-missing-parameter.html (0 => 201835)
--- trunk/LayoutTests/fast/workers/postMessage-missing-parameter.html (rev 0)
+++ trunk/LayoutTests/fast/workers/postMessage-missing-parameter.html 2016-06-08 22:14:55 UTC (rev 201835)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<script src=""
+<script src=""
+<script>
+
+var jsTestIsAsync = true;
+
+description('Tests that calling DedicatedWorkerGlobalScope.postMessage() without parameter throws an exception');
+
+var worker = createWorker();
+worker.postMessage("eval postMessage()");
+worker.postMessage("eval DONE");
+
+worker._onmessage_ = function(evt) {
+ if (!/DONE/.test(evt.data))
+ debug(evt.data.replace(new RegExp("/.*LayoutTests"), "<...>"));
+ else
+ finishJSTest();
+};
+
+</script>
+<script src=""
Modified: trunk/LayoutTests/fast/workers/worker-messageport-expected.txt (201834 => 201835)
--- trunk/LayoutTests/fast/workers/worker-messageport-expected.txt 2016-06-08 21:49:32 UTC (rev 201834)
+++ trunk/LayoutTests/fast/workers/worker-messageport-expected.txt 2016-06-08 22:14:55 UTC (rev 201835)
@@ -4,6 +4,7 @@
PASS: Received message port
PASS: Received response from Worker via MessagePort
PASS: Got port from worker
+PASS: Calling MessagePort.postMessage() without parameter threw exception: TypeError: Not enough arguments
PASS: Received final response from worker
PASS: Got 1000 messages
DONE
Modified: trunk/LayoutTests/fast/workers/worker-messageport.html (201834 => 201835)
--- trunk/LayoutTests/fast/workers/worker-messageport.html 2016-06-08 21:49:32 UTC (rev 201834)
+++ trunk/LayoutTests/fast/workers/worker-messageport.html 2016-06-08 22:14:55 UTC (rev 201835)
@@ -51,6 +51,13 @@
log("FAIL: Got the wrong number of ports from worker: " + evt.ports.length);
} else {
log("PASS: Got port from worker");
+ try {
+ // Missing parameter, should throw.
+ evt.ports[0].postMessage();
+ log("FAIL: Calling MessagePort.postMessage() without parameter did not throw.");
+ } catch (e) {
+ log("PASS: Calling MessagePort.postMessage() without parameter threw exception: " + e);
+ }
evt.ports[0].postMessage("ping");
evt.ports[0]._onmessage_ = function(evt) {
if (evt.data == "pong") {
Modified: trunk/Source/WebCore/ChangeLog (201834 => 201835)
--- trunk/Source/WebCore/ChangeLog 2016-06-08 21:49:32 UTC (rev 201834)
+++ trunk/Source/WebCore/ChangeLog 2016-06-08 22:14:55 UTC (rev 201835)
@@ -1,3 +1,26 @@
+2016-06-08 Chris Dumez <cdu...@apple.com>
+
+ First parameter to MessagePort / DedicatedWorkerGlobalScope.postMessage() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=158540
+
+ Reviewed by Geoffrey Garen.
+
+ First parameter to MessagePort / DedicatedWorkerGlobalScope.postMessage() should be mandatory:
+ - https://html.spec.whatwg.org/multipage/comms.html#messageport
+ - https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-dedicatedworkerglobalscope-interface
+
+ Previously, WebKit send a bogus MessageEvent whose data attribute is undefined. This would
+ cause a testharness error when running the following W3C test:
+ - http://w3c-test.org/workers/interfaces.worker
+
+ Firefox and Chrome already correctly throw in this case. Our Window.postMessage() API is also
+ already throwing in this case.
+
+ Test: fast/workers/postMessage-missing-parameter.html
+
+ * bindings/js/JSMessagePortCustom.h:
+ (WebCore::handlePostMessage):
+
2016-06-08 Gavin Barraclough <barraclo...@apple.com>
Remove removeDirect
Modified: trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h (201834 => 201835)
--- trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h 2016-06-08 21:49:32 UTC (rev 201834)
+++ trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h 2016-06-08 22:14:55 UTC (rev 201835)
@@ -32,6 +32,7 @@
#define JSMessagePortCustom_h
#include "MessagePort.h"
+#include <runtime/Error.h>
#include <runtime/JSCInlines.h>
#include <runtime/JSCJSValue.h>
#include <wtf/Forward.h>
@@ -49,10 +50,13 @@
template <typename T>
inline JSC::JSValue handlePostMessage(JSC::ExecState& state, T* impl)
{
+ if (UNLIKELY(state.argumentCount() < 1))
+ return state.vm().throwException(&state, createNotEnoughArgumentsError(&state));
+
MessagePortArray portArray;
ArrayBufferArray arrayBufferArray;
fillMessagePortArray(state, state.argument(1), portArray, arrayBufferArray);
- RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(&state, state.argument(0), &portArray, &arrayBufferArray);
+ RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(&state, state.uncheckedArgument(0), &portArray, &arrayBufferArray);
if (state.hadException())
return JSC::jsUndefined();
