Title: [202049] trunk
- Revision
- 202049
- Author
- [email protected]
- Date
- 2016-06-14 09:46:26 -0700 (Tue, 14 Jun 2016)
Log Message
WebRTC: RTCPeerConnection::addTrack() should throw InvalidAccessError instead of InvalidModificationError.
https://bugs.webkit.org/show_bug.cgi?id=158735
Reviewed by Eric Carlson.
Source/WebCore:
Throw InvalidAccessError instead of InvalidModificationError when track already exists in connection's
set of senders as per specification (https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addtrack).
Updated existing test results: fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
LayoutTests:
Check that an InvalidAccessError exception is thrown when the track already exists in set of senders.
* fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (202048 => 202049)
--- trunk/LayoutTests/ChangeLog 2016-06-14 16:41:18 UTC (rev 202048)
+++ trunk/LayoutTests/ChangeLog 2016-06-14 16:46:26 UTC (rev 202049)
@@ -1,3 +1,14 @@
+2016-06-14 Nael Ouedraogo <[email protected]>
+
+ WebRTC: RTCPeerConnection::addTrack() should throw InvalidAccessError instead of InvalidModificationError.
+ https://bugs.webkit.org/show_bug.cgi?id=158735
+
+ Reviewed by Eric Carlson.
+
+ Check that an InvalidAccessError exception is thrown when the track already exists in set of senders.
+
+ * fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
+
2016-06-14 Adam Bergkvist <[email protected]>
WebRTC: Imlement MediaEndpointPeerConnection::addIceCandidate()
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt (202048 => 202049)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt 2016-06-14 16:41:18 UTC (rev 202048)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt 2016-06-14 16:46:26 UTC (rev 202049)
@@ -32,7 +32,7 @@
PASS transceiver.receiver is receiver
PASS transceiver.stopped is false
Try to add same track again
-PASS sender = pc.addTrack(track, stream) threw exception Error: InvalidModificationError: DOM Exception 13.
+PASS sender = pc.addTrack(track, stream) threw exception Error: InvalidAccessError: DOM Exception 15.
PASS sender2 = pc.addTrack(track2, stream, stream2) did not throw exception.
PASS pc.getSenders().length is 2
PASS pc.getSenders()[0] is sender
Modified: trunk/Source/WebCore/ChangeLog (202048 => 202049)
--- trunk/Source/WebCore/ChangeLog 2016-06-14 16:41:18 UTC (rev 202048)
+++ trunk/Source/WebCore/ChangeLog 2016-06-14 16:46:26 UTC (rev 202049)
@@ -1,3 +1,18 @@
+2016-06-14 Nael Ouedraogo <[email protected]>
+
+ WebRTC: RTCPeerConnection::addTrack() should throw InvalidAccessError instead of InvalidModificationError.
+ https://bugs.webkit.org/show_bug.cgi?id=158735
+
+ Reviewed by Eric Carlson.
+
+ Throw InvalidAccessError instead of InvalidModificationError when track already exists in connection's
+ set of senders as per specification (https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addtrack).
+
+ Updated existing test results: fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt
+
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::addTrack):
+
2016-06-14 Adam Bergkvist <[email protected]>
WebRTC: Imlement MediaEndpointPeerConnection::addIceCandidate()
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (202048 => 202049)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2016-06-14 16:41:18 UTC (rev 202048)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2016-06-14 16:46:26 UTC (rev 202049)
@@ -115,8 +115,7 @@
for (auto& sender : m_transceiverSet->getSenders()) {
if (sender->trackId() == track->id()) {
- // FIXME: Spec says InvalidParameter
- ec = INVALID_MODIFICATION_ERR;
+ ec = INVALID_ACCESS_ERR;
return nullptr;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
