Title: [202073] trunk/Source/WebInspectorUI
Revision
202073
Author
nvasil...@apple.com
Date
2016-06-14 17:43:23 -0700 (Tue, 14 Jun 2016)

Log Message

Web Inspector: Visual Sidebar: Remove "Text -> Content" subsection
https://bugs.webkit.org/show_bug.cgi?id=158758
<rdar://problem/26799628>

Reviewed by Timothy Hatcher.

"content" CSS property only works with pseudo elements ::before and ::after.
It doesn't do anything for regular (non pseudo) elements. Remove it to
reduce UI clutter.

* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection): Deleted.
* UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container)): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (202072 => 202073)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-06-15 00:42:51 UTC (rev 202072)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-06-15 00:43:23 UTC (rev 202073)
@@ -1,3 +1,21 @@
+2016-06-14  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: Visual Sidebar: Remove "Text -> Content" subsection
+        https://bugs.webkit.org/show_bug.cgi?id=158758
+        <rdar://problem/26799628>
+
+        Reviewed by Timothy Hatcher.
+
+        "content" CSS property only works with pseudo elements ::before and ::after.
+        It doesn't do anything for regular (non pseudo) elements. Remove it to
+        reduce UI clutter.
+
+        * UserInterface/Views/VisualStyleDetailsPanel.js:
+        (WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
+        (WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection): Deleted.
+        * UserInterface/Views/VisualStylePropertyEditor.css:
+        (.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container)): Deleted.
+
 2016-06-14  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Rename Timeline.setAutoCaptureInstruments to Timeline.setInstruments

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (202072 => 202073)


--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2016-06-15 00:42:51 UTC (rev 202072)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2016-06-15 00:43:23 UTC (rev 202073)
@@ -91,14 +91,13 @@
         this.element.appendChild(this._sections.layout.element);
 
         // Text Section
-        this._generateSection("content", WebInspector.UIString("Content"));
         this._generateSection("text-style", WebInspector.UIString("Style"));
         this._generateSection("font", WebInspector.UIString("Font"));
         this._generateSection("font-variants", WebInspector.UIString("Variants"));
         this._generateSection("text-spacing", WebInspector.UIString("Spacing"));
         this._generateSection("text-shadow", WebInspector.UIString("Shadow"));
 
-        this._sections.text = new WebInspector.DetailsSection("text", WebInspector.UIString("Text"), [this._groups.content.section, this._groups.textStyle.section, this._groups.font.section, this._groups.fontVariants.section, this._groups.textSpacing.section, this._groups.textShadow.section]);
+        this._sections.text = new WebInspector.DetailsSection("text", WebInspector.UIString("Text"), [this._groups.textStyle.section, this._groups.font.section, this._groups.fontVariants.section, this._groups.textSpacing.section, this._groups.textShadow.section]);
         this.element.appendChild(this._sections.text.element);
 
         // Background Section
@@ -650,21 +649,6 @@
         properties.alignSelf.addDependency("display", allowedDisplayValues);
     }
 
-    _populateContentSection()
-    {
-        let group = this._groups.content;
-        let properties = group.properties;
-
-        let contentRow = new WebInspector.DetailsSectionRow;
-
-        properties.content = new WebInspector.VisualStyleBasicInput("content", null, WebInspector.UIString("Enter a value"));
-
-        contentRow.element.appendChild(properties.content.element);
-
-        let contentGroup = new WebInspector.DetailsSectionGroup([contentRow]);
-        this._populateSection(group, [contentGroup]);
-    }
-
     _populateTextStyleSection()
     {
         let group = this._groups.textStyle;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css (202072 => 202073)


--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css	2016-06-15 00:42:51 UTC (rev 202072)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css	2016-06-15 00:43:23 UTC (rev 202073)
@@ -89,10 +89,6 @@
     opacity: 0.4;
 }
 
-.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) {
-    margin-left: 11px;
-}
-
 .visual-style-property-container > .visual-style-property-value-container select {
     width: 100%;
     margin: 1px 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to