Diff
Modified: trunk/LayoutTests/ChangeLog (202194 => 202195)
--- trunk/LayoutTests/ChangeLog 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/LayoutTests/ChangeLog 2016-06-18 03:29:49 UTC (rev 202195)
@@ -1,3 +1,28 @@
+2016-06-17 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r202068, r202115, and r202128.
+ https://bugs.webkit.org/show_bug.cgi?id=158896
+
+ The new test is very unstable, timing out frequently
+ (Requested by ap on #webkit).
+
+ Reverted changesets:
+
+ "decompose4 return value is unchecked, leading to potentially
+ uninitialized data."
+ https://bugs.webkit.org/show_bug.cgi?id=158761
+ http://trac.webkit.org/changeset/202068
+
+ "[mac] LayoutTest transforms/undecomposable.html is a flaky
+ timeout"
+ https://bugs.webkit.org/show_bug.cgi?id=158816
+ http://trac.webkit.org/changeset/202115
+
+ "[mac] LayoutTest transforms/undecomposable.html is a flaky
+ timeout"
+ https://bugs.webkit.org/show_bug.cgi?id=158816
+ http://trac.webkit.org/changeset/202128
+
2016-06-17 Chris Fleizach <cfleiz...@apple.com>
AX: HTML indeterminate IDL attribute not mapped to checkbox value=2 for native checkboxes
Deleted: trunk/LayoutTests/transforms/undecomposable-expected.txt (202194 => 202195)
--- trunk/LayoutTests/transforms/undecomposable-expected.txt 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/LayoutTests/transforms/undecomposable-expected.txt 2016-06-18 03:29:49 UTC (rev 202195)
@@ -1 +0,0 @@
-
Deleted: trunk/LayoutTests/transforms/undecomposable.html (202194 => 202195)
--- trunk/LayoutTests/transforms/undecomposable.html 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/LayoutTests/transforms/undecomposable.html 2016-06-18 03:29:49 UTC (rev 202195)
@@ -1,31 +0,0 @@
-<style>
-.box {
- width: 100px;
- height: 100px;
- background-color: blue;
- animation-duration: 200ms;
-}
-
-@keyframes funky {
- from {
- transform: matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0);
- }
- to {
- transform: matrix3d(2, 0, 0, 0, 0, 2, 0, 0, 0, 0, 2, 0, 0, 0, 0, 2);
- }
-}
-</style>
-<div class="box"></div>
-<script>
-if (window.testRunner) {
- window.testRunner.dumpAsText();
- window.testRunner.waitUntilDone();
- document.querySelector(".box").addEventListener("animationend", function () {
- window.testRunner.notifyDone();
- }, false);
-}
-window.addEventListener("load", function () {
- document.querySelector(".box").style.animationName = "funky";
-}, false);
-</script>
-
Modified: trunk/Source/WebCore/ChangeLog (202194 => 202195)
--- trunk/Source/WebCore/ChangeLog 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/Source/WebCore/ChangeLog 2016-06-18 03:29:49 UTC (rev 202195)
@@ -1,3 +1,28 @@
+2016-06-17 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r202068, r202115, and r202128.
+ https://bugs.webkit.org/show_bug.cgi?id=158896
+
+ The new test is very unstable, timing out frequently
+ (Requested by ap on #webkit).
+
+ Reverted changesets:
+
+ "decompose4 return value is unchecked, leading to potentially
+ uninitialized data."
+ https://bugs.webkit.org/show_bug.cgi?id=158761
+ http://trac.webkit.org/changeset/202068
+
+ "[mac] LayoutTest transforms/undecomposable.html is a flaky
+ timeout"
+ https://bugs.webkit.org/show_bug.cgi?id=158816
+ http://trac.webkit.org/changeset/202115
+
+ "[mac] LayoutTest transforms/undecomposable.html is a flaky
+ timeout"
+ https://bugs.webkit.org/show_bug.cgi?id=158816
+ http://trac.webkit.org/changeset/202128
+
2016-06-17 Chris Fleizach <cfleiz...@apple.com>
AX: HTML indeterminate IDL attribute not mapped to checkbox value=2 for native checkboxes
Modified: trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp (202194 => 202195)
--- trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp 2016-06-18 03:29:49 UTC (rev 202195)
@@ -60,11 +60,11 @@
toT.applyPerspective(floatValueForLength(toP, 1));
toT.blend(fromT, progress);
TransformationMatrix::Decomposed4Type decomp;
- if (toT.decompose4(decomp)) {
- if (decomp.perspectiveZ) {
- double val = -1.0 / decomp.perspectiveZ;
- return PerspectiveTransformOperation::create(Length(clampToPositiveInteger(val), Fixed));
- }
+ toT.decompose4(decomp);
+
+ if (decomp.perspectiveZ) {
+ double val = -1.0 / decomp.perspectiveZ;
+ return PerspectiveTransformOperation::create(Length(clampToPositiveInteger(val), Fixed));
}
return PerspectiveTransformOperation::create(Length(0, Fixed));
}
Modified: trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp (202194 => 202195)
--- trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp 2016-06-18 03:29:49 UTC (rev 202195)
@@ -78,8 +78,7 @@
// Extract the result as a quaternion
TransformationMatrix::Decomposed4Type decomp;
- if (!toT.decompose4(decomp))
- return RotateTransformOperation::create(m_x, m_y, m_z, m_angle - m_angle * progress, m_type);;
+ toT.decompose4(decomp);
// Convert that to Axis/Angle form
double x = -decomp.quaternionX;
Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp (202194 => 202195)
--- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2016-06-18 03:29:49 UTC (rev 202195)
@@ -365,10 +365,9 @@
return false;
int i, j;
- for (i = 0; i < 4; i++) {
+ for (i = 0; i < 4; i++)
for (j = 0; j < 4; j++)
localMatrix[i][j] /= localMatrix[3][3];
- }
// perspectiveMatrix is used to solve for perspective, but it also provides
// an easy way to test for singularity of the upper 3x3 component.
@@ -1542,10 +1541,8 @@
{
Decomposed4Type fromDecomp;
Decomposed4Type toDecomp;
- if (!from.decompose4(fromDecomp))
- return;
- if (!decompose4(toDecomp))
- return;
+ from.decompose4(fromDecomp);
+ decompose4(toDecomp);
blendFloat(fromDecomp.scaleX, toDecomp.scaleX, progress);
blendFloat(fromDecomp.scaleY, toDecomp.scaleY, progress);
Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h (202194 => 202195)
--- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h 2016-06-18 01:19:13 UTC (rev 202194)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h 2016-06-18 03:29:49 UTC (rev 202195)
@@ -272,23 +272,11 @@
};
struct Decomposed4Type {
- double scaleX { 1 };
- double scaleY { 1 };
- double scaleZ { 1 };
- double skewXY { 0 };
- double skewXZ { 0 };
- double skewYZ { 0 };
- double quaternionX { 0 };
- double quaternionY { 0 };
- double quaternionZ { 0 };
- double quaternionW { 0 };
- double translateX { 0 };
- double translateY { 0 };
- double translateZ { 0 };
- double perspectiveX { 0 };
- double perspectiveY { 0 };
- double perspectiveZ { 0 };
- double perspectiveW { 1 };
+ double scaleX, scaleY, scaleZ;
+ double skewXY, skewXZ, skewYZ;
+ double quaternionX, quaternionY, quaternionZ, quaternionW;
+ double translateX, translateY, translateZ;
+ double perspectiveX, perspectiveY, perspectiveZ, perspectiveW;
bool operator==(const Decomposed4Type& other) const
{
