Title: [98084] trunk/Source/WebKit/efl
- Revision
- 98084
- Author
- [email protected]
- Date
- 2011-10-21 01:32:01 -0700 (Fri, 21 Oct 2011)
Log Message
[EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
https://bugs.webkit.org/show_bug.cgi?id=65680
Patch by Grzegorz Czajkowski <[email protected]> on 2011-10-21
Reviewed by Ryosuke Niwa.
Generally API methods using macros NULL checking in WebKit-EFL.
The macros ensure that code is smaller, version of view object
is checked and error message is displayed if NULL is passed.
* ewk/ewk_view.cpp:
(ewk_view_mode_get):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (98083 => 98084)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-21 08:24:08 UTC (rev 98083)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-21 08:32:01 UTC (rev 98084)
@@ -1,3 +1,17 @@
+2011-10-21 Grzegorz Czajkowski <[email protected]>
+
+ [EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
+ https://bugs.webkit.org/show_bug.cgi?id=65680
+
+ Reviewed by Ryosuke Niwa.
+
+ Generally API methods using macros NULL checking in WebKit-EFL.
+ The macros ensure that code is smaller, version of view object
+ is checked and error message is displayed if NULL is passed.
+
+ * ewk/ewk_view.cpp:
+ (ewk_view_mode_get):
+
2011-10-19 Rafael Antognolli <[email protected]>
[EFL] Fix typos on ewk_view and ewk_js.
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (98083 => 98084)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-21 08:24:08 UTC (rev 98083)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-21 08:32:01 UTC (rev 98084)
@@ -3788,14 +3788,9 @@
Ewk_View_Mode ewk_view_mode_get(const Evas_Object* ewkView)
{
Ewk_View_Mode mode = EWK_VIEW_MODE_WINDOWED;
+ EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, mode);
+ EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, mode);
- EWK_VIEW_SD_GET(ewkView, sd);
- if (!sd)
- return mode;
- EWK_VIEW_PRIV_GET(sd, priv);
- if (!priv)
- return mode;
-
switch (priv->page->viewMode()) {
case WebCore::Page::ViewModeFloating:
mode = EWK_VIEW_MODE_FLOATING;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
