Title: [202412] trunk
Revision
202412
Author
simon.fra...@apple.com
Date
2016-06-23 20:34:12 -0700 (Thu, 23 Jun 2016)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=159077

Tools:

Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
snapshot the final state of the test in release builds.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):

LayoutTests:

Mark fast/harness/snapshot-captures-compositing.html as an image failure.

* platform/ios-simulator-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (202411 => 202412)


--- trunk/LayoutTests/ChangeLog	2016-06-24 02:50:59 UTC (rev 202411)
+++ trunk/LayoutTests/ChangeLog	2016-06-24 03:34:12 UTC (rev 202412)
@@ -1,3 +1,11 @@
+2016-06-23  Simon Fraser  <simon.fra...@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=159077
+
+        Mark fast/harness/snapshot-captures-compositing.html as an image failure.
+
+        * platform/ios-simulator-wk2/TestExpectations:
+
 2016-06-23  Benjamin Poulain  <benja...@webkit.org>
 
         Specialize synchronous event tracking per event type

Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (202411 => 202412)


--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-06-24 02:50:59 UTC (rev 202411)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-06-24 03:34:12 UTC (rev 202412)
@@ -1899,3 +1899,5 @@
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
 
 webkit.org/b/157990 [ Release ] mathml/wbr-in-mroot-crash.html [ Pass Timeout ]
+
+webkit.org/b/159077 fast/harness/snapshot-captures-compositing.html [ ImageOnlyFailure ]

Modified: trunk/Tools/ChangeLog (202411 => 202412)


--- trunk/Tools/ChangeLog	2016-06-24 02:50:59 UTC (rev 202411)
+++ trunk/Tools/ChangeLog	2016-06-24 03:34:12 UTC (rev 202412)
@@ -1,5 +1,15 @@
 2016-06-23  Simon Fraser  <simon.fra...@apple.com>
 
+        https://bugs.webkit.org/show_bug.cgi?id=159077
+
+        Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
+        snapshot the final state of the test in release builds. 
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::dump):
+
+2016-06-23  Simon Fraser  <simon.fra...@apple.com>
+
         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
 
         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (202411 => 202412)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp	2016-06-24 02:50:59 UTC (rev 202411)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp	2016-06-24 03:34:12 UTC (rev 202412)
@@ -895,7 +895,12 @@
         injectedBundle.dumpBackForwardListsForAllPages(stringBuilder);
 
     if (injectedBundle.shouldDumpPixels() && injectedBundle.testRunner()->shouldDumpPixels()) {
+#if PLATFORM(IOS)
+        // PlatformWebView::windowSnapshotImage() has timing problems, so use WebProcess snapshots for now.
+        bool shouldCreateSnapshot = true;
+#else
         bool shouldCreateSnapshot = injectedBundle.testRunner()->isPrinting();
+#endif
         if (shouldCreateSnapshot) {
             WKSnapshotOptions options = kWKSnapshotOptionsShareable;
             WKRect snapshotRect = WKBundleFrameGetVisibleContentBounds(WKBundlePageGetMainFrame(m_page));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to