Title: [202924] trunk/Source/WebCore
- Revision
- 202924
- Author
- bda...@apple.com
- Date
- 2016-07-07 11:57:42 -0700 (Thu, 07 Jul 2016)
Log Message
All fullscreen videos should be able the control the controls manager
https://bugs.webkit.org/show_bug.cgi?id=159496
-and corresponding-
rdar://problem/27009446
Reviewed by Eric Carlson.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::fullscreenModeChanged):
* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canControlControlsManager):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202923 => 202924)
--- trunk/Source/WebCore/ChangeLog 2016-07-07 18:53:19 UTC (rev 202923)
+++ trunk/Source/WebCore/ChangeLog 2016-07-07 18:57:42 UTC (rev 202924)
@@ -1,3 +1,17 @@
+2016-07-07 Beth Dakin <bda...@apple.com>
+
+ All fullscreen videos should be able the control the controls manager
+ https://bugs.webkit.org/show_bug.cgi?id=159496
+ -and corresponding-
+ rdar://problem/27009446
+
+ Reviewed by Eric Carlson.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::fullscreenModeChanged):
+ * html/MediaElementSession.cpp:
+ (WebCore::MediaElementSession::canControlControlsManager):
+
2016-07-07 Jer Noble <jer.no...@apple.com>
Crash due to HTMLMediaElement at _javascript_Core: JSC::JSLockHolder::JSLockHolder
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (202923 => 202924)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-07-07 18:53:19 UTC (rev 202923)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-07-07 18:57:42 UTC (rev 202924)
@@ -7148,6 +7148,7 @@
m_videoFullscreenMode = mode;
m_mediaSession->scheduleClientDataBufferingCheck();
+ scheduleUpdatePlaybackControlsManager();
}
}
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (202923 => 202924)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2016-07-07 18:53:19 UTC (rev 202923)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2016-07-07 18:57:42 UTC (rev 202924)
@@ -213,6 +213,11 @@
bool MediaElementSession::canControlControlsManager() const
{
+ if (m_element.isFullscreen()) {
+ LOG(Media, "MediaElementSession::canControlControlsManager - returning TRUE: Is fullscreen");
+ return true;
+ }
+
if (!m_element.hasAudio()) {
LOG(Media, "MediaElementSession::canControlControlsManager - returning FALSE: No audio");
return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
