Title: [98173] trunk/Source/WebCore
Revision
98173
Author
o...@chromium.org
Date
2011-10-21 17:10:58 -0700 (Fri, 21 Oct 2011)

Log Message

r97693 caused 42 failures on the chromium mac bots
https://bugs.webkit.org/show_bug.cgi?id=70300

Can't test this until https://bugs.webkit.org/show_bug.cgi?id=70660
is fixed. The fix for that bug will test this codepath as well though.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (98172 => 98173)


--- trunk/Source/WebCore/ChangeLog	2011-10-22 00:04:18 UTC (rev 98172)
+++ trunk/Source/WebCore/ChangeLog	2011-10-22 00:10:58 UTC (rev 98173)
@@ -1,3 +1,14 @@
+2011-10-21  Ojan Vafai  <o...@chromium.org>
+
+        r97693 caused 42 failures on the chromium mac bots
+        https://bugs.webkit.org/show_bug.cgi?id=70300
+
+        Can't test this until https://bugs.webkit.org/show_bug.cgi?id=70660
+        is fixed. The fix for that bug will test this codepath as well though.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
+
 2011-10-21  Vineet Chaudhary  <vineet.chaudh...@motorola.com>
 
         Setting form.enctype reflected attribute behaves strangely.

Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (98172 => 98173)


--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-10-22 00:04:18 UTC (rev 98172)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-10-22 00:10:58 UTC (rev 98173)
@@ -5258,7 +5258,7 @@
         if (child->isBox() && child->isHorizontalWritingMode() != isHorizontalWritingMode()) {
             RenderBox* childBox = toRenderBox(child);
             LayoutUnit oldHeight = childBox->logicalHeight();
-            setLogicalHeight(childBox->borderAndPaddingLogicalHeight());
+            childBox->setLogicalHeight(childBox->borderAndPaddingLogicalHeight());
             childBox->computeLogicalHeight();
             childMinPreferredLogicalWidth = childMaxPreferredLogicalWidth = childBox->logicalHeight();
             childBox->setLogicalHeight(oldHeight);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to