Title: [203198] trunk/Source/WebInspectorUI
Revision
203198
Author
[email protected]
Date
2016-07-13 16:33:39 -0700 (Wed, 13 Jul 2016)

Log Message

Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.showsFilterBar')
https://bugs.webkit.org/show_bug.cgi?id=159696
<rdar://problem/27312356>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
Early return if content view not visible, since the event is sent during
tab teardown and the current TimelineView may be invalid.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (203197 => 203198)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-07-13 22:43:30 UTC (rev 203197)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-07-13 23:33:39 UTC (rev 203198)
@@ -1,3 +1,16 @@
+2016-07-13  Matt Baker  <[email protected]>
+
+        Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.showsFilterBar')
+        https://bugs.webkit.org/show_bug.cgi?id=159696
+        <rdar://problem/27312356>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
+        Early return if content view not visible, since the event is sent during
+        tab teardown and the current TimelineView may be invalid.
+
 2016-07-12  Joseph Pecoraro  <[email protected]>
 
         REGRESSION(r192789): Web Inspector: Log Value context menu appears twice

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (203197 => 203198)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-07-13 22:43:30 UTC (rev 203197)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-07-13 23:33:39 UTC (rev 203198)
@@ -319,6 +319,9 @@
 
     _contentViewSelectionPathComponentDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         if (event.target !== this._timelineContentBrowser.currentContentView)
             return;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to